Alon Bar-Lev has posted comments on this change.
Change subject: aaa: search by user and groups name when added via rest-api
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32150
To unsubscribe, visit http
Martin Peřina has posted comments on this change.
Change subject: core: fixing other_dc proxy preference implementation
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32108
To unsubscribe, visit http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: search by user and groups name when added via rest-api
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_ch
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: search by user and groups name when added via rest-api
..
Patch Set 1:
* Update tracker::#1120720::OK
* Check Bug-Url::OK
* Check Public Bug::#112072
Hello Yair Zaslavsky,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/32150
to review the following change.
Change subject: aaa: search by user and groups name when added via rest-api
..
aaa: search
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: Updating default storage type question
..
Patch Set 6: Code-Review+1
Eli, ok for the SQL change?
--
To view, visit http://gerrit.ovirt.org
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: reading VDSM supported cluster levels from
file
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32142/2/packaging/setup/plugins/ov
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add support to principal field in ui,rest-api, and
built-in extension
..
Patch Set 12: Code-Review+1
not sure I understand why we do not squash these two pa
Alon Bar-Lev has posted comments on this change.
Change subject: extapi: Changing fetch principal to support principal
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/31790/7/backend/manager/modules/extensions-api-root
Sandro Bonazzola has posted comments on this change.
Change subject: webadmin,userportal: Fix Maven build-time warnings
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32145/1/frontend/webadmin/modules/gwt-extension/po
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Add support to principal field in ui,rest-api, and
built-in extension
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: extapi: Changing fetch principal to support principal
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_check
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Add support to principal field in ui,rest-api, and
built-in extension
..
Patch Set 12:
What did you mean by your last comment?
In addition I have changed
automat...@ovirt.org has posted comments on this change.
Change subject: extapi: Changing fetch principal to support principal
..
Patch Set 7:
* Update tracker::#1127623::OK
* Check Bug-Url::OK
* Check Public Bug::#1127623::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Add support to principal field in ui,rest-api, and
built-in extension
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::W
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine_page: use augeas instead of Management()
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-node-plugin-vdsm_master_gerrit/39
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine_page: use augeas instead of Management()
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32148
To unsubscribe, visit ht
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: engine_page: use augeas instead of Management()
..
engine_page: use augeas instead of Management()
To manage values in /etc/default/ovirt we use Ma
automat...@ovirt.org has posted comments on this change.
Change subject: engine_page: use augeas instead of Management()
..
Patch Set 1:
* Update tracker::#1088875::OK
--
To view, visit http://gerrit.ovirt.org/32148
To unsubs
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: search by user and groups name when added via rest-api
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-uni
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: search by user and groups name when added via rest-api
..
Patch Set 8: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31709
To unsubsc
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: search by user and groups name when added via rest-api
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Yair Zaslavsky has submitted this change and it was merged.
Change subject: aaa: search by user and groups name when added via rest-api
..
aaa: search by user and groups name when added via rest-api
Topic: AAA
Change-Id: I76c5d
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Add support to principal field in ui,rest-api, and
built-in extension
..
Patch Set 11:
please do not expose end-user visible texts and developer/program vis
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Add support to principal field in ui,rest-api, and
built-in extension
..
Patch Set 11:
I would not try to sync if API would not have a "user_name" field.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal,webadmin: persistent column widths
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ge
Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: persistent column widths
..
Patch Set 1: Verified-1
Hmm okay well the generated ids do change between compiles. So this won't work
unless
Alexander Wels has posted comments on this change.
Change subject: userportal,webadmin: persistent column widths
..
Patch Set 1: Verified+1
In my quick smoke test this appears to now properly keep the columns, even on
differen
automat...@ovirt.org has posted comments on this change.
Change subject: userportal,webadmin: persistent column widths
..
Patch Set 1:
* Update tracker::#1124546::OK
* Check Bug-Url::OK
* Check Public Bug::#1124546::OK, public
Alexander Wels has uploaded a new change for review.
Change subject: userportal,webadmin: persistent column widths
..
userportal,webadmin: persistent column widths
- The column widths were persisted based partially on the
asso
Allon Mureinik has posted comments on this change.
Change subject: core: clone VM from snapshot - validate VirtIO-SCSI
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31945
To unsubscribe, visit http://
Allon Mureinik has posted comments on this change.
Change subject: packaging: setup: Updating default storage type question
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31965
To unsubscribe, visit ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-
automat...@ovirt.org has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 2:
* Update tracker::#1134382::OK
* Update tracker::#1134434::OK
* Check TR::#11343
Daniel Erez has submitted this change and it was merged.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
RemoveDiskSnapshotTaskHandler ->
*
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin,userportal: Fix Maven build-time warnings
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit
Alexander Wels has posted comments on this change.
Change subject: webadmin,userportal: Fix Maven build-time warnings
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32145
To unsubscribe, visit http://g
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Fix Maven build-time warnings
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32145
To unsubscribe, visit http://gerri
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin,userportal: Fix Maven build-time warnings
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Fix Maven build-time warnings
..
webadmin,userportal: Fix Maven build-time warnings
1. gwt-extension POM now uses ${project.version} instea
Oved Ourfali has posted comments on this change.
Change subject: core: fixing a missing fencing audit log message
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31952
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32143
To unsubscribe, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: soundcard not persisted on new instance type
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/454/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: setup: reading VDSM supported cluster levels from
file
..
Patch Set 2: Code-Review+1
Build Successful
http://jenkins.ovirt.org/job/ovirt-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: setup: reading VDSM supported cluster levels from
file
..
Patch Set 1: Code-Review+1
Build Successful
http://jenkins.ovirt.org/job/ovirt-
automat...@ovirt.org has posted comments on this change.
Change subject: cli: Support show by alias
..
Patch Set 1:
* Update tracker::#1091725::OK
--
To view, visit http://gerrit.ovirt.org/32144
To unsubscribe, visit http://g
Daniel Erez has posted comments on this change.
Change subject: webadmin: null safe StorageDomainFreeSpaceRenderer
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32104
To unsubscribe, visit http://gerrit.
Daniel Erez has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32143
To unsubscribe, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_c
Juan Hernandez has posted comments on this change.
Change subject: cli: Support show by alias
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32144
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Oved Ourfali has posted comments on this change.
Change subject: restapi:Fix CRUD operations for iSCSI Storage connection.
..
Patch Set 1:
Please remove the verification until the Gerrit hooks pass. Thanks.
--
To view, visit
Juan Hernandez has uploaded a new change for review.
Change subject: cli: Support show by alias
..
cli: Support show by alias
Some collections, in particular the disks collection, don't support
retrieving elements by name, but b
automat...@ovirt.org has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 2:
* Update tracker::#1134382::OK
* Update tracker::#1134434::OK
* Check Bug-Url::O
Daniel Erez has uploaded a new change for review.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
RemoveDiskSnapshotTaskHandler ->
* endWithF
automat...@ovirt.org has posted comments on this change.
Change subject: core: RemoveDiskSnapshot rollback - fetch disk by DiskDao
..
Patch Set 1:
* Update tracker::#1134382::OK
* Update tracker::#1134434::OK
* Check Bug-Url::O
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: Updating default storage type question
..
Patch Set 6: Verified+1
Verified
--
To view, visit http://gerrit.ovirt.org/31965
To unsubscribe
Simone Tiraboschi has posted comments on this change.
Change subject: packaging: setup: reading VDSM supported cluster levels from
file
..
Patch Set 2: Verified+1
Verified on a clean f19 setup when vdsm is still not ready.
--
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: setup: reading VDSM supported cluster levels from
file
..
Patch Set 2:
* Update tracker::#1100236::OK
* Check Bug-Url::OK
* Check Public Bug::
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: setup: reading VDSM supported cluster levels from
file
..
Patch Set 1:
* Update tracker::#1100236::OK
* Check Bug-Url::OK
* Check Public Bug::
Simone Tiraboschi has uploaded a new change for review.
Change subject: packaging: setup: reading VDSM supported cluster levels from
file
..
packaging: setup: reading VDSM supported cluster levels from file
VDSM can still be no
automat...@ovirt.org has posted comments on this change.
Change subject: core: soundcard not persisted on new instance type
..
Patch Set 1:
* Update tracker::#1124270::OK
* Check TR::#1124270::OK
* Set MODIFIED::bug 1124270
Tal Nisan has submitted this change and it was merged.
Change subject: core: soundcard not persisted on new instance type
..
core: soundcard not persisted on new instance type
The problem was that the sondcard was persisted onl
automat...@ovirt.org has posted comments on this change.
Change subject: Monitor should not crash when unexpected exception happens
..
Patch Set 3:
* Update tracker::#1124595::OK
--
To view, visit http://gerrit.ovirt.org/3203
Adam Litke has submitted this change and it was merged.
Change subject: Monitor should not crash when unexpected exception happens
..
Monitor should not crash when unexpected exception happens
The monitor thread should report t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: set QoS href under profile
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32047/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: support for adding network QoS
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/3
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: support for adding network QoS
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/904/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: use instance type values on update vm
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: set QoS href under profile
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle_gerrit/902/ :
S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: use instance type values on update vm
..
Patch Set 2: Code-Review-1 Verified-1
Build Unstable
http://jenkins.ovirt.org/job/ovirt_engine_master_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: support for adding network qos for rest-api
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.5_compile_checkstyle
Arik Hadas has posted comments on this change.
Change subject: core: Use correct validation for SD selection
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31488/10/backend/manager/modules/bll/src/main/java/org/ovirt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: update vms on update of instance type
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerr
Arik Hadas has posted comments on this change.
Change subject: core: Use correct validation for SD selection
..
Patch Set 10:
(2 comments)
http://gerrit.ovirt.org/#/c/31488/10/backend/manager/modules/bll/src/main/java/org/ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: update vms on update of instance type
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_master_co
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove un-needed null check
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32045/
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: centos: fixed answer file
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32141
To unsubscribe, visit http://gerrit.ov
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: centos: fixed otopi stages order
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32140
To unsubscribe, visit http://ge
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: setup: centos: fixed answer file
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/32141
T
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: centos: fixed changes after engine split
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32139
To unsubscribe, visit h
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: setup: centos: fixed otopi stages order
..
packaging: setup: centos: fixed otopi stages order
Fixed otopi loop:
error: method
otopi.plugins.ovirt_
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: setup: centos: fixed changes after engine split
..
packaging: setup: centos: fixed changes after engine split
fixed references to constants moved
Vojtech Szocs has posted comments on this change.
Change subject: frontend: Upgrade GWT to version 2.6.1
..
Patch Set 1:
(4 comments)
No score yet, we're discussing this on devel mailing list.
Just a few small comments, looks
Sandro Bonazzola has uploaded a new change for review.
Change subject: packaging: setup: centos: fixed answer file
..
packaging: setup: centos: fixed answer file
Fixed answer file avoiding question about:
Configure Engine on thi
automat...@ovirt.org has posted comments on this change.
Change subject: engine: set QoS href under profile
..
Patch Set 3: Verified-1
* Update tracker::#1078863::OK
* Check Bug-Url::OK
* Check Public Bug::#1078863::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: setup: centos: fixed changes after engine split
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ov
automat...@ovirt.org has posted comments on this change.
Change subject: packaging: setup: centos: fixed otopi stages order
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: support for adding network QoS
..
Patch Set 6: Verified-1
* Update tracker::#1078863::OK
* Check Bug-Url::OK
* Check Public Bug::#1078863::OK, pu
automat...@ovirt.org has posted comments on this change.
Change subject: engine: support for adding network qos for rest-api
..
Patch Set 6: Verified-1
* Update tracker::#1078863::OK
* Check Bug-Url::OK
* Check Public Bug::#107
Gilad Chaplik has posted comments on this change.
Change subject: restapi: support for adding network QoS
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/31869
To unsubscribe, visit http://gerrit.ovirt.org
Gilad Chaplik has posted comments on this change.
Change subject: engine: set QoS href under profile
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/31929
To unsubscribe, visit http://gerrit.ovirt.org/sett
Gilad Chaplik has posted comments on this change.
Change subject: engine: support for adding network qos for rest-api
..
Patch Set 6: Verified+1
thanks Lior & Arik! I really appreciate it :)
--
To view, visit http://gerrit.ov
Omer Frenkel has posted comments on this change.
Change subject: core: update vms on update of instance type
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/31300
To unsubscribe, visit http://gerrit.ovirt.
Omer Frenkel has posted comments on this change.
Change subject: core: use instance type values on update vm
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/31299
To unsubscribe, visit http://gerrit.ovirt.
automat...@ovirt.org has posted comments on this change.
Change subject: core: use instance type values on update vm
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: core: update vms on update of instance type
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: support for adding network QoS
..
Patch Set 7:
* Update tracker::#1078863::OK
* Check Bug-Url::OK
* Check Public Bug::#1078863::OK, public bug
*
Omer Frenkel has posted comments on this change.
Change subject: core: use instance type values on update vm
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/31299/1/backend/manager/modules/bll/src/main/java/org/ovirt/e
automat...@ovirt.org has posted comments on this change.
Change subject: engine: set QoS href under profile
..
Patch Set 6:
* Update tracker::#1078863::OK
* Check Bug-Url::OK
* Check Public Bug::#1078863::OK, public bug
* Check
1 - 100 of 432 matches
Mail list logo
