Arik Hadas has posted comments on this change. Change subject: core: Use correct validation for SD selection ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/31488/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 72: private Guid cachedStorageDomainId = Guid.Empty; Line 73: private String cachedSnapshotIsBeingTakenMessage; Line 74: private Guid newActiveSnapshotId = Guid.newGuid(); Line 75: private MemoryImageBuilder memoryBuilder; Line 76: private Guid memorySdId; why do we need to have this field while we have cachedStorageDomainId ? Line 77: Line 78: /** The size for the snapshot's meta data which is vm related properties at the Line 79: * time the snapshot was taken */ Line 80: private static final long META_DATA_SIZE_IN_BYTES = 10 * 1024; Line 76: private Guid memorySdId; Line 77: Line 78: /** The size for the snapshot's meta data which is vm related properties at the Line 79: * time the snapshot was taken */ Line 80: private static final long META_DATA_SIZE_IN_BYTES = 10 * 1024; now we store that value in the hibernate command and here - can we move it to MemoryUtils (or other suitable place) so we'll have it in one place? Line 81: Line 82: protected CreateAllSnapshotsFromVmCommand(Guid commandId) { Line 83: super(commandId); Line 84: } -- To view, visit http://gerrit.ovirt.org/31488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac901a638358b9b08bcc6992d783a42cbfcd9bfa Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
