Vojtech Szocs has posted comments on this change. Change subject: frontend: Upgrade GWT to version 2.6.1 ......................................................................
Patch Set 1: (4 comments) No score yet, we're discussing this on devel mailing list. Just a few small comments, looks great otherwise. http://gerrit.ovirt.org/#/c/32135/1/backend/manager/modules/common/pom.xml File backend/manager/modules/common/pom.xml: Line 11: <packaging>jar</packaging> Line 12: Line 13: <name>Common Code</name> Line 14: Line 15: <properties> If <properties> is now empty, why not simply remove it as well? Line 16: </properties> Line 17: Line 18: <dependencies> Line 19: <dependency> http://gerrit.ovirt.org/#/c/32135/1/backend/manager/modules/compat/pom.xml File backend/manager/modules/compat/pom.xml: Line 9: Line 10: <artifactId>compat</artifactId> Line 11: <packaging>jar</packaging> Line 12: Line 13: <properties> If <properties> is now empty, why not simply remove it as well? Line 14: </properties> Line 15: Line 16: <name>CSharp Compatibility</name> Line 17: http://gerrit.ovirt.org/#/c/32135/1/backend/manager/modules/searchbackend/pom.xml File backend/manager/modules/searchbackend/pom.xml: Line 11: <packaging>jar</packaging> Line 12: Line 13: <name>Search Backend</name> Line 14: Line 15: <properties> If <properties> is now empty, why not simply remove it as well? Line 16: </properties> Line 17: Line 18: <dependencies> Line 19: <dependency> http://gerrit.ovirt.org/#/c/32135/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java: Line 17: */ Line 18: public abstract class BaseUiCommonModule extends AbstractGinModule { Line 19: Line 20: protected void bindCommonIntegration() { Line 21: install(new CommonGinModule()); I assume this is necessary due to "New mandatory GIN bindings" as documented at: https://github.com/ArcBees/GWTP/wiki/Migrating-from-1.1-to-1.2 Since this is GWTP-infra binding code, please move above line into BaseSystemModule.bindCommonInfrastructure() method. Line 22: Line 23: bind(ITypeResolver.class).to(UiCommonDefaultTypeResolver.class).in(Singleton.class); Line 24: bind(FrontendEventsHandlerImpl.class).in(Singleton.class); Line 25: bind(FrontendFailureEventListener.class).in(Singleton.class); -- To view, visit http://gerrit.ovirt.org/32135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76c29897960e2b61ead8176f896e45f9d7b9b576 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
