Vojtech Szocs has uploaded a new change for review.

Change subject: webadmin,userportal: Fix Maven build-time warnings
......................................................................

webadmin,userportal: Fix Maven build-time warnings

1. gwt-extension POM now uses ${project.version} instead
   of ${version} within the <finalName> declaration

2. frontend POM no longer duplicates plugin declaration
   for build-helper-maven-plugin -- both <execution>s
   are now placed under single plugin declaration

Change-Id: Id541ba5b01769dc5e8cab16f8260ea20b95e7270
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
2 files changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/32145/1

diff --git a/frontend/webadmin/modules/frontend/pom.xml 
b/frontend/webadmin/modules/frontend/pom.xml
index 9e143b7..f6778d8 100644
--- a/frontend/webadmin/modules/frontend/pom.xml
+++ b/frontend/webadmin/modules/frontend/pom.xml
@@ -161,12 +161,6 @@
               </sources>
             </configuration>
           </execution>
-        </executions>
-      </plugin>
-      <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>build-helper-maven-plugin</artifactId>
-        <executions>
           <execution>
             <id>add-apt-sources</id>
             <phase>generate-sources</phase>
diff --git a/frontend/webadmin/modules/gwt-extension/pom.xml 
b/frontend/webadmin/modules/gwt-extension/pom.xml
index 6a77c89..3ecc810 100644
--- a/frontend/webadmin/modules/gwt-extension/pom.xml
+++ b/frontend/webadmin/modules/gwt-extension/pom.xml
@@ -47,8 +47,8 @@
     </dependency>
   </dependencies>
   <build>
-    <!-- overrides default value {artifactId}-${version} -->
-    <finalName>ovirt-engine-gwt-extension-${version}</finalName>
+    <!-- Overrides default value ${project.artifactId}-${project.version} -->
+    <finalName>ovirt-engine-gwt-extension-${project.version}</finalName>
     <plugins>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>


-- 
To view, visit http://gerrit.ovirt.org/32145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id541ba5b01769dc5e8cab16f8260ea20b95e7270
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to