Gilad Chaplik has posted comments on this change.
Change subject: core: add GetDiskProfilesByStorageQosIdQuery
..
Patch Set 2:
(1 comment)
will add dao test.
new patch soon to follow
http://gerrit.ovirt.org/#/c/29529/2/backe
Liron Aravot has posted comments on this change.
Change subject: core: add GetDiskProfilesByStorageQosIdQuery
..
Patch Set 2: Code-Review-1
(1 comment)
minor issue, marking -1 for visibillity.
what about dao test?
http://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: ui: line chart progress bar
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: binding file groups and product options
..
Patch Set 12: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29206
To unsubscribe, visi
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 5:
you should move the getName() to the previous patch.
--
To view, visit http://gerrit.ovirt.org/29
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: fixing hostname validation
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29512
To unsubscribe, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add repo for PatternFly
..
Patch Set 1:
why not have this within the designated downstream repo? this way updates and
such will automatically be pulle
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: add repo for PatternFly
..
Patch Set 1:
Do we need an external repo? can't we ship the rpm within ovirt repo?
--
To view, visit http://gerrit.ovi
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: add repo for PatternFly
..
Patch Set 1:
You will also need to create an f20 deps repo file.
--
To view, visit http://gerrit.ovirt.org/29528
To un
Sandro Bonazzola has posted comments on this change.
Change subject: userportal, webadmin: remove PatternFly from source tree
..
Patch Set 8:
> Alon, the RPM is ready. Can we merge this, or must we wait for Sandro?
Greg: if pa
Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: remove PatternFly from source tree
..
Patch Set 8: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/29018/8/packaging/branding/ovirt.br
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove redundant synchronization (CoCo cleanup)
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin : Create Geo-rep pop up
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: Interface name is not set via cloud-init api
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.4_create-rpms_merged/488/
anmolbabu has uploaded a new change for review.
Change subject: webadmin : Create Geo-rep pop up
..
webadmin : Create Geo-rep pop up
Create Geo-rep pop up
Change-Id: Ied7317d456bf66db9a7800ba7106f2e8ec66429c
Signed-off-by: Anmo
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin : Create Geo-rep pop up
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Oved Ourfali has posted comments on this change.
Change subject: engine : Command Executor should persist command before
submitting to threadpool
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29219/4/backend/manager
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Disconnecting from vdsm for maintanace
..
Patch Set 2:
And why is it relevant only for STOMP?
--
To view, visit http://gerrit.ovirt.org/29651
To unsubs
Oved Ourfali has posted comments on this change.
Change subject: engine : Update CoCo to use CommandContext
..
Patch Set 7: Code-Review+1
Same like Yair.
--
To view, visit http://gerrit.ovirt.org/29477
To unsubscribe, visit h
Oved Ourfali has posted comments on this change.
Change subject: engine, webadmin: Inconsistent maintenance mode handling via
host-deploy
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29678
To unsubs
Oved Ourfali has posted comments on this change.
Change subject: engine : Save CommandContext in ContextCache
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/29501/7/backend/manager/modules/bll/src/main/java/org/ovirt/
Oved Ourfali has posted comments on this change.
Change subject: core: remove redundant synchronization (CoCo cleanup)
..
Patch Set 4: Code-Review+2
Based on previous ACKs
--
To view, visit http://gerrit.ovirt.org/29522
To un
automat...@ovirt.org has posted comments on this change.
Change subject: core: remove redundant synchronization (CoCo cleanup)
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Oved Ourfali has submitted this change and it was merged.
Change subject: core: remove redundant synchronization (CoCo cleanup)
..
core: remove redundant synchronization (CoCo cleanup)
a method which is executed by our quartz i
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ui: improve hot plug cpu phrasing
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.4_create-rpms_merged/487/ : SUCCESS
http:
Greg Sheremeta has posted comments on this change.
Change subject: userportal, webadmin: remove PatternFly from source tree
..
Patch Set 8:
Alon, the RPM is ready. Can we merge this, or must we wait for Sandro?
--
To view, vi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11825/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Clean AuthzUtils from non aaa code
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_find-b
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
oVirt Jenkins CI Server has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/118
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Clean AuthzUtils from non aaa code
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Yair Zaslavsky has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/29665/3/backend/manager/modules/aaa/src/main/java/org/o
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Generate CommandContext on engine restart
..
Patch Set 2:
Ravi, some new thoughts here -
Please let me know what you think -
I have discussed with Moti
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Save CommandContext in ContextCache
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29501
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Update CoCo to use CommandContext
..
Patch Set 7: Code-Review+1
I am ok with the code, I agree with Federico's comment.
--
To view, visit http://gerr
Federico Simoncelli has posted comments on this change.
Change subject: engine : Update CoCo to use CommandContext
..
Patch Set 7: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/29477/7//COMMIT_MSG
Commit Message:
Line
Ilia Meerovich has posted comments on this change.
Change subject: sdk: Indicate that sessionTimeout is in minutes
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29636
To unsubscribe, visit http://gerr
Ilia Meerovich has posted comments on this change.
Change subject: cli: Indicate that session-timeout is in minutes
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29638
To unsubscribe, visit http://ger
Ilia Meerovich has posted comments on this change.
Change subject: sdk: Indicate that sessionTimeout is in minutes
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29636
To unsubscribe, visit http://gerr
Ilia Meerovich has posted comments on this change.
Change subject: sdk: Indicate that sessionTimeout is in minutes
..
Patch Set 1: -Code-Review
in http://gerrit.ovirt.org/#/c/29635/1/src/codegen/templates/entrypointtemplate
you
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 3:
this should be squashed with the usage (sync), no reason to have this as its own
--
To view, visi
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/29665/3/backend/manager/modules/aaa/src/main/java/org/ovi
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Clean AuthzUtils from non aaa code
..
Patch Set 2: Code-Review+1
Nice one!
--
To view, visit http://gerrit.ovirt.org/29664
To unsubscribe, visit http://ger
Simone Tiraboschi has posted comments on this change.
Change subject: sdk: Ignore errors when cleaning old connection
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/29684/2/src/codegen/templates/entrypointtemplate
Fil
oVirt Jenkins CI Server has posted comments on this change.
Change subject: userportal, webadmin: fix popup dialog header text spacing
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bug
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Fixing recursive for kerberos ldap authz
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29642
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has posted comments on this change.
Change subject: extapi: Add Capabilities to Authz
..
Patch Set 2: Code-Review+1
you could have squashed it into actual use case, but not that important.
--
To view, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Adding addToMapOfSets to MultiValueMapUtils
..
Patch Set 1: Code-Review+1
(1 comment)
Most probably we need to move this into uutils
http://gerrit.ovirt.or
Juan Hernandez has posted comments on this change.
Change subject: sdk: Ignore errors when cleaning old connection
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/29684
To unsubscribe, visit http://gerrit.
automat...@ovirt.org has posted comments on this change.
Change subject: sdk: Ignore errors when cleaning old connection
..
Patch Set 2:
* Update tracker::#1116009::OK
--
To view, visit http://gerrit.ovirt.org/29684
To unsubs
Juan Hernandez has uploaded a new change for review.
Change subject: sdk: Ignore errors when cleaning old connection
..
sdk: Ignore errors when cleaning old connection
The constructor of the API object tries to clean connections
automat...@ovirt.org has posted comments on this change.
Change subject: sdk: Ignore errors when cleaning old connection
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/296
Itamar Heim has posted comments on this change.
Change subject: core, engine: Avoid migration in ppc64
..
Patch Set 17:
isn't live migration supported with kvm on power8?
--
To view, visit http://gerrit.ovirt.org/21522
To uns
Ravi Nori has posted comments on this change.
Change subject: core: remove redundant synchronization (CoCo cleanup)
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29522
To unsubscribe, visit http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Enable RESTAPI CSRF protection
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11820/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine : Generate CommandContext on engine restart
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit
Greg Sheremeta has posted comments on this change.
Change subject: userportal, webadmin: fix popup dialog header text spacing
..
Patch Set 1:
(btw, spacing is off in Firefox but perfect in Chrome, if you want to try it)
--
To
Greg Sheremeta has posted comments on this change.
Change subject: userportal, webadmin: fix popup dialog header text spacing
..
Patch Set 1:
@ Einav and Alex,
This patch changes the dialog header logo and title spacing method
Greg Sheremeta has uploaded a new change for review.
Change subject: userportal, webadmin: fix popup dialog header text spacing
..
userportal, webadmin: fix popup dialog header text spacing
Changed popup dialog header text to be
automat...@ovirt.org has posted comments on this change.
Change subject: userportal, webadmin: fix popup dialog header text spacing
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: CSRF protection filter
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3127/
:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Parse Prefer according to RFC 7240
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11819/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine : Save CommandContext in ContextCache
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11818
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine : Update CoCo to use CommandContext
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/11816/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine, webadmin: Inconsistent maintenance mode handling via
host-deploy
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_
Juan Hernandez has posted comments on this change.
Change subject: webadmin: Enable RESTAPI CSRF protection
..
Patch Set 1:
Keith, Spenser, I'm adding you so that you are aware that this will be
potentially enabled by users. O
Juan Hernandez has posted comments on this change.
Change subject: webadmin: Enable RESTAPI CSRF protection
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29682
To unsubscribe, visit http://gerrit.ovirt.o
Juan Hernandez has posted comments on this change.
Change subject: restapi: CSRF protection filter
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29681
To unsubscribe, visit http://gerrit.ovirt.org/settin
Juan Hernandez has posted comments on this change.
Change subject: core: Parse Prefer according to RFC 7240
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29680
To unsubscribe, visit http://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Enable RESTAPI CSRF protection
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Juan Hernandez has uploaded a new change for review.
Change subject: restapi: CSRF protection filter
..
restapi: CSRF protection filter
This patch introduces a filter that protects the RESTAPI from CSRF
attacks. Protection is en
automat...@ovirt.org has posted comments on this change.
Change subject: restapi: CSRF protection filter
..
Patch Set 1:
* Update tracker::#1077441::OK
* Check Bug-Url::OK
* Check Public Bug::#1077441::OK, public bug
* Check Pr
Juan Hernandez has uploaded a new change for review.
Change subject: core: Parse Prefer according to RFC 7240
..
core: Parse Prefer according to RFC 7240
Currently we assume that the "Prefer" header contains only the value
"pers
automat...@ovirt.org has posted comments on this change.
Change subject: core: Parse Prefer according to RFC 7240
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Juan Hernandez has uploaded a new change for review.
Change subject: webadmin: Enable RESTAPI CSRF protection
..
webadmin: Enable RESTAPI CSRF protection
This patch changes the webadmin application so that it will always
request
Ravi Nori has posted comments on this change.
Change subject: engine : Generate CommandContext on engine restart
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/29565
To unsubscribe, visit http://gerrit.ov
Ravi Nori has posted comments on this change.
Change subject: engine : Save CommandContext in ContextCache
..
Patch Set 7: Verified+1
@Yair
removed getCommandContext method
saveCommandContext is used by CommandExecutor so it
automat...@ovirt.org has posted comments on this change.
Change subject: engine : Save CommandContext in ContextCache
..
Patch Set 7:
* Update tracker::#1115127::OK
* Check Bug-Url::OK
* Check Public Bug::#1115127::OK, public b
Ravi Nori has posted comments on this change.
Change subject: engine : Update CoCo to use CommandContext
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/29477
To unsubscribe, visit http://gerrit.ovirt.org/
automat...@ovirt.org has posted comments on this change.
Change subject: engine : Update CoCo to use CommandContext
..
Patch Set 7:
* Update tracker::#1115127::OK
* Check Bug-Url::OK
* Check Public Bug::#1115127::OK, public bug
automat...@ovirt.org has posted comments on this change.
Change subject: engine : Generate CommandContext on engine restart
..
Patch Set 2:
* Update tracker::#1115127::OK
* Check Bug-Url::OK
* Check Public Bug::#1115127::OK, pu
Ravi Nori has posted comments on this change.
Change subject: engine, webadmin: Inconsistent maintenance mode handling via
host-deploy
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29678
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: engine, webadmin: Inconsistent maintenance mode handling via
host-deploy
..
Patch Set 1:
* Update tracker::#1087524::OK
* Check Bug-Url::OK
* Check Publi
Ravi Nori has uploaded a new change for review.
Change subject: engine, webadmin: Inconsistent maintenance mode handling via
host-deploy
..
engine, webadmin: Inconsistent maintenance mode handling via host-deploy
When the host
Arik Hadas has posted comments on this change.
Change subject: engine : Command Executor should persist command before
submitting to threadpool
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29219/4/backend/manager/m
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Disconnecting from vdsm for maintanace
..
Patch Set 2: Verified+1
AddVds and removeVds make sure that none of the commands will try to connect. I
pl
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: Missing hostId parameter on reconstructMaster
..
Patch Set 1:
I will rebase.
--
To view, visit http://gerrit.ovirt.org/29511
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ui: Fixing hostPopupView tab indexes
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/8253/ :
SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Warning instead of error if kdump not configured
..
Patch Set 2:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_mer
Ravi Nori has posted comments on this change.
Change subject: engine : Save CommandContext in ContextCache
..
Patch Set 5:
(2 comments)
replied
http://gerrit.ovirt.org/#/c/29501/5/backend/manager/modules/bll/src/main/java/or
Project:
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/
Build:
http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/7920/
Build Number: 7920
Build Status: Fixed
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/29626
-
Project:
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/label=fedora20/
Build:
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/label=fedora20/3305/
Build Number: 3305
Build Status: Fixed
Triggered By: Started by upstream project
"ovirt-engi
Project:
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/
Build:
http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/3305/
Build Number: 3305
Build Status: Fixed
Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/29663
---
Oved Ourfali has posted comments on this change.
Change subject: engine : Command Executor should persist command before
submitting to threadpool
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/29219/4/backend/manage
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Missing hostId parameter on reconstructMaster
..
Patch Set 1:
Piotr, why does this patch depend on the compatibility version one?
I guess we can wait wit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: add usages field to "add network to data-center"
action params
..
Patch Set 3:
Build Unstable
http://jenkins.ovirt.org/job/ovirt-engine_mas
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Disconnecting from vdsm for maintanace
..
Patch Set 2: Code-Review-1
isn't there another way to accomplish that?
sounds weird that we need to call addVds
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: remove display field from add network to data-center
action parameters
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/ovirt-engi
automat...@ovirt.org has posted comments on this change.
Change subject: ui: Fixing hostPopupView tab indexes
..
Patch Set 3:
* Update tracker::#1115045::OK
* Check TR::#1115045::OK
* Set MODIFIED::bug 1115045#1115045OK
1 - 100 of 702 matches
Mail list logo
