Federico Simoncelli has posted comments on this change. Change subject: engine : Update CoCo to use CommandContext ......................................................................
Patch Set 7: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29477/7//COMMIT_MSG Commit Message: Line 6: Line 7: engine : Update CoCo to use CommandContext Line 8: Line 9: CommandCoordinator has been updated to find Line 10: Commands with CommandContext constructor. It may be worth to mention why RemoveSnapshot is a special case (I know it is probably obvious but it would speed up my review). Also, could it make sense to split the RemoveSnapshot changes in another patch if they're not fully related to the CommandExecutor change? Line 11: Line 12: Change-Id: Id914da3ed1a29e651ad2491fc88a2705b7af6e8f Line 13: Bug-Url: https://bugzilla.redhat.com/1115127 -- To view, visit http://gerrit.ovirt.org/29477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id914da3ed1a29e651ad2491fc88a2705b7af6e8f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
