Yair Zaslavsky has posted comments on this change.

Change subject: aaa: Introduce fetchPrincipalsByIdsRecursively
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.ovirt.org/#/c/29665/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java
File 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java:

Line 37:             ret = output.<ExtMap> 
get(Authz.InvokeKeys.PRINCIPAL_RECORD);
Line 38:         }
Line 39:         return ret;
Line 40:     }
Line 41:     
> -
Done
Line 42:     public static List<ExtMap> fetchPrincipalsByIdsRecursively(
Line 43:             final ExtensionProxy extension,
Line 44:             final String namespace,
Line 45:             final List<String> ids) {


http://gerrit.ovirt.org/#/c/29665/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java:

Line 129
Line 130
Line 131
Line 132
Line 133
> you can really just pass the extension name, no?
Done


Line 155
Line 156
Line 157
Line 158
Line 159
> you can really just pass the extension name, no?
Done


-- 
To view, visit http://gerrit.ovirt.org/29665
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05a81883e9f2f146e7f3e580a7d0159d87ff1cbe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to