Yair Zaslavsky has posted comments on this change.

Change subject: engine : Generate CommandContext on engine restart
......................................................................


Patch Set 2:

Ravi, some new thoughts here -
Please let me know what you think -
I have discussed with Moti about ExecutionContext -
the fact that job (in db) does not have a command_id is wrong - at the past 
when Moti worked on the framework, there was a thought that jobs might not 
necessarily be spawned due to commands, but de-facto - this does not occur, and 
they are always associated with commands. If we add command_id to job (and 
maybe even step for child commands) we may reconstruct EexecutionContext upon 
restat.
What we need to think is what are the benefits of having this ability?

-- 
To view, visit http://gerrit.ovirt.org/29565
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I641802c6e0e05abaa2ecd84d0718f0d95ab59d9e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to