[Engine-patches] Change in ovirt-node-plugin-vdsm[master]: spec: start/enable glusterd

2014-03-28 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: spec: start/enable glusterd .. Patch Set 1: Failure not related to the patch cp plugin-vdsm/.git/HEAD scm_hash.txt + cp plugin-vdsm/.git/HEAD scm_

[Engine-patches] Change in ovirt-node-plugin-vdsm[master]: spec: start/enable glusterd

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: start/enable glusterd .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/ovirt-node-plugin-vdsm/144/ : FAILURE -- To view, visit http:

[Engine-patches] Change in ovirt-node-plugin-vdsm[master]: spec: start/enable glusterd

2014-03-28 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: spec: start/enable glusterd .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/26203 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-node-plugin-vdsm[master]: spec: start/enable glusterd

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: spec: start/enable glusterd .. Patch Set 1: * #1073531::Update tracker: OK -- To view, visit http://gerrit.ovirt.org/26203 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-node-plugin-vdsm[master]: spec: start/enable glusterd

2014-03-28 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: spec: start/enable glusterd .. spec: start/enable glusterd This patch will enable/disable glusterd service after install/remove of ovirt-node-plugi

[Engine-patches] Change in samples-uiplugins[master]: AngularJS Demo Plugin

2014-03-28 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: AngularJS Demo Plugin .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/26129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Me

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: Juan, Alon - 2 more comments - 1. I was sure that the format we would like to have

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: Thanks for all the comments. Alon, Your last assumption is incorrect IMHO. When I u

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26090/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26090/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 3: * #1026723::Update tracker: ERROR, wrong product Red Hat Enterprise Virtualization Manager * Bug-Url

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/26090/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engin

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26090/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests_master_gerrit - Build # 1467 - Failure!

2014-03-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_gerrit/ Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_gerrit/1467/ Build Number: 1467 Build Status: Failure Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26200 ---

[Engine-patches] Change in ovirt-engine[master]: core: Add DaoProviderInterface and implement it in DbFacade

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add DaoProviderInterface and implement it in DbFacade .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests_master_gerrit - Build # 1468 - Fixed!

2014-03-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_gerrit/ Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_gerrit/1468/ Build Number: 1468 Build Status: Fixed Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26199 -

[Engine-patches] Change in ovirt-engine[master]: engine: Decouple PolicyUnits from DbFacade using the new int...

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Decouple PolicyUnits from DbFacade using the new interface .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/jo

[Engine-patches] Change in ovirt-engine[master]: core: Add DaoProviderInterface and implement it in DbFacade

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add DaoProviderInterface and implement it in DbFacade .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests

[Engine-patches] Change in ovirt-engine[master]: engine: Decouple PolicyUnits from DbFacade using the new int...

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Decouple PolicyUnits from DbFacade using the new interface .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/jo

[Engine-patches] Change in ovirt-engine[master]: engine: Decouple PolicyUnits from DbFacade using the new int...

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Decouple PolicyUnits from DbFacade using the new interface .. Patch Set 2: * update_tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovi

[Engine-patches] Change in ovirt-engine[master]: core: Add DaoProviderInterface and implement it in DbFacade

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Add DaoProviderInterface and implement it in DbFacade .. Patch Set 2: * update_tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt-engin

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: first, as I commented the format yair put is incorrect it should be: id= or: pro

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/26090/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all

[Engine-patches] Change in ovirt-engine[master]: engine: Decouple PolicyUnits from DbFacade using the new int...

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Decouple PolicyUnits from DbFacade using the new interface .. Patch Set 1: * update_tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovi

[Engine-patches] Change in ovirt-engine[master]: core: Add DaoProviderInterface and implement it in DbFacade

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: Add DaoProviderInterface and implement it in DbFacade .. Patch Set 1: * update_tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt-engin

[Engine-patches] Change in ovirt-engine[master]: core: Add DaoProviderInterface and implement it in DbFacade

2014-03-28 Thread msivak
Martin Sivák has uploaded a new change for review. Change subject: core: Add DaoProviderInterface and implement it in DbFacade .. core: Add DaoProviderInterface and implement it in DbFacade This will allow decoupling of some int

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 2: * #1026723::Update tracker: ERROR, wrong product Red Hat Enterprise Virtualization Manager * Bug-Url

[Engine-patches] Change in ovirt-engine[master]: Avoiding legacy health servlet usage

2014-03-28 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: Avoiding legacy health servlet usage .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/26090/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engin

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: Lets assume this: internal_id=4d42ec8d-7eca-47da-9a54-9f48fc896072 provider_id

[Engine-patches] Change in ovirt-engine[master]: core: Fix AuditLog check for existing log entries

2014-03-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: Fix AuditLog check for existing log entries .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26028/5/backend/manager/modules/dal/src/main/java/org/

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Persist advanced/basic mode per dialog ...

2014-03-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: Persist advanced/basic mode per dialog type .. Patch Set 1: (1 comment) A couple of notes: # It seems that sometimes the storage key come

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: class cast exception in AdElementListModel .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26190 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Check that balance function choose source host with at...

2014-03-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: Check that balance function choose source host with at least one vm .. Patch Set 2: Code-Review+2 will merge next week, 10x -- To view, visit http://ger

[Engine-patches] INFRA ISSUE: [oVirt Jenkins] ovirt-engine_upgrade_stable_to_3.4_merge - Build # 47 - Still Failing!

2014-03-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_upgrade_stable_to_3.4_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_upgrade_stable_to_3.4_merge/47/ Build Number: 47 Build Status: Still Failing Triggered By: Retriggered by user dcaro for Gerrit: http://gerrit.ovirt.org/25808 in silen

[Engine-patches] Change in ovirt-engine[master]: engine: Numa feature entities

2014-03-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: Numa feature entities .. Patch Set 12: Please reply to comments in the body of the patch. -- To view, visit http://gerrit.ovirt.org/23702 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: engine: Numa feature entities

2014-03-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: Numa feature entities .. Patch Set 12: (29 comments) good start. http://gerrit.ovirt.org/#/c/23702/12/backend/manager/modules/common/src/main/java/org/

[Engine-patches] Change in ovirt-image-uploader[master]: Clean the code to pass pep8 checks

2014-03-28 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: Clean the code to pass pep8 checks .. Patch Set 3: Code-Review+1 Please verify -- To view, visit http://gerrit.ovirt.org/26176 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: > but as it is possible to do x == y there is no reason to confuse the API > consume

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: of course for newer clients we should expose the provider name and id within provide

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: With this schema for identifiers the API consumer can't find the relationship betw

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: It was my understanding that removing the external_id element from users was done

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: as far as I understand caller should not invent his own ids, but use the ids returne

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/26191/3//COMMIT_MSG Commit Message: Line 1

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerri

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 1: * #1031778::Update tracker: OK * #1031778::Bug-Url: Correct product oVirt * #1031778

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread mperina
Martin Peřina has uploaded a new change for review. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. tools: Add --resolve-kdc arg to engine-manage-domains Adds --resolve-kdc argument to engine-mamage-doma

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread mperina
Martin Peřina has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/26193 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_test

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_test

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_test

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monito

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Bug-Url: IGNORE, not in a monito

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities...

2014-03-28 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: aaa: Introducing format to id of User and Group API entities The following format will be used to represent the value of id in User and Group API entities: ..

[Engine-patches] Change in ovirt-engine[master]: aaa: Introducing format to id of User and Group API entities...

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities The following format will be used to represent the value of id in User and Group API entities: ...

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: warn when exporting template version if base is mi...

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: warn when exporting template version if base is missing .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26072 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: frontend: Support for Vm boot menu

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: frontend: Support for Vm boot menu .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/26175/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovir

[Engine-patches] Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_ge

[Engine-patches] Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 3: * #1031778::Update tracker: OK * #1031778::Target Release: OK * #1031778::Set MODIFI

[Engine-patches] Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. tools: Add --resolve-kdc arg to engine-manage-domains Adds --resolve-kdc argument to engine-ma

[Engine-patches] Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24576 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread mperina
Martin Peřina has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24576 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 3: * #1031778::Update tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt-e

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: frontend: Adjust console tooltips

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: frontend: Adjust console tooltips .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25265 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Sysprep - Add user specify Active Directory OU

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: Sysprep - Add user specify Active Directory OU .. Patch Set 2: Code-Review+1 FE is OK -- To view, visit http://gerrit.ovirt.org/26086 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Enable log-in for a regular user via cloud-init

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: Enable log-in for a regular user via cloud-init .. Patch Set 5: (2 comments) +1 for FE http://gerrit.ovirt.org/#/c/26011/5//COMMIT_MSG Commit Message: L

[Engine-patches] Change in ovirt-engine[master]: tools: Add --resolve-kdc arg to engine-manage-domains

2014-03-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Add --resolve-kdc arg to engine-manage-domains .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24576 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: RFE: set locale language and keyboard via Sysprep

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: engine: RFE: set locale language and keyboard via Sysprep .. Patch Set 10: Code-Review+1 FE still ok -- To view, visit http://gerrit.ovirt.org/25488 To unsubsc

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: restapi: Return error in replace-brick

2014-03-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: restapi: Return error in replace-brick .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26189 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-image-uploader[master]: Clean the code to pass pep8 checks

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Clean the code to pass pep8 checks .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/26176 To unsubsc

[Engine-patches] Change in ovirt-image-uploader[master]: Clean the code to pass pep8 checks

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: Clean the code to pass pep8 checks .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit http://gerrit.ovirt.org/26176 To unsubsc

[Engine-patches] Change in ovirt-image-uploader[master]: Clean the code to pass pep8 checks

2014-03-28 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: Clean the code to pass pep8 checks .. Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/26176/1/src/__main__.py File src/__main__.py: Line 173: Line 1

[Engine-patches] Change in ovirt-engine[master]: core: Enable user defined Windows Sysprep file

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: core: Enable user defined Windows Sysprep file .. Patch Set 3: Code-Review+2 +1 for FE - giving +2 since BE has been already approved -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: Numa feature entities

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Numa feature entities .. Patch Set 12: No Builds Executed http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests_master_gerrit/1462/ : To

[Engine-patches] Change in ovirt-engine[master]: core: MacPoolManager strategy, alternative implementation, t...

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: MacPoolManager strategy, alternative implementation, test for benchmarks .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_e

[Engine-patches] Change in ovirt-engine[master]: engine: Numa feature entities

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: engine: Numa feature entities .. Patch Set 12: * #1069303::Update tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Check merge

[Engine-patches] Change in ovirt-engine[master]: utils: performance improvement

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: performance improvement .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/4567/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: MacPoolManager strategy, alternative implementation, t...

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: MacPoolManager strategy, alternative implementation, test for benchmarks .. Patch Set 5: * #1063064::Update tracker: OK * Bug-Url: IGNORE, not in a

[Engine-patches] Change in ovirt-engine[master]: utils: performance improvement

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: performance improvement .. Patch Set 3: * #1063064::Update tracker: OK * Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4 * Check merge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: frontend: Adjust console tooltips

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: frontend: Adjust console tooltips .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit/1563/ : SUCCESS -

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: frontend: Adjust console tooltips

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: frontend: Adjust console tooltips .. Patch Set 4: * #1071894::Update tracker: OK * #1071894::Bug-Url: Correct product oVirt * #1071894::Bug-Url: OK, publi

[Engine-patches] Change in ovirt-engine[master]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: class cast exception in AdElementListModel .. Patch Set 2: backported -- To view, visit http://gerrit.ovirt.org/26119 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: class cast exception in AdElementListModel .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.4_unit_tests_gerrit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: class cast exception in AdElementListModel .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/26190 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: class cast exception in AdElementListModel .. Patch Set 1: * #1081895::Update tracker: OK * #1081895::Bug-Url: Correct product oVirt * #1081895:

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.4]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread tjelinek
Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: class cast exception in AdElementListModel .. webadmin: class cast exception in AdElementListModel A regression has been introduced by fc169177820737e

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: vm type not copied from template to pool

2014-03-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal,webadmin: vm type not copied from template to pool .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_unit_

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: vm type not copied from template to pool

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal,webadmin: vm type not copied from template to pool .. Patch Set 2: * #1057036::Update tracker: OK * #1057036::Target Release: OK * #1057036::Se

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: vm type not copied from template to pool

2014-03-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: vm type not copied from template to pool .. Patch Set 2: Verified+1 Code-Review+2 yep, just compiled locally - everything passes. -- To vi

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: vm type not copied from template to pool

2014-03-28 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: vm type not copied from template to pool .. userportal,webadmin: vm type not copied from template to pool Fixed by adding the missi

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: vm type not copied from template to pool

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal,webadmin: vm type not copied from template to pool .. Patch Set 2: * #1057036::Update tracker: OK * Bug-Url: IGNORE, not in a monitored branch

[Engine-patches] Change in ovirt-engine[master]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: class cast exception in AdElementListModel .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED: IGNORE, no Bug-Url found.

[Engine-patches] Change in ovirt-engine[master]: webadmin: class cast exception in AdElementListModel

2014-03-28 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: class cast exception in AdElementListModel .. webadmin: class cast exception in AdElementListModel A regression has been introduced by fc16917