Tomas Jelinek has posted comments on this change. Change subject: frontend: Support for Vm boot menu ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/26175/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1960: updateWatchdogModels(); Line 1961: updateBootMenu(); Line 1962: } Line 1963: Line 1964: private void updateBootMenu() { consider this flow: 1: have the boot menu available, check check it 2: select such cluster that the boot menu gets unavailable 3: submit the dialog the result will be that the boot menu: true will be sent to the server which does not make sense. So you need to also setEntity(false) if the isBootMenuSupported is false Line 1965: if (getSelectedCluster() != null) { Line 1966: Version version = getSelectedCluster().getcompatibility_version(); Line 1967: getBootMenuEnabled().setIsAvailable(AsyncDataProvider.isBootMenuSupported(version.toString())); Line 1968: } Line 1963: Line 1964: private void updateBootMenu() { Line 1965: if (getSelectedCluster() != null) { Line 1966: Version version = getSelectedCluster().getcompatibility_version(); Line 1967: getBootMenuEnabled().setIsAvailable(AsyncDataProvider.isBootMenuSupported(version.toString())); A little bit more user friendly than just hide the field is to disable it with an explanation that it is not supported for the current cluster level (e.g. setIsChangable()) Line 1968: } Line 1969: } Line 1970: Line 1971: private void handleQxlClusterLevel() { -- To view, visit http://gerrit.ovirt.org/26175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic181909f9f3c0d68162029fb0584b6d5afc5af5d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
