Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: class cast exception in AdElementListModel ......................................................................
webadmin: class cast exception in AdElementListModel A regression has been introduced by fc169177820737e984c65d930056be7e2e85d289. If there is no domain configured the search query used to return ArrayList but now it returns a Collections.emptyList() while the AdElementListModel tries to cast it to ArrayList which fails. Fixed by casting it to more general Collection. Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1081895 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/26190/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java index eeab90f..2ba0a2a 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java @@ -1,6 +1,7 @@ package org.ovirt.engine.ui.uicommonweb.models.users; import java.util.ArrayList; +import java.util.Collection; import java.util.Collections; import java.util.HashSet; import java.util.List; @@ -285,7 +286,7 @@ } } adElementListModel.setgroups(new ArrayList<EntityModel>()); - for (IVdcQueryable item : (ArrayList<IVdcQueryable>) ((VdcQueryReturnValue) ReturnValue).getReturnValue()) + for (IVdcQueryable item : (Collection<IVdcQueryable>) ((VdcQueryReturnValue) ReturnValue).getReturnValue()) { DirectoryGroup a = (DirectoryGroup) item; if (!excludeUsers.contains(a.getId())) -- To view, visit http://gerrit.ovirt.org/26190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
