Juan Hernandez has posted comments on this change.
Change subject: aaa: Introducing format to id of User and Group API entities
......................................................................
Patch Set 3:
It was my understanding that removing the external_id element from users was
done in order to have the same identifiers in /users and
/domain/{domain:id}/users. But now it happens to be that those identifiers will
be completely different, as /users will contain the internal and external
identifiers but /domain/{domain:id}/users will contain only the external
identifier. API callers won't thus be able figure out the relationship between
users from both collections, unless they know the details of the algorithm to
generate/parse the identifiers, wich should be opaque to them. Remove the
"id=..." part from the /users collection (and the provider_id= prefix), the
backend can always find the internal id from the external id.
Callers of the API are familiar with hex-looking identifiers everywhere, so
please use hex encoding instead of url_encode.
--
To view, visit http://gerrit.ovirt.org/26191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
