Allon Mureinik has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
..
Patch Set 3: Code-Review+2
Daniel, please verify.
--
To view, visit http://gerrit.ovirt.org/19105
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: provider: glance images listing size and limits
..
Patch Set 1: Code-Review+1
Basically looks OK, just fix the boxing issue you commented about.
--
To view, v
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Calculate 'procedureName' just once.
..
engine: Calculate 'procedureName' just once.
Change-Id: Ia79e6b239f99416e4d2e21cf44d002f1447e9b70
Signe
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rename method to start with lowercase
..
core: rename method to start with lowercase
Change-Id: I55adeeec30119d3ef307628bdf753c4786f8b754
Signed-
Allon Mureinik has posted comments on this change.
Change subject: engine: Calculate 'procedureName' just once.
..
Patch Set 4: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/19231
To
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to start with lowercase
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/19264
To u
Oved Ourfali has posted comments on this change.
Change subject: vdsm: use devices instead of drives in vm.conf
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19289
To unsubscribe, visit http://gerrit.
Omer Frenkel has posted comments on this change.
Change subject: core: rename HandleError method to lowercase
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19290
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to start with lowercase
..
Patch Set 2: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/19264
To u
Allon Mureinik has posted comments on this change.
Change subject: engine: Calculate 'procedureName' just once.
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/19231
To
Oved Ourfali has posted comments on this change.
Change subject: sanlock: creates metadata file
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19292
To unsubscribe, visit http://gerrit.ovirt.org/settin
Allon Mureinik has posted comments on this change.
Change subject: core: rename HandleError method to lowercase
..
Patch Set 1:
Omer/Yair?
--
To view, visit http://gerrit.ovirt.org/19290
To unsubscribe, visit http://gerrit.ov
Moti Asayag has posted comments on this change.
Change subject: core: Vnic hotplug validation - Patch 1 of 2
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19188
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: engine: Calculate 'procedureName' just once.
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19231
To unsubscribe, visit http://gerrit.
Roy Golan has posted comments on this change.
Change subject: core: rerun Maintenace to host when preparing is IDLE
..
Patch Set 5:
Omer if no objections I'm moving this from draft to publish.
I think this should get in
--
T
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: enhance line uninstall
..
Patch Set 4:
(1 comment)
File packaging/setup/plugins/ovir
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to start with lowercase
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19264
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: engine: cleanup in RemoveSnapshotSingleDiskCommand
..
Patch Set 2: Code-Review+2
@Sergey, please verify
--
To view, visit http://gerrit.ovirt.org/18688
To uns
Ofer Schreiber has posted comments on this change.
Change subject: packaging: spec: /var/lib/ovirt-engine/backups does not need to
be owned by ovirt
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovi
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: spec: /var/lib/ovirt-engine/backups does not need to
be owned by ovirt
..
packaging: spec: /var/lib/ovirt-engine/backups does not need to be
Ofer Schreiber has posted comments on this change.
Change subject: engine: search fix for storage pool
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19217
To unsubscribe, visit http://gerri
Ofer Schreiber has submitted this change and it was merged.
Change subject: engine: search fix for storage pool
..
engine: search fix for storage pool
The database field is called 'free_text_comment', not 'comment'
Change-Id:
Ofer Schreiber has posted comments on this change.
Change subject: engine: application touches a file to detect un orderly shutdown
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19166
To un
Ofer Schreiber has submitted this change and it was merged.
Change subject: engine: application touches a file to detect un orderly shutdown
..
engine: application touches a file to detect un orderly shutdown
Used to diagnose u
Ofer Schreiber has posted comments on this change.
Change subject: build: move version of ws-commons-util to master pom
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19135
To unsubscribe, v
Ofer Schreiber has submitted this change and it was merged.
Change subject: build: move version of ws-commons-util to master pom
..
build: move version of ws-commons-util to master pom
Change-Id: Ib0e5c840ba5d83cc5d21f418bbb92d
Allon Mureinik has posted comments on this change.
Change subject: engine : Change VdsUpdateRuntimeInfo to work with BatchUpdates
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19274
To unsubscribe, vi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Rename UseSecureConnectionWithServers
..
Patch Set 1:
I am ok with the name selection.
Comments on the name selection before this gets approved?
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine-config: Add EncryptHostCommunication
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19202
To unsubscribe, visit http:/
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine: Rename UseSecureConnectionWithServers
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19305
To unsubscribe, visit http
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: engine: Rename UseSecureConnectionWithServers
..
engine: Rename UseSecureConnectionWithServers
Rename UseSecureConnectionWithServers for EncryptHos
Greg Sheremeta has posted comments on this change.
Change subject: webadmin: Host interface manual refresh
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19143
To unsubscribe, visit http://gerrit.ovirt
Greg Sheremeta has posted comments on this change.
Change subject: userportal: Dynamic guide link
..
Patch Set 1: Code-Review+1
Since, in ovirt, the links are the same, we should change the message to say
something like "added
Greg Sheremeta has posted comments on this change.
Change subject: engine: make LoginDomainComparator Serializable
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19304
To unsubscribe, visit http://gerrit.
Greg Sheremeta has uploaded a new change for review.
Change subject: engine: make LoginDomainComparator Serializable
..
engine: make LoginDomainComparator Serializable
Make LoginDomainComparator Serializable to appease Coverity
Einav Cohen has posted comments on this change.
Change subject: engine: Add branded link to console resources
..
Patch Set 8: Verified+1 Code-Review+1
looks good:
http://i.imgur.com/6hWmxus.png
http://i.imgur.com/XkGa9Qb.png
Sergey Gotliv has posted comments on this change.
Change subject: engine: Cleanup of HotPlugDiskToVmCommand
..
Patch Set 1:
This patch is a small cleanup before resolving the race in that command.
--
To view, visit http://ger
Sergey Gotliv has uploaded a new change for review.
Change subject: engine: Cleanup of HotPlugDiskToVmCommand
..
engine: Cleanup of HotPlugDiskToVmCommand
1. Making class member private instead of protected
2. Replacing deprecat
Roy Golan has uploaded a new change for review.
Change subject: core: osinfo - change OSs audio device
..
core: osinfo - change OSs audio device
Esentially old OSs[1] supports ac97 emulated sound device while all the
new support
Roy Golan has submitted this change and it was merged.
Change subject: core: share a tranlation table of osinfo with DWH
..
core: share a tranlation table of osinfo with DWH
Added table dwh_osinfo table with os_id, os_name
On
Roy Golan has posted comments on this change.
Change subject: core: share a tranlation table of osinfo with DWH
..
Patch Set 10: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17767
To unsubscribe, visit ht
Einav Cohen has posted comments on this change.
Change subject: engine: fix unit test paths
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19299
To unsubscribe, visit http://gerrit.ovirt.org
Einav Cohen has posted comments on this change.
Change subject: engine: fix unit test paths
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19299
To unsubscribe, visit http://gerrit.ovirt.org
Einav Cohen has submitted this change and it was merged.
Change subject: engine: fix unit test paths
..
engine: fix unit test paths
- Fixed unit tests that would fail if working path had
a strange character in it like @
Chan
Einav Cohen has posted comments on this change.
Change subject: engine: fix unit test paths
..
Patch Set 2:
> Can we merge this ASAP, it cause a lot of errors in jenkins uts...
done.
--
To view, visit http://gerrit.ovirt.org
Gustavo Frederico Temple Pedrosa has posted comments on this change.
Change subject: core: Vnic hotplug validation - Patch 1 of 2
..
Patch Set 2:
(1 comment)
File
backend/m
Maor Lipchuk has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
..
Patch Set 2:
(4 comments)
File
backend/manager/modules/bl
Allon Mureinik has posted comments on this change.
Change subject: packaging: setup: Update Default DC compatibility level as 3.1
in gluster mode
..
Patch Set 2:
Yair - this, by definition is only done once, upon installing.
w
Yair Zaslavsky has posted comments on this change.
Change subject: packaging: setup: Update Default DC compatibility level as 3.1
in gluster mode
..
Patch Set 2:
Sahina,
Can you please elaborate more on upgrade path?
What if t
Daniel Erez has posted comments on this change.
Change subject: engine: cleanup in RemoveSnapshotSingleDiskCommand
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18688
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: provider: glance images listing size and limits
..
Patch Set 1:
Does Glance give any guarantee of atomicity?
i.e., if you got 20 images out of 100 at 16:00, an
Tal Nisan has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
(2 comments)
I wouldn't want to comment on each and every one of them but "Inteface" should
be replaced w
Daniel Erez has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1: Code-Review+2
+1, the typos are originated in CommonApplicationConstants.java.
@Lior, can you please ch
Daniel Erez has posted comments on this change.
Change subject: core: revert the existing solution for bz 878041
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19163
To unsubscribe, visit http://gerrit
Daniel Erez has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
..
Patch Set 2:
(5 comments)
File
backend/manager/modules/bll
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update
..
webadmin, userportal: translations update
pulled translation from Zanata oVirt project, master version.
Chan
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19281
To unsubscribe, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: backend: add audit logs for glance import
..
Patch Set 2: Verified+1 Code-Review+2
rebased, no code changes.
--
To view, visit http://gerrit.ovirt.org/19221
T
Allon Mureinik has posted comments on this change.
Change subject: core: remove VdcObjectType from ActionGroup enum
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19280
To unsubscribe, visit http://ger
Einav Cohen has posted comments on this change.
Change subject: webadmin, userportal: translations update
..
Patch Set 1:
(1 comment)
thanks, Tal, see my inline reply.
File
Allon Mureinik has posted comments on this change.
Change subject: core: lock VM for whole live snapshot process
..
Patch Set 2: Code-Review+1
I'd add a paragraph to the commit msg to explain WHY this is a good idea too.
--
T
Arik Hadas has posted comments on this change.
Change subject: core: trigger auto-start VMs runner job after live snapshot
operation
..
Patch Set 2:
(1 comment)
File
backe
Arik Hadas has posted comments on this change.
Change subject: core: trigger auto-start VMs runner job after live snapshot
operation
..
Patch Set 2:
(1 comment)
this patch is currently on hold as I'm checking other solution (
Allon Mureinik has posted comments on this change.
Change subject: engine: Illegal images should be skipped when validating
duplicates
..
Patch Set 4: Code-Review+2
@Sergey - please verify
--
To view, visit http://gerrit.ovi
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove VdcObjectType from ActionGroup enum
..
Patch Set 2:
Please verify and make sure to check permissions.
--
To view, visit http://gerrit.ovirt.org/1
Allon Mureinik has posted comments on this change.
Change subject: core,ui: VirtIO-SCSI enabled flag
..
Patch Set 6:
(1 comment)
Looks OK to me.
Omer?
File
backend/manager
Allon Mureinik has submitted this change and it was merged.
Change subject: backend: add audit logs for glance import
..
backend: add audit logs for glance import
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005481
Cha
Allon Mureinik has posted comments on this change.
Change subject: core: revert the existing solution for bz 878041
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19163
To unsubscribe, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: trigger auto-start VMs runner job after live snapshot
operation
..
Patch Set 2: Code-Review+1
(1 comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: packaging: spec: use system jars
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19060
To unsubscribe, visit http://gerrit.ovirt.org/se
Moti Asayag has posted comments on this change.
Change subject: engine: Add audit log for network without interfaces
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19291
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 3:
@Fede - can you verify?
--
To view, visit http://gerrit.ovirt.org/19187
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19187
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: packaging: spec: use system jars
..
Patch Set 6: Code-Review+1
The concept looks sound.
>> verified as much as I could...
Can you share what you did?
--
To
Yair Zaslavsky has posted comments on this change.
Change subject: packaging: spec: use system jars
..
Patch Set 5:
How can we test/verify this?
--
To view, visit http://gerrit.ovirt.org/19060
To unsubscribe, visit http://ger
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Remove instanceof from GetDomainListQuery
..
engine: Remove instanceof from GetDomainListQuery
Runtime type checking is no way of passing param
Allon Mureinik has posted comments on this change.
Change subject: engine: Remove instanceof from GetDomainListQuery
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/1886
Allon Mureinik has posted comments on this change.
Change subject: frontend: display correct format in edit domain
..
Patch Set 2:
(1 comment)
File
frontend/webadmin/module
Mike Kolesnik has posted comments on this change.
Change subject: engine: Add audit log for network without interfaces
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19291
To unsubscribe, visit http://
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add audit log for network without interfaces
..
engine: Add audit log for network without interfaces
An audit log should be added to the use case
Allon Mureinik has posted comments on this change.
Change subject: core: rename HandleError method to lowercase
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19290
To unsubscribe, visit http://gerrit.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine-config: Add UseSecureConnectionWithServers
..
Patch Set 1:
Looks good to me EncryptHostCommunication. Yair?
--
To view, visit http://gerrit
Tal Nisan has posted comments on this change.
Change subject: core: Fix double checking
..
Patch Set 3:
Can't we just change it to have a class static member like Roy offered? Makes
more sense to me
--
To view, visit http://
Itamar Heim has posted comments on this change.
Change subject: engine-config: Add UseSecureConnectionWithServers
..
Patch Set 1:
EncryptHostCommunication?
--
To view, visit http://gerrit.ovirt.org/19202
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: core: rename HandleError method to lowercase
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19290
To unsubscribe, visit http://gerrit.ovirt
Tal Nisan has posted comments on this change.
Change subject: core: rename methods to lowercase in vds commands
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19288
To unsubscribe, visit http://gerrit.
Arik Hadas has posted comments on this change.
Change subject: core: ignore findbugs error for not overriding hashCode()
..
Patch Set 3: Verified+1 -Code-Review
--
To view, visit http://gerrit.ovirt.org/19168
To unsubscribe, v
Omer Frenkel has posted comments on this change.
Change subject: core: ignore findbugs error for not overriding hashCode()
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19168
To unsubscribe, visit htt
Daniel Erez has posted comments on this change.
Change subject: core: remove VdcObjectType from ActionGroup enum
..
Patch Set 1:
(2 comments)
File
backend/manager/modules/c
Arik Hadas has posted comments on this change.
Change subject: core: ignore findbugs error for not overriding hashCode()
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19168
To unsubscribe, visit http:
Martin Sivák has uploaded a new change for review.
Change subject: Kill the agent if three subsequent broker requests fail
..
Kill the agent if three subsequent broker requests fail
Change-Id: Ia5ec6935673133af2e60f339b035dba343
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine-config: Add UseSecureConnectionWithServers
..
Patch Set 1:
Hi Yair, sure. Itamar, do you have any suggestion? ConnectSecurelyWithHosts?
--
Allon Mureinik has posted comments on this change.
Change subject: core: move unplugged disks while VM is running
..
Patch Set 2: Code-Review+1
(1 comment)
File
backend/man
Moti Asayag has posted comments on this change.
Change subject: engine: Add audit log for network without interfaces
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19291
To unsubscribe, visit http://gerri
Moti Asayag has uploaded a new change for review.
Change subject: engine: Add audit log for network without interfaces
..
engine: Add audit log for network without interfaces
An audit log should be added to the use case in which
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Remove instanceof from GetDomainListQuery
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18869
To unsubscribe, visit http://ge
Michael Pasternak has posted comments on this change.
Change subject: sdk: update function doesnt have overloading methods #1008176
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19287
To un
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: update function doesnt have overloading methods #1008176
..
sdk: update function doesnt have overloading methods #1008176
Change-Id: I231de9a76
Roy Golan has posted comments on this change.
Change subject: engine: Incorrect VM TimeZone handling
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17524
To unsubscribe, visit http://gerrit.ovirt.org/s
Gilad Chaplik has posted comments on this change.
Change subject: core: fix findbugs issue for PolicyUnit.equals()
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19285
To unsubscribe, visit http://gerrit.
1 - 100 of 221 matches
Mail list logo
