Allon Mureinik has posted comments on this change.

Change subject: core,ui: VirtIO-SCSI enabled flag
......................................................................


Patch Set 6:

(1 comment)

Looks OK to me.
Omer?

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 169:                 addVirtioScsiController(vmId);
Line 170:             }
Line 171:         } else {
Line 172:             for (VmDevice device : controllers) {
Line 173:                 dao.remove(device.getId());
we should have a removeAll function sometime in the future, not sure if I'd 
load it on this patch...
Line 174:             }
Line 175:         }
Line 176:     }
Line 177: 


-- 
To view, visit http://gerrit.ovirt.org/18638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice06fda5946b5961cfe9c819b0b368525b1f4b58
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to