Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: enhance line uninstall ......................................................................
Patch Set 4: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/files/simple.py Line 91: new_content.append(line) Line 92: new_content.extend(just_add) Line 93: Line 94: # TODO Line 95: # Remove this after http://gerrit.ovirt.org/18690 is released No, I meant "released". So that we can "Require:" the released version (it's in otopi, not in the engine). Line 96: new_content = '\n'.join(new_content) + '\n' Line 97: Line 98: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 99: filetransaction.FileTransaction( -- To view, visit http://gerrit.ovirt.org/16768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69ab434de8fb675c67ac5d1907879e465e587dbf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
