Allon Mureinik has posted comments on this change.
Change subject: frontend: display correct format in edit domain
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
Line 612:
Line 613: // If data center has format defined and the
selected-item role is Data, choose it.
Line 614: if (dataCenter.getStoragePoolFormatType() != null
Line 615: && (getSelectedItem().getRole() ==
StorageDomainType.Data
Line 616: || getSelectedItem().getRole() ==
StorageDomainType.Master)) {
Just use getSelectedItem().getRole().isDataDomain()
[Frankly, I assume this is what the original code meant.]
Line 617:
formats.add(dataCenter.getStoragePoolFormatType());
Line 618: selectItem =
dataCenter.getStoragePoolFormatType();
Line 619: }
Line 620: // If selected-item role is ISO or Export, add only
the 'V1' option.
--
To view, visit http://gerrit.ovirt.org/19187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0432d633fabcf62b14b267b8dd9ca517b69c029a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
