Tomas Jelinek has posted comments on this change.
Change subject: Webadmin: set default single Qxl device to true
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18736
To unsubscribe, visit http://gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: VDS Cmd: Gluster Volume Rebalance Stop
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_
Sandro Bonazzola has posted comments on this change.
Change subject: tools: Print selinux context of files in hosts.
..
Patch Set 1:
Maor, please add bug url to the commit msg.
--
To view, visit http://gerrit.ovirt.org/18747
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: refactor volume list action availability
..
Patch Set 15: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: BLL Command to Stop Reblance Gluster Volume task
..
Patch Set 15: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_co
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin : added volume rebalance start action
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Added taskId to volume and brick
..
Patch Set 26:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine:Start Rebalance Gluster volume command
..
Patch Set 29:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine:Support for gluster asynchronous tasks
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
Lior Vernia has posted comments on this change.
Change subject: webadmin: Increased width of "public" label
..
Patch Set 1:
(1 comment)
File
frontend/webadmin/modules/webad
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: remove storage - gray out hosts list
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18751
To unsubscribe, visit http://gerrit
Ramesh N has posted comments on this change.
Change subject: engine:Support for gluster asynchronous tasks
..
Patch Set 22:
(1 comment)
File packaging/dbscripts/job_sp.sql
L
Kiril Nesenko has posted comments on this change.
Change subject: tools: Print selinux context of files in hosts.
..
Patch Set 1:
Please add bug url to the commit msg
--
To view, visit http://gerrit.ovirt.org/18747
To unsubsc
Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: modify AIA port when upgrade from legacy
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18687
To unsubscribe, vi
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/4301/
Build Number: 4301
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Added app_mode field to roles table
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Added app_mode field to roles table
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Added app_mode field to roles table
..
gluster: Added app_mode field to roles table
Added a field app_mode to roles table. The value of applicati
Kanagaraj M has posted comments on this change.
Change subject: gluster: Added app_mode field to roles table
..
Patch Set 12: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18592
To unsubscribe, visit http:
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Added app_mode field to roles table
..
Patch Set 11: Verified+1
Rebased and verified
--
To view, visit http://gerrit.ovirt.org/18592
To unsubscri
Alex Lourie has abandoned this change.
Change subject: packaging: setup: set default ENGINE_STOP value to False
..
Abandoned
No issues with current implementation.
--
To view, visit http://gerrit.ovirt.org/18748
To unsubscrib
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: removing ssh.user.user_name field from adding host
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/3
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: setup: modify AIA port when upgrade from legacy
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri
Yaniv Bronhaim has uploaded a new change for review.
Change subject: API: removing ssh.user.user_name field from adding host
..
API: removing ssh.user.user_name field from adding host
This patch is temporary:
Revert this patch w
oVirt Jenkins CI Server has posted comments on this change.
Change subject: API: editing host update and add fields
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/3471/ : SUCCESS
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: modify AIA port when upgrade from legacy
..
Patch Set 2: Verified+1
Added warning and some cleanups.
--
To view, visit http://gerrit.ovirt.org
Alex Lourie has uploaded a new change for review.
Change subject: packaging: setup: stop and warn if setup is not run as root
user.
..
packaging: setup: stop and warn if setup is not run as root user.
Change-Id: I4aeb4cc80d4dda
Yaniv Bronhaim has uploaded a new change for review.
Change subject: API: editing host update and add fields
..
API: editing host update and add fields
Updating ssh fields in adding new host:
* Setting password as optional param
Alex Lourie has uploaded a new change for review.
Change subject: packaging: setup: stop and notify if setup is not run as root
..
packaging: setup: stop and notify if setup is not run as root
Change-Id: Id1a46f817cad72bd0de7752
Doron Fediuck has posted comments on this change.
Change subject: External scheduler - move to class based plugins
..
Patch Set 4: Code-Review+1
(2 comments)
Much better.
Please fix the dummy comments to merge this in.
.
Doron Fediuck has posted comments on this change.
Change subject: throw exception if plugin not found
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18728
To unsubscribe, visit http://gerrit.ovirt.org/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: saving memcheck parameter to answer file
..
Patch Set 8:
please verify
--
To view, visit http://gerrit.ovirt.org/18669
To unsubscribe, visit h
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: filetransaction: Always add a newline
..
core: filetransaction: Always add a newline
Always add newline when the content is a non-empty list or tup
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: do not mark iptables unremovable if not
actually used
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18740
To unsubsc
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: do not mark iptables unremovable if not
actually used
..
Patch Set 1: Verified+1 -Code-Review
--
To view, visit http://gerrit.ovirt.org/18740
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: setup: remove 'default' term from iso nfs export
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: setup: remove 'default' term from iso nfs export
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: remove 'default' term from iso nfs export
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18752
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: ptackaging: setup: remove 'default' term from iso nfs export
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18752
To unsubscribe, visit htt
Alon Bar-Lev has uploaded a new change for review.
Change subject: ptackaging: setup: remove 'default' term from iso nfs export
..
ptackaging: setup: remove 'default' term from iso nfs export
confusing term for share creation ba
Yaniv Bronhaim has posted comments on this change.
Change subject: rest-api: validation of max parameter in restapi
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.ovirt.org/18043
To unsubscribe, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Introducing VersionStorageFormatUtil
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Warning about storage format upgrade
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Warning about storage format upgrade
..
Patch Set 4: Verified+1
Fix previous patch in set, no changes to this one.
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing VersionStorageFormatUtil
..
Patch Set 3: Verified+1
Thanks for the review, Maor.
Re: having StorageFormatType as a member of Version - that w
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/438/
Build Number: 438
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: set default ENGINE_STOP value to False
..
Patch Set 1:
So what is the exact issue with current implementation?
--
To view, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: pki: Remove old certs on CA creation
..
Patch Set 1:
I think that for completeness, if we manage one we should manage the other.
--
To view, visit http://gerrit
Alex Lourie has posted comments on this change.
Change subject: packaging: setup: set default ENGINE_STOP value to False
..
Patch Set 1:
If we set it to True or False in answerfile, it will not ask user.
I think it negates the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fix findbugs errors
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7507/
: SUCCES
Omer Frenkel has posted comments on this change.
Change subject: gluster: Query for gluster volume rebalance status
..
Patch Set 12:
query looks ok, missing test
--
To view, visit http://gerrit.ovirt.org/18352
To unsubscribe,
Yedidyah Bar David has posted comments on this change.
Change subject: pki: Remove old certs on CA creation
..
Patch Set 1:
> What about keys? requests?
These make sense too, but do not create a problem similar to the one with
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: remove storage - gray out hosts list
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: solve VCpuPin CNF exception in tests
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fix possible NPE in internal migration
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: fix possible NPE in migrate vm to server
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/
Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/1977/
Build Number: 1977
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Project:
http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/1977/
Build Number: 1977
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine_update_db_mult
Maor Lipchuk has posted comments on this change.
Change subject: engine: Removes not used image groups after snapshot removal
..
Patch Set 2:
(1 comment)
Commit Message
Line
Omer Frenkel has posted comments on this change.
Change subject: gluster: Added app_mode field to roles table
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18592
To unsubscribe, visit http://gerrit.o
Maor Lipchuk has posted comments on this change.
Change subject: engine: Removes not used image groups after snapshot removal
..
Patch Set 2: Code-Review+1
(4 comments)
Solution looks good, minor comments inline
.
Alon Bar-Lev has posted comments on this change.
Change subject: pki: Remove old certs on CA creation
..
Patch Set 1:
Nice!
What about keys? requests?
--
To view, visit http://gerrit.ovirt.org/18749
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: core: fix findbugs errors
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18650
To unsubscribe, visit http://gerrit.ovirt.org/
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix findbugs errors
..
core: fix findbugs errors
There were couple of errors related to the way we compute if post zero
is needed when removing mem
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/4902/
Build Number: 4902
Build Status: Failure
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes Since Last Success:
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: remove storage - gray out hosts list
..
webadmin: remove storage - gray out hosts list
Host list is irrelevant for ISO/Export domains when 'format'
is u
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: lock VM for the whole VM migration process
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: assure migration jobs are completed
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/
Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/1976/
Build Number: 1976
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
Yedidyah Bar David has posted comments on this change.
Change subject: core: filetransaction: Always add a newline
..
Patch Set 3: Verified+1
Verified with http://gerrit.ovirt.org/18738 and the TODO-mark removed,
setup/cleanup
Alissa Bonas has posted comments on this change.
Change subject: restapi: solve VCpuPin CNF exception in tests
..
Patch Set 1: Verified+1
compilation and unitests
--
To view, visit http://gerrit.ovirt.org/18750
To unsubscribe
Alissa Bonas has uploaded a new change for review.
Change subject: restapi: solve VCpuPin CNF exception in tests
..
restapi: solve VCpuPin CNF exception in tests
Solve ClassNotFound exception in mapper tests related
to incorrect
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pki: Remove old certs on CA creation
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/3459/ : SUCCESS
--
Project:
http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/
Build:
http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/1976/
Build Number: 1976
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine_update_db_mu
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: keep locks for whole offline disk migration process
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_c
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix possible NPE in internal migration
..
core: fix possible NPE in internal migration
The check for migration support uses the VM and it was execu
Omer Frenkel has posted comments on this change.
Change subject: core: fix possible NPE in internal migration
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18586
To unsubscribe, visit http:
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix possible NPE in migrate vm to server
..
core: fix possible NPE in migrate vm to server
Rearrange the order of the checks which are carried out
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: acquire locks in standard way in MoveOrCopyDiskCommand
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compil
Omer Frenkel has posted comments on this change.
Change subject: core: fix possible NPE in migrate vm to server
..
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18474
To unsubscribe, visit htt
Omer Frenkel has submitted this change and it was merged.
Change subject: core: lock VM for the whole VM migration process
..
core: lock VM for the whole VM migration process
Exclusive VM lock is now being taken for the whole e
Omer Frenkel has posted comments on this change.
Change subject: core: lock VM for the whole VM migration process
..
Patch Set 7: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18472
To unsubscribe, visit h
Omer Frenkel has submitted this change and it was merged.
Change subject: core: assure migration jobs are completed
..
core: assure migration jobs are completed
Add missing call to failedToRunVm method when VM migration fails b
Omer Frenkel has posted comments on this change.
Change subject: core: assure migration jobs are completed
..
Patch Set 7: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18471
To unsubscribe, visit http://g
Omer Frenkel has posted comments on this change.
Change subject: core: lock VM for whole live disk migration process
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18545
To unsubscribe, visit http://ge
Yedidyah Bar David has posted comments on this change.
Change subject: pki: Remove old certs on CA creation
..
Patch Set 1: Verified+1
(1 comment)
File packaging/bin/pki-cre
Omer Frenkel has submitted this change and it was merged.
Change subject: core: keep locks for whole offline disk migration process
..
core: keep locks for whole offline disk migration process
The VM lock is now kept for the wh
Omer Frenkel has posted comments on this change.
Change subject: core: keep locks for whole offline disk migration process
..
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18530
To unsubscribe
Yedidyah Bar David has uploaded a new change for review.
Change subject: pki: Remove old certs on CA creation
..
pki: Remove old certs on CA creation
Example scenario where this is required:
engine-setup ran with websocket-proxy
Omer Frenkel has posted comments on this change.
Change subject: core: acquire locks in standard way in MoveOrCopyDiskCommand
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18523
To unsubscr
Omer Frenkel has submitted this change and it was merged.
Change subject: core: acquire locks in standard way in MoveOrCopyDiskCommand
..
core: acquire locks in standard way in MoveOrCopyDiskCommand
In order to solve the race b
Omer Frenkel has posted comments on this change.
Change subject: engine:changed AddVdsCommand to use LockManager properly
..
Patch Set 1:
why do you take lock with wait?
i think it will block the caller (ui) if the lock is take
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: generalize getStoragePoolIdForDomain
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ge
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: set default ENGINE_STOP value to False
..
Patch Set 1:
Well, actually if it is None we should prompt user, if it is non None we should
follow v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: setup: set default ENGINE_STOP value to False
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/
mooli tayer has posted comments on this change.
Change subject: rest-api: validation of max parameter in restapi
..
Patch Set 2: Verified+1
(1 comment)
File
backend/manager
Alex Lourie has uploaded a new change for review.
Change subject: packaging: setup: set default ENGINE_STOP value to False
..
packaging: setup: set default ENGINE_STOP value to False
Current implementation sets default value of
Daniel Erez has posted comments on this change.
Change subject: webadmin: Increased width of "public" label
..
Patch Set 1: Code-Review+2
(1 comment)
File
frontend/webadmin
Daniel Erez has posted comments on this change.
Change subject: webadmin: Increased width of provider popup
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18743
To unsubscribe, visit http://gerrit.ovir
Daniel Erez has posted comments on this change.
Change subject: webadmin: Changed text for custom MAC address
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18744
To unsubscribe, visit http://gerrit.ov
1 - 100 of 241 matches
Mail list logo
