Alex Lourie has uploaded a new change for review.
Change subject: packaging: setup: set default ENGINE_STOP value to False
......................................................................
packaging: setup: set default ENGINE_STOP value to False
Current implementation sets default value of ENGINE_STOP
environment to None.
The new implementation sets it to False, allowing to use
it in the answer file with a clear logic.
Change-Id: I320b3d4bc778e5a578e3d154225c1969ae4510fc
Signed-off-by: Alex Lourie <alou...@redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/core/engine.py
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/48/18748/1
diff --git a/packaging/setup/plugins/ovirt-engine-common/core/engine.py
b/packaging/setup/plugins/ovirt-engine-common/core/engine.py
index 5187ea3..58a625a 100644
--- a/packaging/setup/plugins/ovirt-engine-common/core/engine.py
+++ b/packaging/setup/plugins/ovirt-engine-common/core/engine.py
@@ -44,7 +44,7 @@
def _init(self):
self.environment.setdefault(
osetupcons.CoreEnv.ENGINE_SERVICE_STOP,
- None
+ False
)
@plugin.event(
@@ -55,9 +55,7 @@
self.services.exists(name=osetupcons.Const.ENGINE_SERVICE_NAME) and
self.services.status(name=osetupcons.Const.ENGINE_SERVICE_NAME)
):
- if self.environment[
- osetupcons.CoreEnv.ENGINE_SERVICE_STOP
- ] is None:
+ if not self.environment[osetupcons.CoreEnv.ENGINE_SERVICE_STOP]:
self.environment[
osetupcons.CoreEnv.ENGINE_SERVICE_STOP
] = dialog.queryBoolean(
--
To view, visit http://gerrit.ovirt.org/18748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I320b3d4bc778e5a578e3d154225c1969ae4510fc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
