Allon Mureinik has posted comments on this change. Change subject: core: Introducing VersionStorageFormatUtil ......................................................................
Patch Set 3: Verified+1 Thanks for the review, Maor. Re: having StorageFormatType as a member of Version - that would have been my preferred solution too, but it's not possible. Version is part of the compat package, and StorageFormatType comes from the common package, that depends on compat. Re: AddStoragePoolWithStoragesCommand - implemented, as per your review. -- To view, visit http://gerrit.ovirt.org/18697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47fb8b14e5c97b601c8fc0cc296a4ec42a48227a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
