Doron Fediuck has posted comments on this change. Change subject: External scheduler - move to class based plugins ......................................................................
Patch Set 4: Code-Review+1 (2 comments) Much better. Please fix the dummy comments to merge this in. .................................................... File plugins/dummy.py Line 34: Line 35: # do not remove this import, the ovirtsdk is not going to work without it Line 36: #from ovirtsdk.xml import params Line 37: #from ovirtsdk import api Line 38: #import ovirtsdk.infrastructure.brokers If the imports are not needed, please remove. Also, if this is a working sample, where is the REST client connection? You can have a simple function to generate the connection, and all other methods using it. Line 39: import sys Line 40: Line 41: Line 42: class dummy(): Line 38: #import ovirtsdk.infrastructure.brokers Line 39: import sys Line 40: Line 41: Line 42: class dummy(): Please stop using dummy, it's a bad name. It can be noop_filter or sample filter. Line 43: # Notice: plugin filters are going to run in process that will be created and destroyed Line 44: # per request, you cannot save state in memory Line 45: def do_filter(self, hosts, vm, args): Line 46: '''This is a simple filter that returns all given host ID''' -- To view, visit http://gerrit.ovirt.org/18739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94c7de6d036bd279f34c0ba246a129d88caa130a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Noam Slomianko <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
