[Engine-patches] Change in ovirt-engine[master]: core: Adding RpmVersion utils

2013-08-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: core: Adding RpmVersion utils .. Patch Set 7: Code-Review-1 Well, we were right. Keeping my -1 until 1.3.fc18 will be newer than 1.fc18 -- To view, visit http

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: restapi: Support for gluster hooks added

2013-08-26 Thread oliel
Ori Liel has posted comments on this change. Change subject: restapi: Support for gluster hooks added .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18495 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: gluster: VDS Cmd: Gluster Volume Rebalance Stop

2013-08-26 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: VDS Cmd: Gluster Volume Rebalance Stop .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18442 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: engine: BLL Command to Stop Reblance Gluster Volume task

2013-08-26 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: engine: BLL Command to Stop Reblance Gluster Volume task .. Patch Set 2: (2 comments) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Remove keys on cleanup after upgrade

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Remove keys on cleanup after upgrade .. Patch Set 1: Code-Review+1 Thanks! -- To view, visit http://gerrit.ovirt.org/18584 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Remove keys on cleanup after upgrade

2013-08-26 Thread Yedidyah Bar David
Yedidyah Bar David has uploaded a new change for review. Change subject: packaging: setup: Remove keys on cleanup after upgrade .. packaging: setup: Remove keys on cleanup after upgrade Remove engine_id_rsa and apache.key.nopass

[Engine-patches] Change in ovirt-engine-sdk-java[master]: sdk: implement AutoCloseable

2013-08-26 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: sdk: implement AutoCloseable .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18538 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: engine: BLL Command to Stop Reblance Gluster Volume task

2013-08-26 Thread sabose
Sahina Bose has posted comments on this change. Change subject: engine: BLL Command to Stop Reblance Gluster Volume task .. Patch Set 2: (6 comments) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Copy VNIC profile configuration from template

2013-08-26 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: webadmin: Copy VNIC profile configuration from template .. Patch Set 1: (1 comment) File frontend/webadmin/m

[Engine-patches] Change in ovirt-engine[master]: engine: Consider case-sensitivity for mac-address uniqueness

2013-08-26 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Consider case-sensitivity for mac-address uniqueness .. Patch Set 2: (2 comments) File backend/man

[Engine-patches] Change in ovirt-engine[master]: restapi: Allow untagging a network with vlan-id

2013-08-26 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: restapi: Allow untagging a network with vlan-id .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18489 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Remove unused code

2013-08-26 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Remove unused code .. Patch Set 1: (4 comments) Nice cleanup, it can be a bit more extensive while you're at it.. .

[Engine-patches] Change in ovirt-engine[master]: core: Validate vm nic name has no special characters

2013-08-26 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Validate vm nic name has no special characters .. core: Validate vm nic name has no special characters The patch validates the vm nic name is cons

[Engine-patches] Change in ovirt-engine[master]: core: Validate vm nic name has no special characters

2013-08-26 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Validate vm nic name has no special characters .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18487 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: frontend: node upgrade message improvement

2013-08-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: frontend: node upgrade message improvement .. Patch Set 10: Douglas, thanks. -- To view, visit http://gerrit.ovirt.org/17987 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: Adding RpmVersion utils

2013-08-26 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: core: Adding RpmVersion utils .. Patch Set 7: Code-Review+1 The same thought as Yaniv, except that point it's good. -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: frontend: node upgrade message improvement

2013-08-26 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: frontend: node upgrade message improvement .. Patch Set 10: Yair, my second example was between 2.6.0 and 2.6.1 and it worked, it was typo. -- To

[Engine-patches] Change in ovirt-engine[master]: core: Adding RpmVersion utils

2013-08-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: core: Adding RpmVersion utils .. Patch Set 7: Code-Review+1 odd, but except that, all good to go.. -- To view, visit http://gerrit.ovirt.org/18370 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Adding RpmVersion utils

2013-08-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Adding RpmVersion utils .. Patch Set 7: Code-Review+1 (1 comment) File backend/manager/modules/comm

[Engine-patches] Change in ovirt-engine[master]: core: rename methods to start with lowercase

2013-08-26 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: rename methods to start with lowercase .. Patch Set 1: (1 comment) File backend/manager/modules/bll/s

[Engine-patches] Change in ovirt-engine[master]: core: Adding RpmVersion utils

2013-08-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: core: Adding RpmVersion utils .. Patch Set 7: Code-Review-1 (1 comment) File backend/manager/modules/comm

[Engine-patches] Change in ovirt-engine[master]: core: Improve CommandsFactory exception logging

2013-08-26 Thread rnori
Ravi Nori has posted comments on this change. Change subject: core: Improve CommandsFactory exception logging .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18141 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: packaging: update otopi, ovirt-host-deploy to release

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: update otopi, ovirt-host-deploy to release .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18582 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: packaging: update otopi, ovirt-host-deploy to release

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: update otopi, ovirt-host-deploy to release .. packaging: update otopi, ovirt-host-deploy to release Change-Id: Ib7a8e7c95feb31103ee75ed57a69e5f732e251

[Engine-patches] Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: ovirt-host-deploy-1.1.0 .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18580 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-host-deploy[master]: packaging: post ovirt-host-deploy-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post ovirt-host-deploy-1.1.0 .. packaging: post ovirt-host-deploy-1.1.0 Change-Id: Id3beb9acda5b64fcfb3fbebcdb257b6a35f6c434 Signed-off-by: Al

[Engine-patches] Change in ovirt-host-deploy[master]: packaging: post ovirt-host-deploy-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: post ovirt-host-deploy-1.1.0 .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18581 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: ovirt-host-deploy-1.1.0 .. packaging: ovirt-host-deploy-1.1.0 Change-Id: I068cbf1bd0c467deeace0564c03d47e4d9f93d06 Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: ovirt-host-deploy-1.1.0 .. packaging: ovirt-host-deploy-1.1.0 Change-Id: I068cbf1bd0c467deeace0564c03d47e4d9f93d06 Signed-off-by: Alon Bar-Lev --- M

[Engine-patches] Change in ovirt-host-deploy[master]: packaging: post ovirt-host-deploy-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: post ovirt-host-deploy-1.1.0 .. packaging: post ovirt-host-deploy-1.1.0 Change-Id: Id3beb9acda5b64fcfb3fbebcdb257b6a35f6c434 Signed-off-by: Alon Bar-L

[Engine-patches] Change in otopi[master]: packaging: post otopi-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: post otopi-1.1.0 .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18579 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: user who added external events does not...

2013-08-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: user who added external events does not... .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17924 To unsubscribe, visit http://ger

[Engine-patches] Change in otopi[master]: packaging: post otopi-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post otopi-1.1.0 .. packaging: post otopi-1.1.0 Change-Id: I326d69a7f54007cf7e107736a61ac53be94fe2e4 Signed-off-by: Alon Bar-Lev --- M config

[Engine-patches] Change in otopi[master]: packaging: otopi-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: otopi-1.1.0 .. packaging: otopi-1.1.0 Change-Id: Ifec09b6579efabe257a5620b50bcdc76f831de1c Signed-off-by: Alon Bar-Lev --- M configure.ac M o

[Engine-patches] Change in otopi[master]: packaging: otopi-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: otopi-1.1.0 .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18578 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in otopi[master]: packaging: post otopi-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: post otopi-1.1.0 .. packaging: post otopi-1.1.0 Change-Id: I326d69a7f54007cf7e107736a61ac53be94fe2e4 Signed-off-by: Alon Bar-Lev --- M configure.ac 1

[Engine-patches] Change in otopi[master]: packaging: otopi-1.1.0

2013-08-26 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: otopi-1.1.0 .. packaging: otopi-1.1.0 Change-Id: Ifec09b6579efabe257a5620b50bcdc76f831de1c Signed-off-by: Alon Bar-Lev --- M configure.ac M otopi.spe

[Engine-patches] Change in ovirt-engine[master]: frontend: node upgrade message improvement

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: frontend: node upgrade message improvement .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: backend: GetoVirtISOsQuery use RpmVersionUtils

2013-08-26 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: backend: GetoVirtISOsQuery use RpmVersionUtils .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/18435 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: frontend: node upgrade message improvement

2013-08-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: frontend: node upgrade message improvement .. Patch Set 10: Followed all comments -- To view, visit http://gerrit.ovirt.org/17987 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: backend: GetoVirtISOsQuery use RpmVersionUtils

2013-08-26 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: backend: GetoVirtISOsQuery use RpmVersionUtils .. Patch Set 7: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18435 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine-cli[master]: cli: bogous 'help show event' output

2013-08-26 Thread rnori
Ravi Nori has posted comments on this change. Change subject: cli: bogous 'help show event' output .. Patch Set 1: (1 comment) File src/ovirtcli/utils/methodhelper.py Line 1

[Engine-patches] Change in ovirt-engine[master]: frontend: node upgrade message improvement

2013-08-26 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: frontend: node upgrade message improvement .. Patch Set 9: (1 comment) File frontend/webadmi

[Engine-patches] Change in ovirt-engine[master]: frontend: node upgrade message improvement

2013-08-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: frontend: node upgrade message improvement .. Patch Set 9: (3 comments) File frontend/webadmin/modules/u

[Engine-patches] Change in ovirt-engine[master]: core: Adding RpmVersion utils

2013-08-26 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: core: Adding RpmVersion utils .. Patch Set 7: (3 comments) File backend/manager/modules/commo

[Engine-patches] Change in ovirt-engine[master]: restapi : add descriptions to rsdl

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi : add descriptions to rsdl .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7158/

[Engine-patches] Change in ovirt-engine[master]: restapi : add descriptions to rsdl

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi : add descriptions to rsdl .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7157/

[Engine-patches] Change in ovirt-engine[master]: restapi : add descriptions to rsdl

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi : add descriptions to rsdl .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7156/

[Engine-patches] Change in ovirt-engine[master]: restapi : add descriptions to rsdl

2013-08-26 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi : add descriptions to rsdl .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/18576 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: restapi : add descriptions to rsdl

2013-08-26 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: restapi : add descriptions to rsdl .. restapi : add descriptions to rsdl Add descriptions to rsdl. This patch fixes the issue where descriptions where not displayed

[Engine-patches] Change in ovirt-engine[master]: core: rename methods to start with lowercase

2013-08-26 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: rename methods to start with lowercase .. Patch Set 1: Code-Review+1 (1 comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: frontend: Control virtio rng device

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: frontend: Control virtio rng device .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7154/

[Engine-patches] Change in ovirt-engine[master]: backend: Control virtio rng device

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: backend: Control virtio rng device .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7155/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: external scheduler integration

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18555 to review the following change. Change subject: engine: external scheduler integration .. engine: external scheduler integ

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring

2013-08-26 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Prevent implicit usage of port mirroring .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18547 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: lock VM for whole live disk migration process

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: lock VM for whole live disk migration process .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: backend: Control virtio rng device

2013-08-26 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: backend: Control virtio rng device .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/18176 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: frontend: Control virtio rng device

2013-08-26 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: frontend: Control virtio rng device .. Patch Set 2: Verified+1 addressed comments from #1 -- To view, visit http://gerrit.ovirt.org/18497 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: scheduler: separate policy unit per class

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: scheduler: separate policy unit per class .. core: scheduler: separate policy unit per class Each policy unit should implement a single file so None, Even

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: show notification of disabled policy unit

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: show notification of disabled policy unit .. webadmin: show notification of disabled policy unit When the external scheduler doesn't load an already l

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix for scheduling cluster custom properties

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: fix for scheduling cluster custom properties .. core: fix for scheduling cluster custom properties problem: when adding scheduling custom property to a cl

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fix Filters text syntax

2013-08-26 Thread gchaplik
Hello Doron Fediuck, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18575 to review the following change. Change subject: webadmin: Fix Filters text syntax .. webadmin: Fix Filters text syntax Min

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: sort cluster policy list

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: sort cluster policy list .. webadmin: sort cluster policy list first order cluster policies by pre-defined then lexicographically. Change-Id: I46c5de

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: remove migration domain filter

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: scheduling: remove migration domain filter .. core: scheduling: remove migration domain filter Currently there is on way to migrate a vm between clusters,

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: searchbackend: search host by id

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: engine: searchbackend: search host by id .. engine: searchbackend: search host by id 'id' isn't propmpt in the ui search bar, but is acceptable. Change-Id: I07

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: start discovery thread only if enabled

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18557 to review the following change. Change subject: engine: start discovery thread only if enabled .. engine: start discovery

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: don't run externl scheduler on !empty data

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: scheduling: don't run externl scheduler on !empty data .. core: scheduling: don't run externl scheduler on !empty data * Cluster policy contains external

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engien: test for ClusterPolicyCRUDCommandTest

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18574 to review the following change. Change subject: engien: test for ClusterPolicyCRUDCommandTest .. engien: test for ClusterP

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: handle unavailable external scheduler

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18558 to review the following change. Change subject: engine: handle unavailable external scheduler .. engine: handle unavailabl

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: add response timeout

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18559 to review the following change. Change subject: engine: add response timeout .. engine: add response timeout Make respons

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Prevent implicit usage of port mirroring .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: pre-defined weight modules

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: pre-defined weight modules .. core: pre-defined weight modules To be compatible with former scheduler. * none -> should use evenly distributed * even dist

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fix Filters text syntax

2013-08-26 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: webadmin: Fix Filters text syntax .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18575 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: sort cluster policy list

2013-08-26 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: sort cluster policy list .. Patch Set 1: * Tracker #994719: OK * Set POST #994719: FAILED, ilegal change from ON_QA -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fix Filters text syntax

2013-08-26 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: webadmin: Fix Filters text syntax .. Patch Set 1: * Tracker #1000871: OK * Set POST #1000871: FAILED, ilegal change from VERIFIED -- To view, visit http

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: remove migration domain filter

2013-08-26 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: core: scheduling: remove migration domain filter .. Patch Set 1: * Tracker #988306: OK * Set POST #988306: FAILED, ilegal change from ON_QA -- To view,

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: custom properties sheet: tooltip for key

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: custom properties sheet: tooltip for key .. webadmin: custom properties sheet: tooltip for key Show tool-tip for selected key, when hovering on keys d

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: policy unit crud store proc

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: policy unit crud store proc .. core: policy unit crud store proc Insert and Update policy unit db store procedures with tests Change-Id: I8838ae56c2ed927

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: cluster policy dialog - minor fixes

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: cluster policy dialog - minor fixes .. webadmin: cluster policy dialog - minor fixes * Adding abillity to filter to have no position. * Fixing dnd not

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: scheduler: handle external scheduler parameters

2013-08-26 Thread gchaplik
Hello Noam Slomianko, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18570 to review the following change. Change subject: core: scheduler: handle external scheduler parameters .. core: scheduler:

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: scheduler: change parameter map type

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: scheduler: change parameter map type .. core: scheduler: change parameter map type The external scheduler is now expecting a string map with vm id instead

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: webadmin: scheduling: indication for external plugin

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: scheduling: indication for external plugin .. webadmin: scheduling: indication for external plugin the text '(EXT)' will be added next to each module

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: AddClusterPolicyCommand canDoAction simplification

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18572 to review the following change. Change subject: engine: AddClusterPolicyCommand canDoAction simplification .. engine: AddC

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: cluster policy: adding description and info icons

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: engine: cluster policy: adding description and info icons .. engine: cluster policy: adding description and info icons * A description field is added to each pr

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: EditClusterPolicyCommand simplification

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18573 to review the following change. Change subject: engine: EditClusterPolicyCommand simplification .. engine: EditClusterPoli

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: initialize scheduling manager from InitBackendServic...

2013-08-26 Thread gchaplik
Hello Laszlo Hornyak, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18556 to review the following change. Change subject: engine: initialize scheduling manager from InitBackendServicesOnStartupBean ..

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: scheduling: handle external scheduler failure

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: scheduling: handle external scheduler failure .. core: scheduling: handle external scheduler failure in case the external scheduler fails, continue with s

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: add enabled column to policy_units

2013-08-26 Thread gchaplik
Hello Noam Slomianko, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/18553 to review the following change. Change subject: engine: add enabled column to policy_units .. engine: add enabled column t

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: policy unit should contain single logic

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: engine: policy unit should contain single logic .. engine: policy unit should contain single logic Utill now policy unit could hold logic for filtering, weighin

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fixing findbugs errors

2013-08-26 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: core: fixing findbugs errors .. core: fixing findbugs errors * fixing wrong caching * no refernce to field Change-Id: Iad6f990d93bfdc5bfbd7179cffee4893ef40ccc5

[Engine-patches] Change in ovirt-engine[master]: core: rename methods to start with lowercase

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: rename methods to start with lowercase .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: core: rename methods to start with lowercase

2013-08-26 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: rename methods to start with lowercase .. Patch Set 1: Verified+1 compilation and unitests -- To view, visit http://gerrit.ovirt.org/18546 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: lock VM for whole live disk migration process

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: lock VM for whole live disk migration process .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_

[Engine-patches] Change in ovirt-engine[master]: core: rename methods to start with lowercase

2013-08-26 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: core: rename methods to start with lowercase .. core: rename methods to start with lowercase Findbugs cleanup. Renamed methods to start with lowercase and remove

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring

2013-08-26 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Prevent implicit usage of port mirroring .. engine: Prevent implicit usage of port mirroring The patch denies attempt of an imported vm to use a vnic prof

[Engine-patches] Change in ovirt-engine[master]: engine: Consider case-sensitivity for mac-address uniqueness

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Consider case-sensitivity for mac-address uniqueness .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compil

[Engine-patches] Change in ovirt-engine[master]: restapi: Allow untagging a network with vlan-id

2013-08-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Allow untagging a network with vlan-id .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: core: lock VM for whole live disk migration process

2013-08-26 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: core: lock VM for whole live disk migration process .. core: lock VM for whole live disk migration process In order to prevent a race between VM migration and stor

[Engine-patches] Change in ovirt-engine[master]: restapi: Allow untagging a network with vlan-id

2013-08-26 Thread masayag
Moti Asayag has posted comments on this change. Change subject: restapi: Allow untagging a network with vlan-id .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18489 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: engine: Consider case-sensitivity for mac-address uniqueness

2013-08-26 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Consider case-sensitivity for mac-address uniqueness .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18490 To unsubscribe, visit http

  1   2   3   4   5   >