Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding RpmVersion utils
..
Patch Set 7: Code-Review-1
Well, we were right. Keeping my -1 until 1.3.fc18 will be newer than 1.fc18
--
To view, visit http
Ori Liel has posted comments on this change.
Change subject: restapi: Support for gluster hooks added
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18495
To unsubscribe, visit http://gerrit.ovirt.org/
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: VDS Cmd: Gluster Volume Rebalance Stop
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18442
To unsubscribe, visit http://
Shubhendu Tripathi has posted comments on this change.
Change subject: engine: BLL Command to Stop Reblance Gluster Volume task
..
Patch Set 2:
(2 comments)
File backend/ma
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Remove keys on cleanup after upgrade
..
Patch Set 1: Code-Review+1
Thanks!
--
To view, visit http://gerrit.ovirt.org/18584
To unsubscribe, vis
Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: Remove keys on cleanup after upgrade
..
packaging: setup: Remove keys on cleanup after upgrade
Remove engine_id_rsa and apache.key.nopass
Mike Kolesnik has posted comments on this change.
Change subject: sdk: implement AutoCloseable
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18538
To unsubscribe, visit http://gerrit.ovirt.org/setting
Sahina Bose has posted comments on this change.
Change subject: engine: BLL Command to Stop Reblance Gluster Volume task
..
Patch Set 2:
(6 comments)
File
backend/manager/
Lior Vernia has posted comments on this change.
Change subject: webadmin: Copy VNIC profile configuration from template
..
Patch Set 1:
(1 comment)
File
frontend/webadmin/m
Mike Kolesnik has posted comments on this change.
Change subject: engine: Consider case-sensitivity for mac-address uniqueness
..
Patch Set 2:
(2 comments)
File
backend/man
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Allow untagging a network with vlan-id
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18489
To unsubscribe, visit http://gerri
Mike Kolesnik has posted comments on this change.
Change subject: engine: Remove unused code
..
Patch Set 1:
(4 comments)
Nice cleanup, it can be a bit more extensive while you're at it..
.
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Validate vm nic name has no special characters
..
core: Validate vm nic name has no special characters
The patch validates the vm nic name is cons
Mike Kolesnik has posted comments on this change.
Change subject: core: Validate vm nic name has no special characters
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18487
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: frontend: node upgrade message improvement
..
Patch Set 10:
Douglas, thanks.
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://ger
Douglas Schilling Landgraf has posted comments on this change.
Change subject: core: Adding RpmVersion utils
..
Patch Set 7: Code-Review+1
The same thought as Yaniv, except that point it's good.
--
To view, visit http://gerri
Douglas Schilling Landgraf has posted comments on this change.
Change subject: frontend: node upgrade message improvement
..
Patch Set 10:
Yair, my second example was between 2.6.0 and 2.6.1 and it worked, it was typo.
--
To
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding RpmVersion utils
..
Patch Set 7: Code-Review+1
odd, but except that, all good to go..
--
To view, visit http://gerrit.ovirt.org/18370
To unsubscr
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding RpmVersion utils
..
Patch Set 7: Code-Review+1
(1 comment)
File
backend/manager/modules/comm
Alissa Bonas has posted comments on this change.
Change subject: core: rename methods to start with lowercase
..
Patch Set 1:
(1 comment)
File
backend/manager/modules/bll/s
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adding RpmVersion utils
..
Patch Set 7: Code-Review-1
(1 comment)
File
backend/manager/modules/comm
Ravi Nori has posted comments on this change.
Change subject: core: Improve CommandsFactory exception logging
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18141
To unsubscribe, visit http://gerrit.ov
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: update otopi, ovirt-host-deploy to release
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18582
To unsubscribe, visit http://ger
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: update otopi, ovirt-host-deploy to release
..
packaging: update otopi, ovirt-host-deploy to release
Change-Id: Ib7a8e7c95feb31103ee75ed57a69e5f732e251
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: ovirt-host-deploy-1.1.0
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18580
To unsubscribe, visit http://gerrit.o
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.1.0
..
packaging: post ovirt-host-deploy-1.1.0
Change-Id: Id3beb9acda5b64fcfb3fbebcdb257b6a35f6c434
Signed-off-by: Al
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post ovirt-host-deploy-1.1.0
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18581
To unsubscribe, visit http://ger
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.1.0
..
packaging: ovirt-host-deploy-1.1.0
Change-Id: I068cbf1bd0c467deeace0564c03d47e4d9f93d06
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: ovirt-host-deploy-1.1.0
..
packaging: ovirt-host-deploy-1.1.0
Change-Id: I068cbf1bd0c467deeace0564c03d47e4d9f93d06
Signed-off-by: Alon Bar-Lev
---
M
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post ovirt-host-deploy-1.1.0
..
packaging: post ovirt-host-deploy-1.1.0
Change-Id: Id3beb9acda5b64fcfb3fbebcdb257b6a35f6c434
Signed-off-by: Alon Bar-L
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: post otopi-1.1.0
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18579
To unsubscribe, visit http://gerrit.ovirt.or
Yair Zaslavsky has posted comments on this change.
Change subject: core: user who added external events does not...
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17924
To unsubscribe, visit http://ger
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post otopi-1.1.0
..
packaging: post otopi-1.1.0
Change-Id: I326d69a7f54007cf7e107736a61ac53be94fe2e4
Signed-off-by: Alon Bar-Lev
---
M config
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: otopi-1.1.0
..
packaging: otopi-1.1.0
Change-Id: Ifec09b6579efabe257a5620b50bcdc76f831de1c
Signed-off-by: Alon Bar-Lev
---
M configure.ac
M o
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: otopi-1.1.0
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18578
To unsubscribe, visit http://gerrit.ovirt.org/set
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: post otopi-1.1.0
..
packaging: post otopi-1.1.0
Change-Id: I326d69a7f54007cf7e107736a61ac53be94fe2e4
Signed-off-by: Alon Bar-Lev
---
M configure.ac
1
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: otopi-1.1.0
..
packaging: otopi-1.1.0
Change-Id: Ifec09b6579efabe257a5620b50bcdc76f831de1c
Signed-off-by: Alon Bar-Lev
---
M configure.ac
M otopi.spe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: node upgrade message improvement
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger
Douglas Schilling Landgraf has posted comments on this change.
Change subject: backend: GetoVirtISOsQuery use RpmVersionUtils
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/18435
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: frontend: node upgrade message improvement
..
Patch Set 10:
Followed all comments
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: backend: GetoVirtISOsQuery use RpmVersionUtils
..
Patch Set 7: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18435
To unsubscribe, visit h
Ravi Nori has posted comments on this change.
Change subject: cli: bogous 'help show event' output
..
Patch Set 1:
(1 comment)
File src/ovirtcli/utils/methodhelper.py
Line 1
Douglas Schilling Landgraf has posted comments on this change.
Change subject: frontend: node upgrade message improvement
..
Patch Set 9:
(1 comment)
File
frontend/webadmi
Yaniv Bronhaim has posted comments on this change.
Change subject: frontend: node upgrade message improvement
..
Patch Set 9:
(3 comments)
File
frontend/webadmin/modules/u
Douglas Schilling Landgraf has posted comments on this change.
Change subject: core: Adding RpmVersion utils
..
Patch Set 7:
(3 comments)
File
backend/manager/modules/commo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi : add descriptions to rsdl
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7158/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi : add descriptions to rsdl
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7157/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi : add descriptions to rsdl
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7156/
Ravi Nori has posted comments on this change.
Change subject: restapi : add descriptions to rsdl
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/18576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ravi Nori has uploaded a new change for review.
Change subject: restapi : add descriptions to rsdl
..
restapi : add descriptions to rsdl
Add descriptions to rsdl. This patch fixes the issue
where descriptions where not displayed
Tal Nisan has posted comments on this change.
Change subject: core: rename methods to start with lowercase
..
Patch Set 1: Code-Review+1
(1 comment)
File
backend/manager/mo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: frontend: Control virtio rng device
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7154/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: backend: Control virtio rng device
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7155/
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18555
to review the following change.
Change subject: engine: external scheduler integration
..
engine: external scheduler integ
Moti Asayag has posted comments on this change.
Change subject: engine: Prevent implicit usage of port mirroring
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/18547
To unsubscribe, visit http://gerrit.ov
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: lock VM for whole live disk migration process
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst
Frank Kobzik has posted comments on this change.
Change subject: backend: Control virtio rng device
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/18176
To unsubscribe, visit http://gerrit.ovirt.org/setti
Frank Kobzik has posted comments on this change.
Change subject: frontend: Control virtio rng device
..
Patch Set 2: Verified+1
addressed comments from #1
--
To view, visit http://gerrit.ovirt.org/18497
To unsubscribe, visit
Gilad Chaplik has uploaded a new change for review.
Change subject: core: scheduler: separate policy unit per class
..
core: scheduler: separate policy unit per class
Each policy unit should implement a single file so
None, Even
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: show notification of disabled policy unit
..
webadmin: show notification of disabled policy unit
When the external scheduler doesn't load an already l
Gilad Chaplik has uploaded a new change for review.
Change subject: core: fix for scheduling cluster custom properties
..
core: fix for scheduling cluster custom properties
problem: when adding scheduling custom property to a cl
Hello Doron Fediuck,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18575
to review the following change.
Change subject: webadmin: Fix Filters text syntax
..
webadmin: Fix Filters text syntax
Min
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: sort cluster policy list
..
webadmin: sort cluster policy list
first order cluster policies by pre-defined then lexicographically.
Change-Id: I46c5de
Gilad Chaplik has uploaded a new change for review.
Change subject: core: scheduling: remove migration domain filter
..
core: scheduling: remove migration domain filter
Currently there is on way to migrate a vm between clusters,
Gilad Chaplik has uploaded a new change for review.
Change subject: engine: searchbackend: search host by id
..
engine: searchbackend: search host by id
'id' isn't propmpt in the ui search bar, but is acceptable.
Change-Id: I07
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18557
to review the following change.
Change subject: engine: start discovery thread only if enabled
..
engine: start discovery
Gilad Chaplik has uploaded a new change for review.
Change subject: core: scheduling: don't run externl scheduler on !empty data
..
core: scheduling: don't run externl scheduler on !empty data
* Cluster policy contains external
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18574
to review the following change.
Change subject: engien: test for ClusterPolicyCRUDCommandTest
..
engien: test for ClusterP
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18558
to review the following change.
Change subject: engine: handle unavailable external scheduler
..
engine: handle unavailabl
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18559
to review the following change.
Change subject: engine: add response timeout
..
engine: add response timeout
Make respons
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Prevent implicit usage of port mirroring
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle
Gilad Chaplik has uploaded a new change for review.
Change subject: core: pre-defined weight modules
..
core: pre-defined weight modules
To be compatible with former scheduler.
* none -> should use evenly distributed
* even dist
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Fix Filters text syntax
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/18575
To unsubscribe, visit http://gerrit.ovirt.org/se
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: sort cluster policy list
..
Patch Set 1:
* Tracker #994719: OK
* Set POST #994719: FAILED, ilegal change from ON_QA
--
To view, visit http://g
automat...@ovirt.org has posted comments on this change.
Change subject: webadmin: Fix Filters text syntax
..
Patch Set 1:
* Tracker #1000871: OK
* Set POST #1000871: FAILED, ilegal change from VERIFIED
--
To view, visit http
automat...@ovirt.org has posted comments on this change.
Change subject: core: scheduling: remove migration domain filter
..
Patch Set 1:
* Tracker #988306: OK
* Set POST #988306: FAILED, ilegal change from ON_QA
--
To view,
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: custom properties sheet: tooltip for key
..
webadmin: custom properties sheet: tooltip for key
Show tool-tip for selected key, when hovering on keys d
Gilad Chaplik has uploaded a new change for review.
Change subject: core: policy unit crud store proc
..
core: policy unit crud store proc
Insert and Update policy unit db store procedures with tests
Change-Id: I8838ae56c2ed927
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: cluster policy dialog - minor fixes
..
webadmin: cluster policy dialog - minor fixes
* Adding abillity to filter to have no position.
* Fixing dnd not
Hello Noam Slomianko,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18570
to review the following change.
Change subject: core: scheduler: handle external scheduler parameters
..
core: scheduler:
Gilad Chaplik has uploaded a new change for review.
Change subject: core: scheduler: change parameter map type
..
core: scheduler: change parameter map type
The external scheduler is now expecting a string map with vm id instead
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: scheduling: indication for external plugin
..
webadmin: scheduling: indication for external plugin
the text '(EXT)' will be added next to each module
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18572
to review the following change.
Change subject: engine: AddClusterPolicyCommand canDoAction simplification
..
engine: AddC
Gilad Chaplik has uploaded a new change for review.
Change subject: engine: cluster policy: adding description and info icons
..
engine: cluster policy: adding description and info icons
* A description field is added to each pr
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18573
to review the following change.
Change subject: engine: EditClusterPolicyCommand simplification
..
engine: EditClusterPoli
Hello Laszlo Hornyak,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18556
to review the following change.
Change subject: engine: initialize scheduling manager from
InitBackendServicesOnStartupBean
..
Gilad Chaplik has uploaded a new change for review.
Change subject: core: scheduling: handle external scheduler failure
..
core: scheduling: handle external scheduler failure
in case the external scheduler fails, continue with s
Hello Noam Slomianko,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/18553
to review the following change.
Change subject: engine: add enabled column to policy_units
..
engine: add enabled column t
Gilad Chaplik has uploaded a new change for review.
Change subject: engine: policy unit should contain single logic
..
engine: policy unit should contain single logic
Utill now policy unit could hold logic for filtering, weighin
Gilad Chaplik has uploaded a new change for review.
Change subject: core: fixing findbugs errors
..
core: fixing findbugs errors
* fixing wrong caching
* no refernce to field
Change-Id: Iad6f990d93bfdc5bfbd7179cffee4893ef40ccc5
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename methods to start with lowercase
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger
Alissa Bonas has posted comments on this change.
Change subject: core: rename methods to start with lowercase
..
Patch Set 1: Verified+1
compilation and unitests
--
To view, visit http://gerrit.ovirt.org/18546
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: lock VM for whole live disk migration process
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename methods to start with lowercase
..
core: rename methods to start with lowercase
Findbugs cleanup. Renamed methods to start with lowercase and
remove
Moti Asayag has uploaded a new change for review.
Change subject: engine: Prevent implicit usage of port mirroring
..
engine: Prevent implicit usage of port mirroring
The patch denies attempt of an imported vm to use
a vnic prof
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Consider case-sensitivity for mac-address uniqueness
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compil
oVirt Jenkins CI Server has posted comments on this change.
Change subject: restapi: Allow untagging a network with vlan-id
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_
Arik Hadas has uploaded a new change for review.
Change subject: core: lock VM for whole live disk migration process
..
core: lock VM for whole live disk migration process
In order to prevent a race between VM migration and stor
Moti Asayag has posted comments on this change.
Change subject: restapi: Allow untagging a network with vlan-id
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18489
To unsubscribe, visit http://gerrit.ovi
Moti Asayag has posted comments on this change.
Change subject: engine: Consider case-sensitivity for mac-address uniqueness
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/18490
To unsubscribe, visit http
1 - 100 of 454 matches
Mail list logo