Tal Nisan has posted comments on this change.
Change subject: core: rename methods to start with lowercase
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
Line 111: VdcActionType.AddImageFromScratch,
Line 112: tempVar,
Line 113:
ExecutionHandler.createDefaultContexForTasks(getExecutionContext()));
Line 114: if (!tmpRetValue.getSucceeded()) {
Line 115: log.error("concreteAddVmImages:
AddImageFromScratch Command failed.");
Are you sure this should be removed from the log?
Line 116: ret = false;
Line 117: }
Line 118:
Line 119: else // the AddImageFromScratch task created ended
successfully:
--
To view, visit http://gerrit.ovirt.org/18546
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3d77789be17e90f63c734dba3365c0178326029
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
