Douglas Schilling Landgraf has posted comments on this change.
Change subject: frontend: node upgrade message improvement
......................................................................
Patch Set 9:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 689: }
Line 690:
Line 691: String rpmFromIso = iso.getRpmName();
Line 692: // Removes the ".iso" file extension , and get the
release part from it
Line 693: int isoIndex = iso.getRpmName().indexOf(".iso");
//$NON-NLS-1$
better replace int isoIndex = iso.getRpmName() to isoIndex =
rpmFromIso.getRpmName()
Line 694: if (isoIndex != -1) {
Line 695: rpmFromIso = iso.getRpmName().substring(0,
isoIndex);
Line 696: }
Line 697: if
(RpmVersionUtils.compareRpmPart(RpmVersionUtils.splitRpmToParts(rpmFromIso)[2],
release_host) > 0) {
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@gmail.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
