[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: initialize scheduling manager from InitBackendServic...

[gchaplik]

Hello Laszlo Hornyak,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/18556

to review the following change.

Change subject: engine: initialize scheduling manager from 
InitBackendServicesOnStartupBean
......................................................................

engine: initialize scheduling manager from InitBackendServicesOnStartupBean

Schedling manager initialize made public, call removed from constructor
and added to InitBackendServicesOnStartupBean. Additional logging for
better tracing.

Change-Id: Ic74d28c2aa9700527f6217f4de2a2b4527286317
Signed-off-by: Laszlo Hornyak <lhorn...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/18556/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
index d12875d..7431c1d 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
@@ -85,6 +85,8 @@
         } catch (InitializationException e) {
             log.error("Initialization of device custom properties failed.",e);
         }
+
+        SchedulingManager.getInstance().init();
     }
 
 }
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
index b405476..c11aa90 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
@@ -76,15 +76,15 @@
     private SchedulingManager() {
         policyMap = new ConcurrentHashMap<Guid, ClusterPolicy>();
         policyUnits = new ConcurrentHashMap<Guid, PolicyUnitImpl>();
-
-        init();
     }
 
-    private void init() {
+    public void init() {
+        log.info("Initializing Scheduling manager");
         loadPolicyUnits();
         loadClusterPolicies();
         ExternalSchedulerDiscoveryThread discoveryThread = new 
ExternalSchedulerDiscoveryThread();
         discoveryThread.start();
+        log.info("Initialized Scheduling manager");
     }
 
     public void reloadPolicyUnits() {


-- 
To view, visit http://gerrit.ovirt.org/18556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic74d28c2aa9700527f6217f4de2a2b4527286317
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches