[Engine-patches] Change in ovirt-engine[master]: restapi: cloud-init [6/6] - rest api for start vm

2013-07-09 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: restapi: cloud-init [6/6] - rest api for start vm .. Patch Set 4: please fill in bug url with 619761 -- To view, visit http://gerrit.ovirt.org/15537 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: Add QoS to to DB and entities

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add QoS to to DB and entities .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/873/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: do not fail if /etc/exports is missing

2013-07-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: do not fail if /etc/exports is missing .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: [db] renaming wrongly named upgrade scripts.

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: [db] renaming wrongly named upgrade scripts. .. Patch Set 1: Hi, the problem is with 03_02_0390 and not 03_03_0390 -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: add branding support

2013-07-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: add branding support .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16641 To uns

[Engine-patches] Change in ovirt-engine[master]: core: Preventing host activation when host is non responsive

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Preventing host activation when host is non responsive .. Patch Set 1: Verified Patch Set 1: Verified Verified using API - http://localhost:8080/api/hosts

[Engine-patches] Change in ovirt-engine[master]: core: Fix some Error constants of Host Activation

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix some Error constants of Host Activation .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/16648 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Use VdsValidator in canDoAction of ActivateVds

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Use VdsValidator in canDoAction of ActivateVds .. Patch Set 1: Verified Verified using API - http://localhost:8080/api/hosts//activate fa

[Engine-patches] Change in ovirt-engine[master]: [wip] backend: add glance storage domain support

2013-07-09 Thread aburden
A Burden has posted comments on this change. Change subject: [wip] backend: add glance storage domain support .. Patch Set 4: (1 inline comment) Comment to suggest removal use of 'e.g.' from error .

[Engine-patches] Change in ovirt-engine[master]: tools: typo fix

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: typo fix .. Patch Set 4: Looks good to me, approved Laszlo, please deatch from the rest of the patchset so I can merge -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: also start cgconfig if available

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: also start cgconfig if available .. vdsm: packages: also start cgconfig if available Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: also start cgconfig if available

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: packages: also start cgconfig if available .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16204 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: tools: typo fix

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: typo fix .. Patch Set 4: Looks good to me, but someone else must approve yeah... sorry about that! -- To view, visit http://gerrit.ovirt.org/16623 To uns

[Engine-patches] Change in ovirt-engine[master]: packaging: services: websocket-proxy: supress stdout on sysv

2013-07-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: services: websocket-proxy: supress stdout on sysv .. Patch Set 1: > Because there is no log, it just print of messages, and in systemd it will go

[Engine-patches] Change in ovirt-engine[master]: core: [db] renaming wrongly named upgrade scripts.

2013-07-09 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: core: [db] renaming wrongly named upgrade scripts. .. Patch Set 1: Yair - are you sure you are on master? Two days ago 16035 was committed, which included

[Engine-patches] Change in ovirt-engine[master]: core: Use VdsValidator in canDoAction of ActivateVds

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Use VdsValidator in canDoAction of ActivateVds .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

[Engine-patches] Change in ovirt-engine[master]: core: Fix some Error constants of Host Activation

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix some Error constants of Host Activation .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyl

[Engine-patches] Change in ovirt-engine[master]: core: Use VdsValidator in canDoAction of ActivateVds

2013-07-09 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Use VdsValidator in canDoAction of ActivateVds .. core: Use VdsValidator in canDoAction of ActivateVds Introduce usage of VdsValidator to ActivateVds (as

[Engine-patches] Change in ovirt-engine[master]: core: Fix some Error constants of Host Activation

2013-07-09 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fix some Error constants of Host Activation .. core: Fix some Error constants of Host Activation There is no reason the ACTIVATE word will be part of the

[Engine-patches] Change in ovirt-engine[master]: core: Preventing host activation when host is non responsive

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Preventing host activation when host is non responsive .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_comp

[Engine-patches] Change in ovirt-engine[master]: core: Preventing host activation when host is non responsive

2013-07-09 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Preventing host activation when host is non responsive .. core: Preventing host activation when host is non responsive The following introduces proper er

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1353 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1353/ Build Number: 1353 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: Enable virtual drive size extension

2013-07-09 Thread liron . aravot
liron aravot has posted comments on this change. Change subject: backend,webadmin: Enable virtual drive size extension .. Patch Set 13: (4 inline comments) partial review..will continue. ...

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1352 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1352/ Build Number: 1352 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1351 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1351/ Build Number: 1351 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1350 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1350/ Build Number: 1350 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1349 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1349/ Build Number: 1349 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-host-deploy[master]: vdsm: packages: also start cgconfig if available

2013-07-09 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm: packages: also start cgconfig if available .. Patch Set 2: (1 inline comment) Patch verified, it works. Just a comment about changelog. .

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1348 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1348/ Build Number: 1348 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: core: Fix logging in SshSoftFencingCommand

2013-07-09 Thread mperina
Martin Peřina has abandoned this change. Change subject: core: Fix logging in SshSoftFencingCommand .. Patch Set 1: Abandoned Patch is not needed, because breaking change has been reverted -- To view, visit http://gerrit.ovir

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1347 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1347/ Build Number: 1347 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1346 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1346/ Build Number: 1346 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: tools: typo fix

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: typo fix .. Patch Set 4: Please detach it from your work on watchdog - although you probably encountered it during your work on the feature, it is relev

[Engine-patches] Change in ovirt-engine[master]: tools: typo fix

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: typo fix .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16623 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: -1: someone fix this test

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: -1: someone fix this test .. Patch Set 7: I would prefer that you didn't submit this I rebased against 7733620ced4e7adf6a9ad05b2650cad385ce71fb And ran the test

[Engine-patches] [oVirt Jenkins] vdsm_verify_error_codes - Build # 1345 - Failure!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/ Build: http://jenkins.ovirt.org/job/vdsm_verify_error_codes/1345/ Build Number: 1345 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: core: [db] renaming wrongly named upgrade scripts.

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: [db] renaming wrongly named upgrade scripts. .. Patch Set 1: Fails Fails - I cherry picked on master and run create_schema.sh - llegal script version num

[Engine-patches] Change in ovirt-engine[master]: core: Fixing NPE in case of endCommand failure

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fixing NPE in case of endCommand failure .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: packaging: services: websocket-proxy: supress stdout on sysv

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: services: websocket-proxy: supress stdout on sysv .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/16631 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: add branding support

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: add branding support .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/16641 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: Add the ability to create a dummy task in case of VDSM...

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Add the ability to create a dummy task in case of VDSM failure .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/16642 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Fixing NPE in case of endCommand failure

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing NPE in case of endCommand failure .. Patch Set 1: Verified Verified patchset by creating VM with 3 disks. Creating a snapshot, and restarting VDSM

[Engine-patches] Change in ovirt-engine[master]: core: Creating SPM task in failed state ...

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Creating SPM task in failed state ... .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/16643 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Creating SPM task in failed state ...

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Creating SPM task in failed state ... .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: core: Add the ability to create a dummy task in case of VDSM...

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add the ability to create a dummy task in case of VDSM failure .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sani

[Engine-patches] Change in ovirt-engine[master]: core: Creating SPM task in failed state ...

2013-07-09 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Creating SPM task in failed state ... .. core: Creating SPM task in failed state ... Creating SPM task in failed state in case of network error in create

[Engine-patches] Change in ovirt-engine[master]: core: Fixing NPE in case of endCommand failure

2013-07-09 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fixing NPE in case of endCommand failure .. core: Fixing NPE in case of endCommand failure This is a suggestion on how to fix an NPE in CreateAllSnapshot

[Engine-patches] Change in ovirt-engine[master]: core: Add the ability to create a dummy task in case of VDSM...

2013-07-09 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Add the ability to create a dummy task in case of VDSM failure .. core: Add the ability to create a dummy task in case of VDSM failure The following pat

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: add branding support

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: add branding support .. packaging: setup: add branding support Change-Id: I2ad442ed67d7c89625791961285adfc66c008358 Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in ovirt-engine[master]: host-deploy: supress tar timestamp warnings

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: host-deploy: supress tar timestamp warnings .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerr

[Engine-patches] Change in ovirt-engine[master]: core: [db] renaming wrongly named upgrade scripts.

2013-07-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: [db] renaming wrongly named upgrade scripts. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/16639 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: host-deploy: supress tar timestamp warnings

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: host-deploy: supress tar timestamp warnings .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/16640 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: host-deploy: supress tar timestamp warnings

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: host-deploy: supress tar timestamp warnings .. host-deploy: supress tar timestamp warnings Change-Id: I0b5313dd1fd5840afebf1ceeb4673ca9e3a0831e Signed-off-by: Al

[Engine-patches] Change in ovirt-engine[master]: core: [db] renaming wrongly named upgrade scripts.

2013-07-09 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core: [db] renaming wrongly named upgrade scripts. .. core: [db] renaming wrongly named upgrade scripts. Those scripts represents two features available only to 3.

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: Enable virtual drive size extension

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: backend,webadmin: Enable virtual drive size extension .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: Enable virtual drive size extension

2013-07-09 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: backend,webadmin: Enable virtual drive size extension .. Patch Set 13: Verified Small UI change - remove "Extend Size By" input field instead of disable when th

[Engine-patches] Change in ovirt-engine[master]: packaging: services: websocket-proxy: supress stdout on sysv

2013-07-09 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: services: websocket-proxy: supress stdout on sysv .. Patch Set 1: Verified I've seen the output, doesn't look terribly important to me. -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: packaging: services: websocket-proxy: supress stdout on sysv

2013-07-09 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: services: websocket-proxy: supress stdout on sysv .. Patch Set 1: No score; Looks good to me, but someone else must approve -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: add feedback image to webadmin

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: webadmin: add feedback image to webadmin .. Patch Set 7: Looks good to me, but someone else must approve Thanks! -- To view, visit http://gerrit.ovirt.org/15984

[Engine-patches] Change in ovirt-engine[master]: core, restapi: cloud-init [2/6] - custom volume id in VM Pay...

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, restapi: cloud-init [2/6] - custom volume id in VM Payload .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_co

[Engine-patches] Change in ovirt-engine[master]: core, restapi: cloud-init [1/6] - multiple files in VM Paylo...

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, restapi: cloud-init [1/6] - multiple files in VM Payload .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_comp

[Engine-patches] Change in ovirt-engine[master]: webadmin: cloud-init [4/6] - hostname validation class

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: cloud-init [4/6] - hostname validation class .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: core, restapi, webadmin, userportal: cloud-init [3/6] - back...

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_com

[Engine-patches] Change in ovirt-engine[master]: restapi: cloud-init [6/6] - rest api for start vm

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: cloud-init [6/6] - rest api for start vm .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyl

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: cloud-init [5/6] - add to run vm once ...

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin, userportal: cloud-init [5/6] - add to run vm once dialog .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity

[Engine-patches] Change in ovirt-engine[master]: webadmin: add feedback image to webadmin

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add feedback image to webadmin .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/

[Engine-patches] Change in ovirt-engine[master]: webadmin: add feedback image to webadmin

2013-07-09 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: add feedback image to webadmin .. Patch Set 7: Verified Created expandable label that can be localized. I just need a need image with a transparent b

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: Enable virtual drive size extension

2013-07-09 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: backend,webadmin: Enable virtual drive size extension .. Patch Set 12: Verified Small UI change - remove "Extend Size By" input field instead of disable when th

[Engine-patches] Change in ovirt-engine[master]: backend, webadmin: Enable virtual drive size extension

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: backend,webadmin: Enable virtual drive size extension .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: Frontend refactor

2013-07-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: Frontend refactor .. Patch Set 6: Yeah, my comment has been addressed properly. Thanks Alex! -- To view, visit http://gerrit.ovirt.org/15399

[Engine-patches] Change in ovirt-engine[master]: engine: Dao test for cluster policy

2013-07-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: Dao test for cluster policy .. Patch Set 5: Looks good to me, but someone else must approve looks correct (however I did not test it as it is not rebase

[Engine-patches] Change in ovirt-engine[master]: common: Introduce new scheduling arch BEs

2013-07-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: common: Introduce new scheduling arch BEs .. Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: engine: cluster policy db support

2013-07-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: cluster policy db support .. Patch Set 5: (1 inline comment) File packaging/dbscripts/upgrade/03_03

[Engine-patches] Change in ovirt-engine[master]: packaging: services: websocket-proxy: supress stdout on sysv

2013-07-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: services: websocket-proxy: supress stdout on sysv .. Patch Set 1: > Just because I'm curious, why don't we keep log of this service as we do with > th

[Engine-patches] Change in ovirt-engine[master]: engine: cluster policy db support

2013-07-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: cluster policy db support .. Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: common: cluster policy fields in VDSGroup

2013-07-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: common: cluster policy fields in VDSGroup .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16108 To un

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 3788 - Fixed!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/3788/ Build Number: 3788 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 4566 - Fixed!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/4566/ Build Number: 4566 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: core: Remove IVdcUser

2013-07-09 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Remove IVdcUser .. core: Remove IVdcUser This interface only has one implementation, and there are no plans to have more so it can be removed, and that w

[Engine-patches] Change in ovirt-engine[master]: Revert SSHFingerPrint + extended auth

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Revert SSHFingerPrint + extended auth .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16637 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Remove IVdcUser

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Remove IVdcUser .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/854/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog query cleanup

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: watchdog query cleanup .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/852/ : SU

[Engine-patches] Change in ovirt-engine[master]: Revert SSHFingerPrint + extended auth

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Revert SSHFingerPrint + extended auth .. Patch Set 2: Verified Since we identified these patches as the root cause of the propblem I'm merging. -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - restapi support

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: watchdog - restapi support .. Patch Set 41: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/851/

[Engine-patches] Change in ovirt-engine[master]: -1: someone fix this test

2013-07-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: -1: someone fix this test .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/853/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Remove IVdcUser

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Remove IVdcUser .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16638 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: Revert SSHFingerPrint + extended auth

2013-07-09 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert SSHFingerPrint + extended auth .. Revert SSHFingerPrint + extended auth This reverts all the work that is done on this feature. The feature is f

[Engine-patches] Change in ovirt-engine[master]: Revert SSHFingerPrint + extended auth

2013-07-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Revert SSHFingerPrint + extended auth .. Patch Set 2: Looks good to me, approved Since we identified these patches as the root cause of the propblem I'm merging

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - restapi support

2013-07-09 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - restapi support .. Patch Set 41: Verified -- To view, visit http://gerrit.ovirt.org/13060 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 3787 - Still Failing!

2013-07-09 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/3787/ Build Number: 3787 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: frontend, engine: inherit template permissions on VM creation

2013-07-09 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: frontend,engine: inherit template permissions on VM creation .. Patch Set 7: (3 inline comments) minor comments .

[Engine-patches] Change in ovirt-engine[master]: restapi: memory snapshot feature support

2013-07-09 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: restapi: memory snapshot feature support .. Patch Set 18: Verified -- To view, visit http://gerrit.ovirt.org/15687 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory option to create snapshot popup

2013-07-09 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: add memory option to create snapshot popup .. Patch Set 17: Verified -- To view, visit http://gerrit.ovirt.org/15685 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: add memory column to snapshot subtab

2013-07-09 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: add memory column to snapshot subtab .. Patch Set 17: Verified -- To view, visit http://gerrit.ovirt.org/15684 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: webadmin: preview snapshot with memory popup

2013-07-09 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: preview snapshot with memory popup .. Patch Set 18: Verified -- To view, visit http://gerrit.ovirt.org/15686 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: some cleanup in ImportVmCommand

2013-07-09 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: some cleanup in ImportVmCommand .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/16296 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core: AuditLogDirector.log(*) methods now update engine.log

2013-07-09 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: core: AuditLogDirector.log(*) methods now update engine.log .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16188 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: AuditLogDirector.log(*) methods now update engine.log

2013-07-09 Thread kroberts
Keith Robertson has submitted this change and it was merged. Change subject: core: AuditLogDirector.log(*) methods now update engine.log .. core: AuditLogDirector.log(*) methods now update engine.log Every event that appears in

[Engine-patches] Change in ovirt-engine[master]: core: AuditLogDirector.log(*) methods now update engine.log

2013-07-09 Thread sshumake
Spenser Shumaker has posted comments on this change. Change subject: core: AuditLogDirector.log(*) methods now update engine.log .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/16188 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: AuditLogDirector.log(*) methods now update engine.log

2013-07-09 Thread kroberts
Keith Robertson has posted comments on this change. Change subject: core: AuditLogDirector.log(*) methods now update engine.log .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16188 To unsu

  1   2   3   4   5   6   >