A Burden has posted comments on this change. Change subject: [wip] backend: add glance storage domain support ......................................................................
Patch Set 4: (1 inline comment) Comment to suggest removal use of 'e.g.' from error .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties Line 376: -Please remove all VMs and Templates first. Line 377: ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS=Cannot remove Data Center while there are more than one Storage Domain attached. Line 378: ERROR_CANNOT_REMOVE_STORAGE_DOMAIN_DO_FORMAT=Cannot remove Storage Domain. Data storage must be formatted after remove.\n\ Line 379: -Please verify that Format option is enabled on the Data Domain. Line 380: ERROR_CANNOT_MANAGE_STORAGE_DOMAIN=Cannot manage Storage Domain. The domain is defined externally (e.g. through a provider). Suggestion to remove 'e.g.' as it is a latin abbreviation and not universally adopted. May I suggest: "Cannot manage Storage Domain as the domain is defined externally (such as through a provider)." Line 381: ERROR_CANNOT_FORCE_REMOVE_STORAGE_POOL_WITH_VDS_NOT_IN_MAINTENANCE=Cannot ${action} ${type} while there are Hosts that are not in Maintenance mode. Line 382: ACTION_TYPE_FAILED_STORAGE_POOL_STATUS_ILLEGAL=Cannot ${action} ${type}. Unknown Data Center status. Line 383: NETWORK_BOND_NAME_EXISTS=Bond name already exists. Line 384: NETWORK_BOND_NOT_EXISTS=Bond name doesn't exist. -- To view, visit http://gerrit.ovirt.org/15897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3271b3c49907900e37560b63c8ce54d52c463a1e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: A Burden <abur...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches