Laszlo Hornyak has posted comments on this change. Change subject: common: Introduce new scheduling arch BEs ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java Line 31: * indicates whether its an internal cluster policy, that provided with the system, and can't be removed Line 32: */ Line 33: private boolean locked; Line 34: /** Line 35: * this policy will be attached to cluster in case no policy is specified Ok, so if there can be only one such policy, it would be great to have a DB constraint for it just to make sure. If no constraint then it is not guaranteed. Line 36: */ Line 37: private boolean defaultPolicy; Line 38: Line 39: /** -- To view, visit http://gerrit.ovirt.org/16107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b6946d51e55b936747c13878d4b710af0267016 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
