Laszlo Hornyak has posted comments on this change.
Change subject: engine: cluster policy db support
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java
Line 170: protected MapSqlParameterSource
createFullParametersMapper(ClusterPolicy entity) {
Line 171: return createIdParameterMapper(entity.getId())
Line 172: .addValue("name", entity.getName())
Line 173: .addValue("description", entity.getDescription())
Line 174: .addValue("is_locked", entity.isLocked())
if you are creating this from the engine, then it will never be locked as it is
a user defined ClusterPolicy. What if (paranoia) we wouldn't send it to db and
we could hardcode 'false' in the creation.
Line 175: .addValue("is_default", entity.isDefaultPolicy())
Line 176: .addValue("custom_properties",
Line 177:
SerializationFactory.getSerializer().serialize(entity.getParameterMap()));
Line 178: }
--
To view, visit http://gerrit.ovirt.org/16109
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc34c5eba1d68e0650df38053c97e5138de3dfad
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
