[Engine-patches] Change in ovirt-engine[master]: api: API to tear down VM disk after backup.

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: API to tear down VM disk after backup. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/151/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/149/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: engine : Change CreateAllSnapshotsFromVmCommand to persist a...

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Change CreateAllSnapshotsFromVmCommand to persist all placeholders .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_eng

[Engine-patches] Change in ovirt-engine[master]: core : Persist AsyncTask before submitting to vdsm

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : Persist AsyncTask before submitting to vdsm .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/147/

[Engine-patches] Change in ovirt-engine[master]: engine : Persist all async task place holders

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Persist all async task place holders .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/146/ : SUC

[Engine-patches] Change in ovirt-engine[master]: core : Distingushing between entity and vdsm task ids

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : Distingushing between entity and vdsm task ids .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/14

[Engine-patches] Change in ovirt-engine[master]: engine : Fix variable names in VdcReturnValueBase

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Fix variable names in VdcReturnValueBase .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/144/ :

[Engine-patches] Change in ovirt-engine[master]: core : Change AddVmTemplateCommand

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : Change AddVmTemplateCommand .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/143/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: core: Introducing EntityInfo class

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Introducing EntityInfo class .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/141/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: engine : Fail tasks that dont have Vdsm Id

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Fail tasks that dont have Vdsm Id .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/142/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: core: Further cleanup for for end of command coordination

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Further cleanup for for end of command coordination .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerri

[Engine-patches] Change in ovirt-engine[master]: core: Introducing "end command coordination" by command Id

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Introducing "end command coordination" by command Id .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerr

[Engine-patches] Change in ovirt-engine[master]: core: adding root command id

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: adding root command id .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/135/ : SUCCESS -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: Adding the ability to get async tasks by entity id

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adding the ability to get async tasks by entity id .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit

[Engine-patches] Change in ovirt-engine[master]: core: SPMAsyncTask - change from associatedEntities + single...

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: SPMAsyncTask - change from associatedEntities + single type to map .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/ovirt_engine

[Engine-patches] Change in ovirt-engine[master]: webadmin: add data center to MoveOrCopyDiskModel

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add data center to MoveOrCopyDiskModel .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/132/ : S

[Engine-patches] Change in ovirt-engine[master]: frontend: refactor MoveOrCopyDisk and DisksAllocation

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: frontend: refactor MoveOrCopyDisk and DisksAllocation .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/131

[Engine-patches] Change in ovirt-engine[master]: [wip] webadmin: use RepoImage items in SubTabStorageIso

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] webadmin: use RepoImage items in SubTabStorageIso .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/1

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-05-31 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 22: Verified This patch addresses Vojtechs remaining concerns. -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-05-31 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 19: (9 inline comments) File frontend/webadmin/module

[Engine-patches] Change in ovirt-engine[master]: packaging: novnc: fix spelling in comments

2013-05-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: novnc: fix spelling in comments .. Patch Set 1: Verified Thank you michal, I see this is merged already, so submitting new patch. For my defense I can

[Engine-patches] Change in ovirt-engine[master]: packaging: novnc: fix spelling in comments

2013-05-31 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: novnc: fix spelling in comments .. packaging: novnc: fix spelling in comments Change-Id: Ia64b23d491fcd4f406c1a57b4ba812b1760537c1 Signed-off-by: Alon

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: redesign of vm related dialogs

2013-05-31 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs .. Patch Set 5: @Derez: only now I fully understand your concern (I think) - I apologize that it took so long

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: redesign of vm related dialogs

2013-05-31 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: redesign of vm related dialogs .. Patch Set 5: I understand that the static header might make sense for the final dialog - with instance type

[Engine-patches] Change in ovirt-engine[master]: engine : Fail tasks that dont have Vdsm Id

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Fail tasks that dont have Vdsm Id .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/111/ : SUCCES

[Engine-patches] Change in ovirt-engine[master]: restapi: Cannot remove custom properties from a vm

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Cannot remove custom properties from a vm .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/109/

[Engine-patches] Change in ovirt-engine[master]: webadmin: add data center to MoveOrCopyDiskModel

2013-05-31 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: webadmin: add data center to MoveOrCopyDiskModel .. Patch Set 1: (7 inline comments) File frontend/we

[Engine-patches] Change in ovirt-engine[master]: packaging: remove generated file from repo

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: packaging: remove generated file from repo .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15185 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: restapi: adding custom properties to vm interface

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: adding custom properties to vm interface .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/108/ :

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/107/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmNetworkInterface

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds custom properties to VmNetworkInterface .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/106/

[Engine-patches] Change in ovirt-engine[master]: core: Changes type of VmDevice from String to enum

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Changes type of VmDevice from String to enum .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/105/ :

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding custom properties to vnic dialog

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: adding custom properties to vnic dialog .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/104/ :

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 4431 - Failure!

2013-05-31 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4431/ Build Number: 4431 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: core : Change AddVmTemplateCommand

2013-05-31 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: core : Change AddVmTemplateCommand .. core : Change AddVmTemplateCommand This patch changes AddVmTemplateCommand and its child CreateImageTemplateCommand to persist

[Engine-patches] Change in ovirt-engine[master]: novnc: support SIGTERM at websockify service

2013-05-31 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: novnc: support SIGTERM at websockify service .. Patch Set 2: (3 inline comments) File packaging/services/

[Engine-patches] Change in ovirt-engine[master]: novnc: support SIGTERM at websockify service

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: novnc: support SIGTERM at websockify service .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15201 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: novnc: support SIGTERM at websockify service

2013-05-31 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: novnc: support SIGTERM at websockify service .. novnc: support SIGTERM at websockify service Change-Id: I4062fe348c2a1a1735e932884c8011ef66720bf6 Signe

[Engine-patches] Change in ovirt-engine[master]: novnc: make sysv service executable

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: novnc: make sysv service executable .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15192 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: packaging: remove generated file from repo

2013-05-31 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: packaging: remove generated file from repo .. packaging: remove generated file from repo Change-Id: I9b63d2e28f95a2a9057d437f0a826fb8a18b77e9 Signed-of

[Engine-patches] Change in ovirt-engine[master]: novnc: use %{name} for dependency

2013-05-31 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: novnc: use %{name} for dependency .. novnc: use %{name} for dependency Change-Id: I908cbb3b24c1e767f20c1082e24db47f50610a20 Signed-off-by: Alon Bar-Lev

[Engine-patches] Change in ovirt-engine[master]: novnc: use %{name} for dependency

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: novnc: use %{name} for dependency .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15239 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: novnc: fix typo in init.d directory

2013-05-31 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: novnc: fix typo in init.d directory .. novnc: fix typo in init.d directory Change-Id: I1fc8292ac3eef922a8d875c50bd69e4fdf4f3a6f Signed-off-by: Alon Bar

[Engine-patches] Change in ovirt-engine[master]: novnc: add vim modeline

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: novnc: add vim modeline .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15200 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: novnc: fix typo in init.d directory

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: novnc: fix typo in init.d directory .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15197 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: novnc: add vim modeline

2013-05-31 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: novnc: add vim modeline .. novnc: add vim modeline Change-Id: I2ccf27b265385d0766995f82a621b9c2432234e9 Signed-off-by: Alon Bar-Lev --- M packaging/se

[Engine-patches] Change in ovirt-engine[master]: novnc: handle package config properly

2013-05-31 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: novnc: handle package config properly .. novnc: handle package config properly currently no configuration is loaded from /etc at all. Change-Id: Iece7

[Engine-patches] Change in ovirt-engine[master]: novnc: make sysv service executable

2013-05-31 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: novnc: make sysv service executable .. novnc: make sysv service executable Change-Id: I063ac1c22d883c2b5a0b492e36d896df16596346 Signed-off-by: Alon Bar

[Engine-patches] Change in ovirt-engine[master]: novnc: handle package config properly

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: novnc: handle package config properly .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15191 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: remove generated file from repo

2013-05-31 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: packaging: remove generated file from repo .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15185 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: Adds custom properties to VmDevice

2013-05-31 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Adds custom properties to VmDevice .. Patch Set 11: (23 inline comments) Custom properties has been reimplemented from String to Map in patch set 12

[Engine-patches] Change in ovirt-engine[master]: engine:Trusted Compute Pools - Open Attestation integration ...

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job

[Engine-patches] Change in ovirt-engine[master]: engine:Trusted Compute Pools - Open Attestation integration ...

2013-05-31 Thread gang . wei
Gang Wei has posted comments on this change. Change subject: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal .. Patch Set 7: (1 inline comment) fixed for comments in patchset 7 .

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-05-31 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 19: (11 inline comments) Thanks for addressing all of my comments, Alex. There are still some open comments

[Engine-patches] Change in ovirt-engine[master]: engine: Integrate SPICE-HTML5 client

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Integrate SPICE-HTML5 client .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/102/ : SUCCESS -- T

[Engine-patches] Change in ovirt-engine[master]: gluster: Reset statusconflict flag on enable/disable

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Reset statusconflict flag on enable/disable .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/101/

[Engine-patches] Change in ovirt-engine[master]: engine: Integrate SPICE-HTML5 client

2013-05-31 Thread fkobzik
Frank Kobzik has uploaded a new change for review. Change subject: engine: Integrate SPICE-HTML5 client .. engine: Integrate SPICE-HTML5 client This patch integrates SPICE-HTML5 client in the engine. It makes use of the websock

[Engine-patches] Change in ovirt-engine[master]: gluster: Reset statusconflict flag on enable/disable

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Reset statusconflict flag on enable/disable .. Patch Set 3: Incorporated Kanagaraj's comments -- To view, visit http://gerrit.ovirt.org/15242 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: novnc: support SIGTERM at websockify service

2013-05-31 Thread eedri
Eyal Edri has posted comments on this change. Change subject: novnc: support SIGTERM at websockify service .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/15201 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: novnc: add vim modeline

2013-05-31 Thread eedri
Eyal Edri has posted comments on this change. Change subject: novnc: add vim modeline .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

[Engine-patches] Change in ovirt-engine[master]: novnc: handle package config properly

2013-05-31 Thread eedri
Eyal Edri has posted comments on this change. Change subject: novnc: handle package config properly .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15191 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: novnc: make sysv service executable

2013-05-31 Thread eedri
Eyal Edri has posted comments on this change. Change subject: novnc: make sysv service executable .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15192 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: packaging: remove generated file from repo

2013-05-31 Thread eedri
Eyal Edri has posted comments on this change. Change subject: packaging: remove generated file from repo .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15185 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: tools: expose GlusterRefreshRateHooks in engine-config

2013-05-31 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: tools: expose GlusterRefreshRateHooks in engine-config .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine[master]: gluster: Reset statusconflict flag on enable/disable

2013-05-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: Reset statusconflict flag on enable/disable .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] Use OS repository intead of VmOsType

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] Use OS repository intead of VmOsType .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/100/ :

[Engine-patches] Change in ovirt-engine[master]: core: [WIP] Manage OS properties in a repository

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: [WIP] Manage OS properties in a repository .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/99/ :

[Engine-patches] Change in ovirt-engine[master]: gluster: Added query for gluster cluster service

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Added query for gluster cluster service .. Patch Set 1: (1 inline comment) File backend/manager/modu

[Engine-patches] Change in ovirt-engine[master]: gluster: Correct event log message for sync job

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Correct event log message for sync job .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15159 To

[Engine-patches] Change in ovirt-engine[master]: gluster: Gluster Sync job event log corrected

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Gluster Sync job event log corrected .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: gluster: Added queries for service list

2013-05-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: Added queries for service list .. Patch Set 5: you could remove the changes from AppErrors, as you no longer use the validation messages. -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: gluster: Added queries for service list

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Added queries for service list .. Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) Minor suggestion inline ..

[Engine-patches] Change in ovirt-engine[master]: gluster: Host detach case sync message corrected

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Host detach case sync message corrected .. Patch Set 1: (3 inline comments) File backend/manager/mod

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms - Build # 992 - Still Failing!

2013-05-31 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/992/ Build Number: 992 Build Status: Still Failing Triggered By: Started by timer - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 4429 - Fixed!

2013-05-31 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4429/ Build Number: 4429 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for RHBZ#968958 - Refactor unnecessary while loo...

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_ge

[Engine-patches] Change in ovirt-engine[master]: tools: expose GlusterRefreshRateHooks in engine-config

2013-05-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: tools: expose GlusterRefreshRateHooks in engine-config .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15

[Engine-patches] Change in ovirt-engine[master]: tools: expose GlusterRefreshRateHooks in engine-config

2013-05-31 Thread sabose
Sahina Bose has uploaded a new change for review. Change subject: tools: expose GlusterRefreshRateHooks in engine-config .. tools: expose GlusterRefreshRateHooks in engine-config Exposing Gluster hooks refresh rate in engine-con

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for RHBZ#968958 - Refactor unnecessary while loo...

2013-05-31 Thread mperina
Martin Peřina has posted comments on this change. Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: gluster: Reset statusconflict flag on enable/disable

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Reset statusconflict flag on enable/disable .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/95/

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for RHBZ#968958 - Refactor unnecessary while loo...

2013-05-31 Thread tdosek
Tomáš Došek has posted comments on this change. Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop .. Patch Set 3: (1 inline comment) File backend

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for RHBZ#968958 - Refactor unnecessary while loo...

2013-05-31 Thread tdosek
Tomáš Došek has posted comments on this change. Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop .. Patch Set 3: (1 inline comment) File backend

[Engine-patches] Change in ovirt-engine[master]: gluster: Overriding getVdsGroup in GlusterHookCommandBase

2013-05-31 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Overriding getVdsGroup in GlusterHookCommandBase .. gluster: Overriding getVdsGroup in GlusterHookCommandBase Overriding getVdsGroup in GlusterHo

[Engine-patches] Change in ovirt-engine[master]: gluster: Overriding getVdsGroup in GlusterHookCommandBase

2013-05-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: Overriding getVdsGroup in GlusterHookCommandBase .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15243 To u

[Engine-patches] Change in ovirt-engine[master]: gluster:Remove gluster hook from servers

2013-05-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster:Remove gluster hook from servers .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15153 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: gluster:Remove gluster hook from servers

2013-05-31 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: gluster:Remove gluster hook from servers .. gluster:Remove gluster hook from servers This patch adds the BLL command to remove a gluster hook from all ser

[Engine-patches] Change in ovirt-engine[master]: gluster: Add gluster hook to missing servers

2013-05-31 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: Add gluster hook to missing servers .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15093 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: gluster: Add gluster hook to missing servers

2013-05-31 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Add gluster hook to missing servers .. gluster: Add gluster hook to missing servers Add gluster hook based on engine's copy of hook content and s

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for RHBZ#968958 - Refactor unnecessary while loo...

2013-05-31 Thread mperina
Martin Peřina has posted comments on this change. Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop .. Patch Set 3: (1 inline comment) File backe

[Engine-patches] Change in ovirt-engine[master]: gluster: Add gluster hook to missing servers

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Add gluster hook to missing servers .. Patch Set 9: Verified Had missed a file in the previous commit. Resubmitted and verified -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: gluster: Add gluster hook to missing servers

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Add gluster hook to missing servers .. Patch Set 8: Verified Incorporated Shubhendu's comment and changed ActionType to ADD. -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for RHBZ#968958 - Refactor unnecessary while loo...

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_ge

[Engine-patches] Change in ovirt-engine[master]: gluster: Overriding getVdsGroup in GlusterHookCommandBase

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Overriding getVdsGroup in GlusterHookCommandBase .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15243 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: engine: Fix for RHBZ#968958 - Refactor unnecessary while loo...

2013-05-31 Thread mperina
Martin Peřina has posted comments on this change. Change subject: engine: Fix for RHBZ#968958 - Refactor unnecessary while loop .. Patch Set 2: (1 inline comment) File backe

[Engine-patches] Change in ovirt-engine[master]: gluster: Overriding getVdsGroup in GlusterHookCommandBase

2013-05-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: gluster: Overriding getVdsGroup in GlusterHookCommandBase .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15243 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: gluster:Remove gluster hook from servers

2013-05-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: gluster:Remove gluster hook from servers .. Patch Set 5: Looks good to me, approved thanks! -- To view, visit http://gerrit.ovirt.org/15153 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: gluster: Add gluster hook to missing servers

2013-05-31 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: gluster: Add gluster hook to missing servers .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15093 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: gluster: Added queries for service list

2013-05-31 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added queries for service list .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_find_bugs_gerrit/90/ : SUCCESS --

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: branding support.

2013-05-31 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: userportal, webadmin: branding support. .. Patch Set 21: alonbl: +1 -- To view, visit http://gerrit.ovirt.org/13181 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: gluster: Reset statusconflict flag on enable/disable

2013-05-31 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Reset statusconflict flag on enable/disable .. Patch Set 1: (1 inline comment) File backend/manager/

  1   2   >