Federico Simoncelli has posted comments on this change.
Change subject: webadmin: add data center to MoveOrCopyDiskModel
......................................................................
Patch Set 1: (7 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
Line 283: setWindow(model);
Line 284:
model.setTitle(ConstantsManager.getInstance().getConstants().moveDisksTitle());
Line 285: model.setHashName("move_disks"); //$NON-NLS-1$
Line 286: model.setEntity(this);
Line 287: model.setDataCenterId(disks.get(0).getStoragePoolId());
This was/is protected with the button being disable if no item is selected. If
you follow the old code there was no protection as well. Anyway it's easy to
improve the existing code adding this validation in the previous lines.
Line 288: model.init(disks);
Line 289: model.startProgress(null);
Line 290: }
Line 291:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java
Line 155: DiskImage disk);
Line 156:
Line 157: public MoveOrCopyDiskModel() {
Line 158: setDataCenter(new ListModel());
Line 159:
getDataCenter().getSelectedItemChangedEvent().addListener(this);
We're controlling this behavior with "changeable".
Line 160:
Line 161: setDisksAllocation(new DisksAllocationModel());
Line 162: getDisksAllocation().setActiveStorageDomains(new
ArrayList<StorageDomain>());
Line 163:
getDisksAllocation().setIsSourceStorageDomainNameAvailable(true);
Line 179:
Line 180: public void init(ArrayList<DiskImage> diskImages) {
Line 181: setDiskImages(diskImages);
Line 182:
Line 183: AsyncDataProvider.getDataCenterList(new AsyncQuery(this,
Done
Line 184: new INewAsyncCallback() {
Line 185: @Override
Line 186: public void onSuccess(Object target, Object
returnValue) {
Line 187: MoveOrCopyDiskModel model =
(MoveOrCopyDiskModel) target;
Line 192:
Line 193: if (getDataCenterId() != null) {
Line 194:
model.getDataCenter().setIsChangable(false);
Line 195:
Line 196: for (StoragePool i : dataCenters) {
Done
Line 197: if
(getDataCenterId().equals(i.getId())) {
Line 198:
model.getDataCenter().setSelectedItem(i);
Line 199: break;
Line 200: }
Line 193: if (getDataCenterId() != null) {
Line 194:
model.getDataCenter().setIsChangable(false);
Line 195:
Line 196: for (StoragePool i : dataCenters) {
Line 197: if
(getDataCenterId().equals(i.getId())) {
Done
Line 198:
model.getDataCenter().setSelectedItem(i);
Line 199: break;
Line 200: }
Line 201: }
Line 486: public void eventRaised(Event ev, Object sender, EventArgs args)
Line 487: {
Line 488: super.eventRaised(ev, sender, args);
Line 489:
Line 490: if (ev.matchesDefinition(selectedItemChangedEventDefinition))
Done
Line 491: {
Line 492: if (sender == getDataCenter())
Line 493: {
Line 494: dataCenter_SelectedItemChanged();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
Line 267: setWindow(model);
Line 268:
model.setTitle(ConstantsManager.getInstance().getConstants().copyDisksTitle());
Line 269: model.setHashName("copy_disk"); //$NON-NLS-1$
Line 270: model.setEntity(this);
Line 271: model.setDataCenterId(disks.get(0).getStoragePoolId());
This was/is protected with the button being disable if no item is selected. If
you follow the old code there was no protection as well. Anyway it's easy to
improve the existing code adding this validation in the previous lines.
Line 272: model.init(disks);
Line 273: model.startProgress(null);
Line 274: }
Line 275:
--
To view, visit http://gerrit.ovirt.org/14959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25bc30cab216fd978db7590cd9cc6b994c24fa65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
