Sahina Bose has posted comments on this change.
Change subject: gluster: Gluster Sync job event log corrected
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 548: // Hence it is not required to log it as a removed
option, as that would be misleading.
Line 549: if
(!GlusterConstants.OPTION_GROUP.equals(existingOption.getKey())) {
Line 550:
logUtil.logAuditMessage(fetchedVolume.getClusterId(), fetchedVolume, null,
Line 551:
AuditLogType.GLUSTER_VOLUME_OPTION_RESET_FROM_CLI,
Line 552: new HashMap<String, String>() {
Minor nit picking- can remove extra line :)
Line 553: {
Line 554: put(GlusterConstants.OPTION_KEY,
existingOption.getKey());
Line 555:
put(GlusterConstants.OPTION_VALUE, existingOption.getValue());
Line 556: }
--
To view, visit http://gerrit.ovirt.org/15172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ed05a8ef5faec8202b79fe0037482d956f3fed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
