Michael Pasternak has posted comments on this change.
Change subject: findbugs: BackendAssignedPermissionsResource is Serializable
but its superclass doesnt define an accessible void constructor
..
Patch Set 2: I would prefer t
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: change available locales
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14356
To unsubscribe, visit htt
Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: change available locales - part 2
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14357
To unsubscribe,
Einav Cohen has posted comments on this change.
Change subject: webadmin: Add splitter to Cluster General sub tab
..
Patch Set 1:
Vojtech: http://gerrit.ovirt.org/#/c/12945/ has been merged - would you like to
sent an updated
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: change available locales - part 2
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14357
To unsubscribe, visit http://gerri
Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: change available locales
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14356
To unsubscribe, visit http://gerrit.ovirt.o
Einav Cohen has uploaded a new change for review.
Change subject: userportal, webadmin: change available locales - part 2
..
userportal, webadmin: change available locales - part 2
renamed the non-English .properties files to ma
Einav Cohen has uploaded a new change for review.
Change subject: userportal, webadmin: change available locales
..
userportal, webadmin: change available locales
available locales in the GUI applications are updated to be more
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: ovirt-engine-3.2.2
..
packaging: ovirt-engine-3.2.2
updated version to 3.2.2
Change-Id: I56b6ef52d905a5914786ef1f7d9bd287d58d2288
Signed-of
Ofer Schreiber has posted comments on this change.
Change subject: packaging: ovirt-engine-3.2.2
..
Patch Set 1: Verified; Looks good to me, approved
Packaging patch
--
To view, visit http://gerrit.ovirt.org/14355
To unsubscri
Ofer Schreiber has uploaded a new change for review.
Change subject: packaging: ovirt-engine-3.2.2
..
packaging: ovirt-engine-3.2.2
updated version to 3.2.2
Change-Id: I56b6ef52d905a5914786ef1f7d9bd287d58d2288
Signed-off-by: Of
Alon Bar-Lev has posted comments on this change.
Change subject: tools: Support for POSIX and GNU long params in
engine-manage-domains
..
Patch Set 2:
Repeating my previous statement. I think this is way too complex over
abst
Ohad Basan has posted comments on this change.
Change subject: Change the code style of build.sh
..
Patch Set 5:
could you please tick verify?
--
To view, visit http://gerrit.ovirt.org/14342
To unsubscribe, visit http://gerrit
Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-service: fix environment for java
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14314
To unsu
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engine-service: fix environment for java
..
packaging: engine-service: fix environment for java
python dict.update() returns None.
Change-I
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine.conf: add quotes to selective keys
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14352
To unsubscribe, visit http://gerrit.
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: serve root customizable location resources
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14354
To unsubscribe, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: support sensitive keys
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14353
To unsubscribe, visit http://gerrit.ovirt.org/settin
Alon Bar-Lev has posted comments on this change.
Change subject: pki: move configuration from vdc_options to LocalConfig
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/14333
To unsubscribe, visit http://gerr
Eli Mesika has posted comments on this change.
Change subject: gluster: Tables, SPs and DAOs for gluster services
..
Patch Set 2: (1 inline comment)
File
backend/manager/dbs
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: engine.conf: add quotes to selective keys
..
packaging: engine.conf: add quotes to selective keys
this to support potential space within value, while
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: config: support sensitive keys
..
core: config: support sensitive keys
do not print sensitive keys' value to log.
Change-Id: I8dc10fb3eeb1cc97a03cc160133a
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: serve root customizable location resources
..
packaging: serve root customizable location resources
resources are hard coded within root's web.xml, wh
Eli Mesika has posted comments on this change.
Change subject: engine: Fixing correlationId in MultipleActionRunner
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14329
Eli Mesika has posted comments on this change.
Change subject: engine: Replacing getVds() query by getVdsStatic() query in
VDSCommands
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ge
Eli Mesika has posted comments on this change.
Change subject: engine: Removing date creation from MultipleActionsRunner
during logging
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14328
Eli Mesika has posted comments on this change.
Change subject: core : power management types are not updated
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14331
To unsubscribe, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: pki: move configuration from vdc_options to LocalConfig
..
Patch Set 3: (1 inline comment)
File backend/manag
Eli Mesika has posted comments on this change.
Change subject: engine:Sync gluster hooks
..
Patch Set 7: (1 inline comment)
File backend/manager/dbscripts/upgrade/pre_upgrade
Eli Mesika has posted comments on this change.
Change subject: pki: move configuration from vdc_options to LocalConfig
..
Patch Set 3: (1 inline comment)
File backend/manager
Greg Padgett has uploaded a new change for review.
Change subject: WIP core, restapi: cloud-init [2/4] - custom volume id in VM
Payload
..
WIP core, restapi: cloud-init [2/4] - custom volume id in VM Payload
Change required for
Greg Padgett has uploaded a new change for review.
Change subject: WIP core, restapi, webadmin: cloud-init [3/4] - backend
..
WIP core, restapi, webadmin: cloud-init [3/4] - backend
Work in progress: support using cloud-init to
Greg Padgett has uploaded a new change for review.
Change subject: WIP core, restapi: cloud-init [1/4] - multiple files in VM
Payload
..
WIP core, restapi: cloud-init [1/4] - multiple files in VM Payload
Changes required for cl
Ravi Nori has posted comments on this change.
Change subject: engine: User who has manipulate_permissions can't see other
users
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14346
To unsubscribe, visit htt
Ravi Nori has uploaded a new change for review.
Change subject: engine: User who has manipulate_permissions can't see other
users
..
engine: User who has manipulate_permissions can't see other users
Use with manipulate use perm
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 12: (1 inline comment)
File
frontend/webadmin/modules/gwt-common/
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 12: (2 inline comments)
File
frontend/webadmin/modules/gwt-common/
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 12:
Laszlo, add all enums (WDaction and WDtype) to both localization files
(currently you are missing .java file, you u
Allon Mureinik has submitted this change and it was merged.
Change subject: Revert "engine: Use isBlockDomain() where possible"
..
Revert "engine: Use isBlockDomain() where possible"
This is a partial revert of the rest parts o
Allon Mureinik has posted comments on this change.
Change subject: Revert "engine: Use isBlockDomain() where possible"
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no changes.
Ack by Michael Pasternak.
--
To v
Daniel Erez has posted comments on this change.
Change subject: webadmin: Clean up Common.gwt.xml
..
Patch Set 2:
Nice!
--
To view, visit http://gerrit.ovirt.org/14334
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove StoragePoolIsoMapDAO.update impl
..
core: Remove StoragePoolIsoMapDAO.update impl
Since the owner column was removed from StoragePoolIsoMa
Allon Mureinik has posted comments on this change.
Change subject: core: Remove StoragePoolIsoMapDAO.update impl
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, removed redundant whitespace in the commit message.
Allon Mureinik has posted comments on this change.
Change subject: core: Remove StoragePoolIsoMapDAO.update impl
..
Patch Set 2:
@Liron - we need both signatures due to implemented interfaces, compensation
mechanisms, etc.
Re
Allon Mureinik has abandoned this change.
Change subject: core: Clean up object serialization tests
..
Patch Set 2: Abandoned
Tal - thanks for the review,
Actually, Laszlo is working on a patch to completely remove
ObjectStre
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove StorageDomainOwnerType
..
core: Remove StorageDomainOwnerType
The StorageDomainOwnerType enum contains only one value ("Unknown"), and
as
Allon Mureinik has posted comments on this change.
Change subject: core: Remove StorageDomainOwnerType
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/14337
T
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed ImportCandidateTypeEnum
..
core: Removed ImportCandidateTypeEnum
The aforementioned enum is not used anywhere in the codebase, and should
Allon Mureinik has submitted this change and it was merged.
Change subject: core, webadmin: Remove TabType
..
core, webadmin: Remove TabType
The TabType enum is not used anywhere in the codebase, and thus should
be removed.
Th
Allon Mureinik has posted comments on this change.
Change subject: core: Removed ImportCandidateTypeEnum
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/14339
Allon Mureinik has posted comments on this change.
Change subject: core, webadmin: Remove TabType
..
Patch Set 3: Verified; Looks good to me, approved
Rebased, no changes.
--
To view, visit http://gerrit.ovirt.org/14335
To uns
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Clean up Common.gwt.xml
..
webadmin: Clean up Common.gwt.xml
Cleaned up Common.gwt.xml from numerous entries in order to make the
file more m
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Clean up Common.gwt.xml
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no changes
--
To view, visit http://gerrit.ovirt.org/14334
To u
Martin Beták has posted comments on this change.
Change subject: engine: Ability to assign multiple VMs from a pool to single
user
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/14005
To unsubscribe, visit
Martin Beták has posted comments on this change.
Change subject: engine: Ability to assign multiple VMs from a pool to single
user
..
Patch Set 3: (5 inline comments)
File
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 7: (1 inline comment)
File backend/manager/dbscripts/c
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
Please merge
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Alon Bar-Lev has posted comments on this change.
Change subject: core: re-support broken apache proxy
..
Patch Set 1:
who can merge this?
--
To view, visit http://gerrit.ovirt.org/14304
To unsubscribe, visit http://gerrit.ovir
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 7: (1 inline comment)
File backend/manager/dbscripts/c
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding parameters to delay fence based on host's load
..
Patch Set 3: (2 inline comments)
File
backend/man
Arik Hadas has posted comments on this change.
Change subject: userportal,webadmin: implement VM builder
..
Patch Set 8: (5 inline comments)
the comments at HaVmToVmBuilder.java & QuotaUnitToVmBuilder.java are relevant
to othe
Omer Frenkel has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 7: (1 inline comment)
File backend/manager/dbscripts/cre
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4167/
Build Number: 4167
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: Redundant nullcheck
..
findbugs: Redundant nullcheck
Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5
Signed-off-by: Shahar Havivi
---
M
Shahar Havivi has posted comments on this change.
Change subject: findbugs: Redundant nullcheck
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14326
To unsubscribe, visit http://g
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4166/
Build Number: 4166
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi:Correct rsdl for add bricks
..
restapi:Correct rsdl for add bricks
Add bricks command causes an exception in cli
when passed a collection of
Michael Pasternak has posted comments on this change.
Change subject: restapi:Correct rsdl for add bricks
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14204
To unsubscribe, visi
Sahina Bose has posted comments on this change.
Change subject: engine:Sync gluster hooks
..
Patch Set 7: (1 inline comment)
File backend/manager/dbscripts/upgrade/pre_upgrad
Tal Nisan has posted comments on this change.
Change subject: core: Removed ImportCandidateTypeEnum
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14339
To unsubscribe, visit http://gerrit.
Tal Nisan has posted comments on this change.
Change subject: core: Remove StoragePoolIsoMapDAO.update impl
..
Patch Set 2: Looks good to me, approved
For now it seems like the best solution leaving both signatures in the api
Tal Nisan has posted comments on this change.
Change subject: core: Remove StorageDomainOwnerType
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14337
To unsubscribe, visit http://gerrit.ov
Tal Nisan has posted comments on this change.
Change subject: core: Clean up object serialization tests
..
Patch Set 2:
You removed the try/catch yet the indentation stayed the same and it doesn't
fit the project format conven
Tal Nisan has posted comments on this change.
Change subject: core, webadmin: Remove TabType
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14335
To unsubscribe, visit http://gerrit.ovirt.o
Michael Pasternak has posted comments on this change.
Change subject: cli: resolve dependency resolution at build
..
Patch Set 1: Looks good to me, approved
thanks juan.
--
To view, visit http://gerrit.ovirt.org/14343
To unsub
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: resolve dependency resolution at build
..
cli: resolve dependency resolution at build
Change-Id: Ib82564bb547b0cc48081b8f2fc6c64b993644b21
Sign
Juan Hernandez has posted comments on this change.
Change subject: cli: resolve dependency resolution at build
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14343
To u
Juan Hernandez has posted comments on this change.
Change subject: cli: resolve dependency resolution at build
..
Patch Set 1: Verified
With this change the RPM can be built without having the SDK installed.
--
To view, visit
Michael Pasternak has posted comments on this change.
Change subject: restapi:Correct rsdl for add bricks
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14204
To unsubscribe, visit http://g
Alexander Wels has posted comments on this change.
Change subject: core: re-support broken apache proxy
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14304
To unsubscr
Michael Pasternak has uploaded a new change for review.
Change subject: cli: resolve dependency resolution at build
..
cli: resolve dependency resolution at build
Change-Id: Ib82564bb547b0cc48081b8f2fc6c64b993644b21
Signed-off-b
Eli Mesika has posted comments on this change.
Change subject: engine:Sync gluster hooks
..
Patch Set 7: (1 inline comment)
File backend/manager/dbscripts/upgrade/pre_upgrade
Sandro Bonazzola has posted comments on this change.
Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader
..
Patch Set 4:
Keith?
--
To view, visit http://gerrit.ovirt.org/14133
To unsubscribe, visit http://gerrit.
Kiril Nesenko has posted comments on this change.
Change subject: Change the code style of build.sh
..
Patch Set 3: (1 inline comment)
File build.sh
Line 17: if [ ! -d oVirtL
Ohad Basan has posted comments on this change.
Change subject: Change the code style of build.sh
..
Patch Set 2: (1 inline comment)
File build.sh
Line 14: mkdir oVirtLive
Sahina Bose has posted comments on this change.
Change subject: engine:Sync gluster hooks
..
Patch Set 6: (3 inline comments)
File backend/manager/dbscripts/upgrade/pre_upgra
Kiril Nesenko has uploaded a new change for review.
Change subject: Change the code style of build.sh
..
Change the code style of build.sh
Change-Id: Iffb6b46b5e1b64f16e2e77b954dd7c2251298d46
Signed-off-by: Kiril Nesenko
---
M
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 9:
Gilad, these enums should not be localized. At least I have no idea what else
i6300esb could be.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: findbugs: EndedTaskInfo defines non-serializable instance field
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.
Laszlo Hornyak has abandoned this change.
Change subject: engine: VmTemplate cleanup (3/3)
..
Patch Set 4: Abandoned
--
To view, visit http://gerrit.ovirt.org/13769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 9: (1 inline comment)
1) all enum values should be in LocalizedEnums .java + .properies files.
2) Does 3.1 (or below) VM
Laszlo Hornyak has abandoned this change.
Change subject: engine: remove ObjectStreamSerializer default constructor
..
Patch Set 5: Abandoned
yep, why not
--
To view, visit http://gerrit.ovirt.org/13947
To unsubscribe, visit h
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 5: (3 inline comments)
File
frontend/webadmin/modules/uicommonweb/
Shireesh Anjal has posted comments on this change.
Change subject: engine:Sync gluster hooks
..
Patch Set 6: Looks good to me, but someone else must approve
(3 inline comments)
Few minor comments in-line. Needs +1 from Eli for
Allon Mureinik has posted comments on this change.
Change subject: engine: remove ObjectStreamSerializer default constructor
..
Patch Set 5: Looks good to me, but someone else must approve
How about removing the class, like Mic
Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 8: (5 inline comments)
File
backend/manager/modules/bl
Michael Kublin has posted comments on this change.
Change subject: core: wip: initVdsOnUp- remove reconstruct and host status.
..
Patch Set 9: (3 inline comments)
File
backe
Sahina Bose has posted comments on this change.
Change subject: engine: Gluster hook content query
..
Patch Set 5: (4 inline comments)
File
backend/manager/modules/bll/src/m
Laszlo Hornyak has posted comments on this change.
Change subject: tools: enable unit tests
..
Patch Set 1:
Ok, thx, I will verify and merge
--
To view, visit http://gerrit.ovirt.org/14271
To unsubscribe, visit http://gerrit.o
Tal Nisan has posted comments on this change.
Change subject: webadmin: Clean up Common.gwt.xml
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14334
To unsubscribe, visit http://gerrit.ovir
1 - 100 of 137 matches
Mail list logo
