Gilad Chaplik has posted comments on this change.
Change subject: engine: watchdog - frontend
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 82: public void OnSuccess(Object target, Object returnValue) {
Line 83: UnitVmModel model = (UnitVmModel) target;
Line 84: VdcQueryReturnValue val = (VdcQueryReturnValue)
returnValue;
Line 85: @SuppressWarnings("unchecked")
Line 86: Collection<VmWatchdog> watchdogs =
(Collection<VmWatchdog>) val.getReturnValue();
see how most of AsyncDataProvider methods look like...
Line 87: for(VmWatchdog watchdog: watchdogs) {
Line 88:
model.getWatchdogAction().setEntity(watchdog.getAction());
Line 89:
model.getWatchdogModel().setEntity(watchdog.getModel());
Line 90: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 2153:
VdcReturnValueBase retVal = result1.getReturnValue();
Line 2154: if (retVal !=
null && retVal.getSucceeded())
Line 2155: {
Line 2156:
vmListModel1.Cancel();
Line 2157: }
after thinking about it a bit, this command should be part of CRUD VM.
Line 2158:
UpdateWatchdogParameters watchdogParameters = new UpdateWatchdogParameters();
Line 2159:
watchdogParameters.setVmId(getcurrentVm().getId());
Line 2160:
watchdogParameters.setAction((String) model.getWatchdogAction().getEntity());
Line 2161:
watchdogParameters.setModel((String) model.getWatchdogModel().getEntity());
Line 2192: if (returnValueBase != null &&
returnValueBase.getSucceeded())
Line 2193: {
Line 2194: vmListModel.Cancel();
Line 2195: }
Line 2196:
see my previous comment.
Line 2197: final UpdateWatchdogParameters
watchdogParameters = new UpdateWatchdogParameters();
Line 2198:
watchdogParameters.setVmId(getcurrentVm().getId());
Line 2199:
watchdogParameters.setAction((String) model.getWatchdogAction().getEntity());
Line 2200: watchdogParameters.setModel((String)
model.getWatchdogModel().getEntity());
--
To view, visit http://gerrit.ovirt.org/13059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f72fabf35d32a05a75652ced362c5bee32b8d7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
