Kiril Nesenko has posted comments on this change. Change subject: Change the code style of build.sh ......................................................................
Patch Set 3: (1 inline comment) .................................................... File build.sh Line 17: if [ ! -d oVirtLiveFiles/iso ]; then Line 18: mkdir oVirtLiveFiles/iso Line 19: fi Line 20: Line 21: mv -f *.rpm oVirtLiveFiles/rpms I guess that this line is not needed anymore, right ? Line 22: mv -f *.iso oVirtLiveFiles/iso Line 23: livecd-creator -d -v --config=kickstart/ovirt.ks --cache=/home --fslabel=ovirt-live-$(cat VERSION) > iso.log 2>&1 || notify-send "Error" -- To view, visit http://gerrit.ovirt.org/14342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffb6b46b5e1b64f16e2e77b954dd7c2251298d46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches