Michael Pasternak has posted comments on this change.

Change subject: findbugs: BackendAssignedPermissionsResource is Serializable 
but its superclass doesnt define an accessible void constructor
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-04-29 14:24:43 +0300
Line 4: Commit:     Shahar Havivi <shav...@redhat.com>
Line 5: CommitDate: 2013-04-29 14:28:03 +0300
Line 6: 
Line 7: findbugs: BackendAssignedPermissionsResource is Serializable but its 
superclass doesnt define an accessible void constructor
i don't get the reason for findbugs thinking of this class as Serializable,
it does not implemented this interface nor passed to client,

also it intentionally does not have default constructor,

please add this issue to findbugs filter instead

thanks.
Line 8: 
Line 9: Change-Id: Ic50008e0644465cd2d122ce6ddaf27de1f658ce8


--
To view, visit http://gerrit.ovirt.org/14315
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic50008e0644465cd2d122ce6ddaf27de1f658ce8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to