Daniel Erez has posted comments on this change.
Change subject: webadmin: Making VM related substabs resizable
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14253
To unsubscribe, visit htt
Alona Kaplan has posted comments on this change.
Change subject: findbugs: Redundant nullcheck
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14326
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Clean up Common.gwt.xml
..
Patch Set 1: Verified
Verified by compiling with
mvn clean install -Pgwt-admin,gwt-user
These changes save circa 3 minutes
Yair Zaslavsky has posted comments on this change.
Change subject: Adding parameters to delay fence based on host's load
..
Patch Set 3: I would prefer that you didn't submit this
There is an update section at _config.sql -
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove StorageDomainOwnerType
..
core: Remove StorageDomainOwnerType
The StorageDomainOwnerType enum contains only one value ("Unknown"), and
as such, is
Allon Mureinik has uploaded a new change for review.
Change subject: corei, webadmin: Remove TabType
..
corei, webadmin: Remove TabType
The TabType enum is not used anywhere in the codebase, and thus should
be removed.
This pat
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove StoragePoolIsoMapDAO.update impl
..
core: Remove StoragePoolIsoMapDAO.update impl
Since the owner column was removed from StoragePoolIsoMap in the
Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: Clean up Common.gwt.xml
..
webadmin: Clean up Common.gwt.xml
Cleaned up Common.gwt.xml from numerous entries in order to make the
file more maintaina
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed ImportCandidateTypeEnum
..
core: Removed ImportCandidateTypeEnum
The aforementioned enum is not used anywhere in the codebase, and should
thus be
Allon Mureinik has uploaded a new change for review.
Change subject: core: Clean up object serialization tests
..
core: Clean up object serialization tests
Cleaned up ObjectStreamSerializerTest and ObjectDeserializerTest -
there
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Making VM related substabs resizable
..
Patch Set 3: Verified
made a bit smaller - now it fits to my ntp (X x 900)
--
To view, visit http://gerrit.ovi
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4: I would prefer that you didn't submit this
Of course we can compromise on some solution - I have no desire to push my
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask
..
core: Remvoing useless AtomicInteger from EntityAsyncTask
Removing a useless Atomic intege
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14320
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14320
To unsubscr
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: Non-Boolean argument formatted as boolean
..
findbugs: Non-Boolean argument formatted as boolean
Change-Id: I82496f3ec4994a60df0706d0cf94b93b0
Shahar Havivi has posted comments on this change.
Change subject: findbugs: Non-Boolean argument formatted as boolean
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14324
To unsub
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/914/
Build Number: 914
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Eli Mesika has posted comments on this change.
Change subject: core, restapi: Don't store domain suffix in user name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1425
Eli Mesika has posted comments on this change.
Change subject: (WIP) Adding caching capabilities to database access
..
Patch Set 2: (2 inline comments)
File
backend/manager/
Alon Bar-Lev has uploaded a new change for review.
Change subject: pki: move configuration from vdc_options to LocalConfig
..
pki: move configuration from vdc_options to LocalConfig
root application serves pki resources, in orde
Alon Bar-Lev has posted comments on this change.
Change subject: core: re-support broken apache proxy
..
Patch Set 1:
Alexander?
--
To view, visit http://gerrit.ovirt.org/14304
To unsubscribe, visit http://gerrit.ovirt.org/set
Eli Mesika has submitted this change and it was merged.
Change subject: core: rhevm-upgrade creates log/helping files...
..
core: rhevm-upgrade creates log/helping files...
rhevm-upgrade creates log/helping files in /usr/share/
Eli Mesika has posted comments on this change.
Change subject: core: rhevm-upgrade creates log/helping files...
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14298
To unsubscribe
Project: http://jenkins.ovirt.org/job/ovirt_live_create_iso/
Build: http://jenkins.ovirt.org/job/ovirt_live_create_iso/79/
Build Number: 79
Build Status: Still Failing
Triggered By: Started by timer
-
Changes Since Last Success:
---
Daniel Erez has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4: I would prefer that you didn't submit this
I understand the need for code re-usage in favor of instance types dialogs.
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 7: (5 inline comments)
File backend/manager/dbscripts/
Daniel Erez has posted comments on this change.
Change subject: findbugs: Redundant nullcheck
..
Patch Set 1: Looks good to me, but someone else must approve
I agree. Though, IIRC, in this specific model it might be needed for
Allon Mureinik has posted comments on this change.
Change subject: findbugs: BackendAssignedPermissionsResource is Serializable
but its superclass doesnt define an accessible void constructor
..
Patch Set 2: Looks good to me, b
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Class define clone but not cloneable
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14313
T
Alon Bar-Lev has posted comments on this change.
Change subject: findbugs: Dead store to local variables
..
Patch Set 1: Looks good to me, but someone else must approve
+1 for TarTest.java
--
To view, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Dead store to local variables
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14318
To unsub
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Non-Boolean argument formatted as boolean
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14324
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Redundant nullcheck
..
Patch Set 1: Looks good to me, but someone else must approve
Frankly, I don't see the point in throwing an IAE in a frontend cl
Ravi Nori has posted comments on this change.
Change subject: engine: Introduction of command entity dao
..
Patch Set 6:
Applied to my latest code
rebased against ceb5666850af9531ee138a21d9d9fe84f56301de
--
To view, visit htt
Ravi Nori has posted comments on this change.
Change subject: engine: Introduction of command entity dao
..
Patch Set 5:
Applied to my latest code
rebased against ceb5666850af9531ee138a21d9d9fe84f56301de
--
To view, visit ht
Alexander Wels has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
Fixed the broken tests, and improved them from the initial patch.
--
To view, visit http://gerrit.ovirt.org/14327
To uns
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Alexander Wels has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4: Verified
It helps if I fix all the broken unit tests.
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, vi
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ServletUtilsTest.java:19:8:
Unused import - java.i
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 1:
testSendFile_PNGNoMime(org.ovirt.engine.core.utils.ServletUtilsTest) Time
elapsed: 0.009 sec <<< FAILURE!
Wanted but no
Ravi Nori has posted comments on this change.
Change subject: core : power management types are not updated
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14331
To unsubscribe, visit http://gerrit.ovirt.org/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 16: (1 inline comment)
File backend/m
Ravi Nori has uploaded a new change for review.
Change subject: core : power management types are not updated
..
core : power management types are not updated
Power management types from rest api and admin portal
dont match. The
Omer Frenkel has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 7: (5 inline comments)
File backend/manager/dbscripts/cr
Barak Azulay has posted comments on this change.
Change subject: core: rhevm-upgrade creates log/helping files...
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14298
To unsubscribe, visit
Sahina Bose has posted comments on this change.
Change subject: restapi:Correct rsdl for add bricks
..
Patch Set 4: Verified
@Michael, removed the redundant bricks qualifier for replica_count and
stripe_count
--
To view, visi
Juan Hernandez has posted comments on this change.
Change subject: core: Remove unused LDAP query types
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14330
To unsubscribe, visit http://gerrit.ovirt.org/sett
Juan Hernandez has uploaded a new change for review.
Change subject: core: Remove unused LDAP query types
..
core: Remove unused LDAP query types
The "getGroupByName" and "getGroupsByGroupNames" LDAP queries are not
used, so the
Michael Kublin has posted comments on this change.
Change subject: engine: Removing date creation from MultipleActionsRunner
during logging
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14328
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: engine: Fixing correlationId in MultipleActionRunner
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14329
To unsubscribe, visit http://gerri
Michael Kublin has uploaded a new change for review.
Change subject: engine: Removing date creation from MultipleActionsRunner
during logging
..
engine: Removing date creation from MultipleActionsRunner during logging
Removed e
Michael Kublin has uploaded a new change for review.
Change subject: engine: Fixing correlationId in MultipleActionRunner
..
engine: Fixing correlationId in MultipleActionRunner
The following patch should connect canDoAction wit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - frontend
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/13059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - DB and logic changes
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit http://gerrit.ovirt.org/s
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/13918
To unsubscribe, visit http:/
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: fix environment for java
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Ravi Nori has posted comments on this change.
Change subject: cli: Add brick operation fails from ovirt-shell(#923169)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
I agree that util class with static methods is a very bad idea.
This is not what I suggested.
I suggested to use somet
Alex Lourie has posted comments on this change.
Change subject: core: rhevm-upgrade creates log/helping files...
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14298
To
Alexander Wels has uploaded a new change for review.
Change subject: core: broken unit test
..
core: broken unit test
- Fixed a unit test that would break if a file didn't exist
in a certain environment.
Change-Id: I9d0627ea770
Eli Mesika has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 16: (2 inline comments)
File backend/ma
Omer Frenkel has posted comments on this change.
Change subject: webadmin: Correct timezone default in New/Edit VM dialog
..
Patch Set 1: (1 inline comment)
File backend/mana
Ravi Nori has posted comments on this change.
Change subject: cli: datetime.datetime object has no attribute __dict__ #957519
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Ravi Nori has posted comments on this change.
Change subject: cli: datetime.datetime object has no attribute __dict__ #957519
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Redundant nullcheck
..
findbugs: Redundant nullcheck
Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5
Signed-off-by: Shahar Havivi
---
M
fronten
Ravi Nori has posted comments on this change.
Change subject: cli: do not use preserved "type" as param name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14301
To uns
Ravi Nori has posted comments on this change.
Change subject: cli: remove pexpect dependency
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14300
To unsubscribe, visit
Ravi Nori has posted comments on this change.
Change subject: cli: normalize sdk errors
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14299
To unsubscribe, visit http:
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
Well, consider the following disadvantages of static utility methods:
- no way to use inheritance (like BaseInitSelec
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Non-Boolean argument formatted as boolean
..
findbugs: Non-Boolean argument formatted as boolean
Change-Id: I82496f3ec4994a60df0706d0cf94b93b039ed372
Martin Beták has posted comments on this change.
Change subject: webadmin: Correct timezone default in New/Edit VM dialog
..
Patch Set 1: (1 inline comment)
File backend/mana
Ravi Nori has posted comments on this change.
Change subject: cli: recognize AmbiguousQueryError as COMMAND_ERROR
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14297
T
Michael Pasternak has uploaded a new change for review.
Change subject: cli: datetime.datetime object has no attribute __dict__ #957519
..
cli: datetime.datetime object has no attribute __dict__ #957519
Change-Id: Ie26fd8e83a87d
Michael Pasternak has uploaded a new change for review.
Change subject: cli: datetime.datetime object has no attribute __dict__ #957519
..
cli: datetime.datetime object has no attribute __dict__ #957519
Change-Id: Ie26fd8e83a87d
Michael Kublin has posted comments on this change.
Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14320
To unsubscr
Michael Kublin has posted comments on this change.
Change subject: engine: Replacing getVds() query by getVdsStatic() query in
VDSCommands
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14321
To unsubscribe
Omer Frenkel has posted comments on this change.
Change subject: engine: Ability to assign multiple VMs from a pool to single
user
..
Patch Set 3: (5 inline comments)
File
Michael Kublin has uploaded a new change for review.
Change subject: engine: Replacing getVds() query by getVdsStatic() query in
VDSCommands
..
engine: Replacing getVds() query by getVdsStatic() query in VDSCommands
The followi
Yair Zaslavsky has posted comments on this change.
Change subject: Adding parameters to delay fence based on host's load
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
Please introduce config ch
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask
..
core: Remvoing useless AtomicInteger from EntityAsyncTask
Removing a useless Atomic integer that i
Noam Slomianko has uploaded a new change for review.
Change subject: engine: engine: add comment field to vm and template
..
engine: engine: add comment field to vm and template
Part of the adding a comment field to many parts o
Alona Kaplan has posted comments on this change.
Change subject: userportal,webadmin: implement VM builder
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13915
To unsub
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Dead store to local variables
..
findbugs: Dead store to local variables
Change-Id: I69f4fa8cfff6209b106914b22a2c221193a748c9
Signed-off-by: Shahar Ha
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4154/
Build Number: 4154
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4155/
Build Number: 4155
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Change default 64-bit memory limit on upgrade
..
engine: Change default 64-bit memory limit on upgrade
Changes of memory limit for 64-bit VMs by
Tomas Jelinek has posted comments on this change.
Change subject: engine: Change default 64-bit memory limit on upgrade
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14316
To unsubscribe,
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: EndedTaskInfo defines non-serializable instance field
..
findbugs: EndedTaskInfo defines non-serializable instance field
Change-Id: I41ca491586d360f06
Martin Beták has posted comments on this change.
Change subject: engine: Change default 64-bit memory limit on upgrade
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14316
To unsubscribe, visit http://gerrit
Martin Beták has uploaded a new change for review.
Change subject: engine: Change default 64-bit memory limit on upgrade
..
engine: Change default 64-bit memory limit on upgrade
Changes of memory limit for 64-bit VMs by
14dcb41a
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
I prefer to move the common code to one helper class (maybe something like the
vm behaviours classes) and not to a lot
Tomas Jelinek has posted comments on this change.
Change subject: engine: Ability to assign multiple VMs from a pool to single
user
..
Patch Set 3: Looks good to me, but someone else must approve
FE is OK
--
To view, visit ht
Daniel Erez has posted comments on this change.
Change subject: webadmin: Making VM related substabs resizable
..
Patch Set 2:
Some of the columns seem too wide for low resolutions.. On which resolution are
you verifying?
--
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: GUI support for setting the new
VmPool.maxAssignedVmsPerUser property
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/4153/
Build Number: 4153
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Juan Hernandez has posted comments on this change.
Change subject: tools: move profile to the end of the pom
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14272
To uns
Juan Hernandez has posted comments on this change.
Change subject: tools: postgres dependency
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14273
To unsubscribe, visit
Laszlo Hornyak has abandoned this change.
Change subject: engine: StoragePool cleanup [wip]
..
Patch Set 1: Abandoned
redundant with a8f536ee66ce5b41da3c1bd89d00a01276f43d5f
--
To view, visit http://gerrit.ovirt.org/13938
To u
Michael Pasternak has posted comments on this change.
Change subject: Revert "engine: Use isBlockDomain() where possible"
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14292
To unsubscribe
1 - 100 of 154 matches
Mail list logo
