Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Redundant nullcheck
......................................................................
findbugs: Redundant nullcheck
Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/14326/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
index 894c557..e0075b8 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
@@ -181,7 +181,7 @@
NetworkItemModel<?> op1 = nic1 == null ? network1 : nic1;
NetworkItemModel<?> op2 = nic2 == null ? network2 : nic2;
- if (op1 == null || (op1 == null && op2 == null)) {
+ if (op1 == null || op2 == null) {
throw new IllegalArgumentException("null Operands"); //$NON-NLS-1$
}
--
To view, visit http://gerrit.ovirt.org/14326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
