Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Dead store to local variables
......................................................................
findbugs: Dead store to local variables
Change-Id: I69f4fa8cfff6209b106914b22a2c221193a748c9
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
M
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
4 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/14318/1
diff --git
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
index b1d628d..b6f4dd4 100644
---
a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
+++
b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
@@ -166,7 +166,6 @@
private ServerResponse setUpLogoutExpectations() {
VdcReturnValueBase result =
control.createMock(VdcReturnValueBase.class);
- Principal principal = new Principal(USER, SECRET, DOMAIN);
VdcUser user = control.createMock(VdcUser.class);
expect(current.get(VdcUser.class)).andReturn(user);
expect(user.getUserId()).andReturn(GUID);
diff --git
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java
index 036bec3..615e6e1 100644
---
a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java
+++
b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java
@@ -58,7 +58,6 @@
try {
fis = new FileInputStream(fullFile);
is = new DigestInputStream(fis, fmd);
- StringBuffer content = new StringBuffer(1024);
byte buf[] = new byte[1024];
int n;
while ((n = is.read(buf)) != -1);
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
index 78130e7..c3fc8fe 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
@@ -343,8 +343,6 @@
private void GetAttachedTagsToSelectedHosts(TagListModel model)
{
- HashMap<Guid, Boolean> tags = new HashMap<Guid, Boolean>();
-
ArrayList<Guid> hostIds = new ArrayList<Guid>();
for (Object item : getSelectedItems())
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
index a6cf4a0..5931444 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
@@ -143,8 +143,6 @@
private void GetAttachedTagsToSelectedUsers(TagListModel model)
{
- HashMap<Guid, Boolean> tags = new HashMap<Guid, Boolean>();
-
ArrayList<Guid> userIds = new ArrayList<Guid>();
ArrayList<Guid> grpIds = new ArrayList<Guid>();
--
To view, visit http://gerrit.ovirt.org/14318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69f4fa8cfff6209b106914b22a2c221193a748c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
