Eli Mesika has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
......................................................................
Patch Set 16: (2 inline comments)
....................................................
File backend/manager/tools/dbutils/fkvalidator.sh
Line 36: printf "\t-u USERNAME - The admin username for the database.\n"
Line 37: printf "\t-l LOGFILE - The logfile for capturing output
(def. ${LOGFILE})\n"
Line 38: printf "\t-f - Fix the non consistent data by removing
it from DB.\n"
Line 39: printf "\t-v - Turn on verbosity
(WARNING: lots of output)\n"
Line 40: printf "\t-q - Run in a batch mode (don't ask
questions).\n"
batch=>quite
Line 41: printf "\t-h - This help text.\n"
Line 42: printf "\n"
Line 43: popd>/dev/null
Line 44: exit $ret
Line 91: # Install fkvalidator procedures
Line 92: psql -w -U ${USERNAME} -h ${SERVERNAME} -p ${PORT} -f
./fkvalidator_sp.sql ${DATABASE} > /dev/null
Line 93:
Line 94: if [ "${FIXIT}" = "true" ]; then
Line 95: if [ ! "${BATCH}" = "true" ]; then
please unify conditions
if [[ "${FIXIT}" = "true" && ! "${BATCH}" = "true" ]]; then
Line 96: echo "Caution, this operation should be used with care. Please
contact support prior to running this command"
Line 97: echo "Are you sure you want to proceed? [y/n]"
Line 98: read answer
Line 99:
--
To view, visit http://gerrit.ovirt.org/12512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
