Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Making DC/cluster substab resizable
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14258
To unsubscribe, visit http://gerrit.ovirt.
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Making VM related substabs resizable
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14253
To unsubscribe, visit http://gerrit.ovirt
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: Making DC/cluster substab resizable
..
webadmin: Making DC/cluster substab resizable
Change-Id: I707c028cd034b1aea5a62b44831150d2111e326c
Signed-off-b
Tomas Jelinek has posted comments on this change.
Change subject: userportal: Fix exception on browser resizing
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14240
To unsubscribe, visit http://gerrit.ovirt.
Tomas Jelinek has posted comments on this change.
Change subject: userportal: closing RDP crashes IE
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/gwt-co
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: Introducing findbugs filter to bll module
..
Patch Set 3: (1 inline comment)
File backend/manag
Ravi Nori has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#882946)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/14257
To unsubscribe, vi
Sharad Mishra has posted comments on this change.
Change subject: restapi: WIP: Created restapi interface for backup.
..
Patch Set 1: (1 inline comment)
File
backend/manager
Sharad Mishra has posted comments on this change.
Change subject: restapi: WIP: Add support for backup APIs.
..
Patch Set 2:
In patch set 2, I have removed Actions like preview, undo, commit etc. And also
removed nic, disk, c
Ravi Nori has posted comments on this change.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14257
To unsubscribe, vi
Ravi Nori has uploaded a new change for review.
Change subject: restapi: if filter: header is set, use query instead of search
(#869334)
..
restapi: if filter: header is set, use query instead of search (#869334)
When the filte
Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: branding support.
..
Patch Set 11:
Hello,
Just for the [public] record.
When designing pluggable infrastructure, the ultimate test is if t
Tal Nisan has posted comments on this change.
Change subject: core: Remove ImageStatus.INVALID
..
Patch Set 3: Looks good to me, approved
Nice catch Alissa
--
To view, visit http://gerrit.ovirt.org/14194
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: findbugs: String compression is not using equals method
..
Patch Set 1: (5 inline comments)
Some comments that are not relevant to the scope of the change directly b
Tal Nisan has posted comments on this change.
Change subject: findbugs: Field masks field in superclass
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14197
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: branding support.
..
Patch Set 11:
> Alon, the error message you are seeing is due to a XSRF token being used. if
> you close the browser t
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
..
Patch Set 2:
This was the whole point of the original feature, to automate the addition of
the management
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
..
Patch Set 14: Looks good to me, but someone else must approve
(2 inline comments)
Looks good!
Alexander Wels has posted comments on this change.
Change subject: userportal, webadmin: branding support.
..
Patch Set 11: Verified
Alon, the error message you are seeing is due to a XSRF token being used. if
you close the br
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/
Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/723/
Build Number: 723
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Allon Mureinik has posted comments on this change.
Change subject: core: Add IDs to ImageStatus
..
Patch Set 3: Verified
Fixed long lines in the commit message, no code changes
--
To view, visit http://gerrit.ovirt.org/14193
T
Allon Mureinik has posted comments on this change.
Change subject: core: Add IDs to ImageStatus
..
Patch Set 3: Looks good to me, approved
Fixed long lines in the commit message, no code changes
--
To view, visit http://gerrit
Juan Hernandez has posted comments on this change.
Change subject: core, restapi: Don't store domain suffix in user name
..
Patch Set 1: Verified
This is not urgent, but it would simplify some of the changes that I am doing
re
Juan Hernandez has uploaded a new change for review.
Change subject: core, restapi: Don't store domain suffix in user name
..
core, restapi: Don't store domain suffix in user name
Currently when we save the information about an
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Change executed method name in frontend callbacks
..
frontend: Change executed method name in frontend callbacks
Changed the IFrontendMultipleActi
Tal Nisan has posted comments on this change.
Change subject: frontend: Change executed method name in frontend callbacks
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14254
To u
Tal Nisan has posted comments on this change.
Change subject: frontend: Change executed method name in frontend callbacks
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14254
To unsubscribe, visit http://ger
Asaf Shakarchi has posted comments on this change.
Change subject: frontend: Change executed method name in frontend callbacks
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14254
To unsubs
Allon Mureinik has posted comments on this change.
Change subject: findbugs: String compression is not using equals method
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: frontend: Change executed method name in frontend callbacks
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Allon Mureinik has submitted this change and it was merged.
Change subject: core: restrict comp version of edit storage conn
..
core: restrict comp version of edit storage conn
Added upgrade script that restricts the compatibil
Allon Mureinik has posted comments on this change.
Change subject: core: restrict comp version of edit storage conn
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14249
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: Remove get image info call before images commands
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Field masks field in superclass
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14197
To uns
Allon Mureinik has posted comments on this change.
Change subject: restapi: WIP: Created restapi interface for backup.
..
Patch Set 1: (1 inline comment)
see my main question inline.
Can we get a version with mock-uped actions
Allon Mureinik has posted comments on this change.
Change subject: restapi: WIP: Add support for backup APIs.
..
Patch Set 1: (2 inline comments)
File
backend/manager/module
Allon Mureinik has posted comments on this change.
Change subject: core: restrict comp version of edit storage conn
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14249
To unsubscribe, visi
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: remove unneeded static method declarations
..
core: remove unneeded static method declarations
In AttachUserToVmFromPoolAndRunCommand class.
and a
Gilad Chaplik has posted comments on this change.
Change subject: core: remove unneeded static method declarations
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14245
To unsubscr
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: Making VM related substabs resizable
..
webadmin: Making VM related substabs resizable
VM, template and host related subtabs
Change-Id: Ibb8a7edcf437
Martin Pavlik has posted comments on this change.
Change subject: engine: Allow engine to configure management network
..
Patch Set 2: Verified
with this patch host is added without bridge, however it leads to host
non-operati
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix findbug errors in Linq.java
..
frontend: Fix findbug errors in Linq.java
Change-Id: I03d340ffe8286180f907785b998d6bbf3c0e09bd
Signed-off-by: T
Tal Nisan has posted comments on this change.
Change subject: frontend: Fix findbug errors in Linq.java
..
Patch Set 3: Verified; Looks good to me, approved
Rebased
--
To view, visit http://gerrit.ovirt.org/14212
To unsubscrib
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove unneeded static method declarations
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14245
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: userportal: closing RDP crashes IE
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/gwt-comm
Daniel Erez has posted comments on this change.
Change subject: webadmin: In some locales alerts and Events Icons overlapping
on text
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14250
T
Daniel Erez has posted comments on this change.
Change subject: frontend: Fix findbug errors in Linq.java
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14212
To unsubscribe, visit http://g
Daniel Erez has posted comments on this change.
Change subject: webadmin: capitalize Spice
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14231
To unsubscribe, visit http://gerrit.ovirt.org
Alona Kaplan has posted comments on this change.
Change subject: webadmin: In some locales alerts and Events Icons overlapping
on text
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14250
To unsubscribe, vi
Gilad Chaplik has posted comments on this change.
Change subject: core: remove unneeded static method declarations
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14245
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove get image info call before images commands
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13994
To unsubscribe,
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: Fix legend localization
..
userportal: Fix legend localization
Legend panel in the three info boxes of the resource view was too narrow
to h
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Fix legend localization
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14222
To unsubscribe, visit ht
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Fix legend localization
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14222
To unsubscribe, visit http://gerri
Daniel Erez has posted comments on this change.
Change subject: webadmin: expand Up/Down buttons for JP locale
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14246
To unsubscribe, visit htt
Daniel Erez has posted comments on this change.
Change subject: webadmin: fix truncated lined in "New Template" dialog
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14238
To unsubscribe, v
Lior Vernia has posted comments on this change.
Change subject: restapi: Added usages option to CLI add cluster network
..
Patch Set 1: Verified
Michael, please submit as I cannot.
--
To view, visit http://gerrit.ovirt.org/138
Yair Zaslavsky has posted comments on this change.
Change subject: engine: custom properties: allow '=' in regex
..
Patch Set 3: Looks good to me, but someone else must approve
Engine part - looks good.
--
To view, visit http:
Maor Lipchuk has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 6:
Please remove ImagesComparerByName as well
--
To view, visit http://gerrit.ovirt.org/13849
To unsubscribe,
ofri masad has posted comments on this change.
Change subject: userportal: Fix legend localization
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14222
To unsubscribe, visit http://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 6: (1 inline comment)
Commit Message
Line 10: manner.
Line
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
core: GetImageInfoVDSCommand - remove apparentsize
In GetImageInfoVDSCommand appertsize is read f
Allon Mureinik has posted comments on this change.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14176
To unsub
Allon Mureinik has posted comments on this change.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, no code changes.
--
To view, visit http://gerr
Tal Nisan has submitted this change and it was merged.
Change subject: core: Rename storage_pool entity to StoragePool
..
core: Rename storage_pool entity to StoragePool
Renamed the storage_pool entity to StoragePool to fit Jav
Tal Nisan has posted comments on this change.
Change subject: core: Rename storage_pool entity to StoragePool
..
Patch Set 4: Verified; Looks good to me, approved
Rebased
--
To view, visit http://gerrit.ovirt.org/14208
To unsu
Tal Nisan has posted comments on this change.
Change subject: core: Rename storage_pool entity to StoragePool
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14208
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disks and Snapshots sub-tabs resizable columns
..
webadmin: Disks and Snapshots sub-tabs resizable columns
Disks and Snapshots sub-tabs now supp
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disks and Snapshots sub-tabs resizable columns
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14216
To un
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disks main-tab: sub-tabs resizable columns
..
webadmin: Disks main-tab: sub-tabs resizable columns
Sub-tabs under Disks main-tab now support
res
Laszlo Hornyak has posted comments on this change.
Change subject: core: Remove GetVdsHooksById2Query
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/utils/s
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disks main-tab: sub-tabs resizable columns
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14206
To unsubs
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Storage main-tab: sub-tabs resizable columns
..
webadmin: Storage main-tab: sub-tabs resizable columns
Sub-tabs under Storage main-tab now suppo
Daniel Erez has posted comments on this change.
Change subject: webadmin: Storage main-tab: sub-tabs resizable columns
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14205
To unsu
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
..
webadmin: DataCenters main-tab: sub-tabs resizable columns
Sub-tabs under DataCenters main-t
Daniel Erez has posted comments on this change.
Change subject: webadmin: DataCenters main-tab: sub-tabs resizable columns
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14105
To
Allon Mureinik has posted comments on this change.
Change subject: core: GetImageInfoVDSCommand - remove apparentsize
..
Patch Set 1:
> A side question - when you have a VM with 2 disks, each disc
> on a different domain - is
Maor Lipchuk has posted comments on this change.
Change subject: core: Rename storage_pool entity to StoragePool
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14208
To unsubscribe, visit h
Tal Nisan has posted comments on this change.
Change subject: core: Introducing the comparators package
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14192
To unsubscribe, visit http://ger
Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: Serve static content with web server
..
Patch Set 3:
Hi,
While at it, won't it be nicer to split dynamic content from static content in
tw
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: In some locales alerts and Events Icons overlapping
on text
..
webadmin: In some locales alerts and Events Icons overlapping on text
On the bottom Ale
Allon Mureinik has posted comments on this change.
Change subject: core: Rename storage_pool entity to StoragePool
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14208
To unsubscribe, visit
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use static memeber to get ISO regex pattern.
..
core: Use static memeber to get ISO regex pattern.
Use final static member instead recalculating th
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use name groups for ISO tools
..
core: Use name groups for ISO tools
Use java7 feature of name groups when matching cluster
and tool version for IS
Maor Lipchuk has posted comments on this change.
Change subject: core: Use name groups for ISO tools
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13899
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: core: Use static memeber to get ISO regex pattern.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14027
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 6: Verified
Fixed spelling mistake in package name
--
To view, visit http://gerrit.ovirt.org/13849
To unsubs
Maor Lipchuk has posted comments on this change.
Change subject: core: Use name groups for ISO tools
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13899
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: core: Use static memeber to get ISO regex pattern.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14027
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing the comparators package
..
Patch Set 2: Verified
Fixed spelling mistake in package name
--
To view, visit http://gerrit.ovirt.org/14192
To un
Michal Skrivanek has posted comments on this change.
Change subject: webadmin: capitalize Spice
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Allon Mureinik has posted comments on this change.
Change subject: frontend: Fix findbug errors in Linq.java
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14212
To uns
Alissa Bonas has posted comments on this change.
Change subject: core: restrict comp version of edit storage conn
..
Patch Set 1: Verified
the compatibility version error message is displayed correctly in webadmin when
trying
Allon Mureinik has posted comments on this change.
Change subject: core: remove unneeded static method declarations
..
Patch Set 1:
If you're going to do that, please also replace
bFacade.getInstance().getVmPoolDao() with getV
Omer Frenkel has submitted this change and it was merged.
Change subject: core: change the order of checks in canDoAction of migrate vm
..
core: change the order of checks in canDoAction of migrate vm
Change the order in which
Alissa Bonas has uploaded a new change for review.
Change subject: core: restrict comp version of edit storage conn
..
core: restrict comp version of edit storage conn
Added upgrade script that restricts the compatibility versio
Omer Frenkel has posted comments on this change.
Change subject: core: change the order of checks in canDoAction of migrate vm
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14247
Omer Frenkel has submitted this change and it was merged.
Change subject: core: [cleanup] split execute method of CreateAllSnapshots
..
core: [cleanup] split execute method of CreateAllSnapshots
CreateAllSnapshotsFromVmCommand#
Omer Frenkel has posted comments on this change.
Change subject: core: [cleanup] split execute method of CreateAllSnapshots
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14179
To
Arik Hadas has posted comments on this change.
Change subject: core: change the order of checks in canDoAction of migrate vm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14247
To unsubscribe, visit http://
1 - 100 of 215 matches
Mail list logo
