Tomas Jelinek has posted comments on this change. Change subject: userportal: closing RDP crashes IE ......................................................................
Patch Set 1: (1 inline comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpConnector.java Line 172 Line 173 Line 174 Line 175 Line 176 no, the connect() method cleans up the previous object - see line 205-206 in this file. So the objects will not float around - I have verified that it works and does the actual cleanup. So we still do the cleanup, just not from the context of an event fired by the object we are cleaning up. -- To view, visit http://gerrit.ovirt.org/14223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501bbd88ed77df2d3f8acb7fe61913a2888ce7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
