Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: branding support. ......................................................................
Patch Set 11: Hello, Just for the [public] record. When designing pluggable infrastructure, the ultimate test is if this infrastructure is good enough to be used by all use cases, including internal application functionality. In this case the core product (ovirt) branding can be implemented using the same infrastructure, this has [at least] the following advantages: * Consistency, all branding packages are implemented using the same mechanism. No legacy. * The infrastructure is used even without any external branding package, this way it is always is a working state, no need to test it explicitly. * The core product branding is a 'full branding' package, which can serve as an example for all external branding packages. By its nature it must evolve with product, so there is a good reference implementation without maintaining human documentation, which is always out of sync. * It provides clear interface (contract) between application and plugins, whatever exists in the core product branding package is available to external packages. I am recommending to re-consider the current approach and implement the core branding as a package. It should be easy facing this work... Thank you, Alon -- To view, visit http://gerrit.ovirt.org/13181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a8a426ce7d688d33c5ae2b70632c836843106b2 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
