Tal Nisan has posted comments on this change.
Change subject: findbugs: String compression is not using equals method
......................................................................
Patch Set 1: (5 inline comments)
Some comments that are not relevant to the scope of the change directly but can
cause regression in NPEs
....................................................
Commit Message
Line 3: AuthorDate: 2013-04-24 11:30:00 +0300
Line 4: Commit: Shahar Havivi <shav...@redhat.com>
Line 5: CommitDate: 2013-04-24 11:30:00 +0300
Line 6:
Line 7: findbugs: String compression is not using equals method
Please change compression to comparison when you rebase
Line 8:
Line 9: Change-Id: I740261ed3383e147928505ea53edc19e2996ce69
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java
Line 95:
Line 96: @Override
Line 97: public boolean isTrue() {
Line 98: String quotaName = getModel().getQuotaName();
Line 99: return quotaName != null &&
!quotaName.equals("");
I think !"".equals(quotaName) sounds better, it's null safe
Line 100: }
Line 101: }) {
Line 102: @Override
Line 103: public boolean isVisible() {
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
Line 96:
Line 97: @Override
Line 98: public boolean isTrue() {
Line 99: String quotaName = getModel().getQuotaName();
Line 100: return quotaName != null &&
!quotaName.equals("");
Same here
Line 101: }
Line 102: }) {
Line 103:
Line 104: @Override
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 1262: && getIsPowerManagementTabValid() &&
getConsoleAddress().getIsValid();
Line 1263: }
Line 1264:
Line 1265: private boolean isEntityModelEmpty(EntityModel model) {
Line 1266: return !(model.getEntity() != null &&
!model.getEntity().equals(""));
And here ;)
Line 1267: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java
Line 35: private void initTable(final ApplicationConstants constants, final
ApplicationMessages messages) {
Line 36: getTable().addColumn(new
TextColumnWithTooltip<QuotaVdsGroup>() {
Line 37: @Override
Line 38: public String getValue(QuotaVdsGroup object) {
Line 39: return object.getVdsGroupName() == null ||
object.getVdsGroupName().equals("") ?
constants.ultQuotaForAllClustersQuotaPopup()
And here ;)
Line 40: : object.getVdsGroupName();
Line 41: }
Line 42: },
Line 43: constants.nameCluster());
--
To view, visit http://gerrit.ovirt.org/14199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I740261ed3383e147928505ea53edc19e2996ce69
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
