Allon Mureinik has posted comments on this change.
Change subject: engine: remove unused roles_relations
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13940
To unsubsc
Vered Volansky has posted comments on this change.
Change subject: core: Fix typo in audit log message
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14017
To unsubscribe, visit http://gerrit.ovirt.org/setti
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3856/
Build Number: 3856
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Vered Volansky has uploaded a new change for review.
Change subject: core: Fix typo in audit log message
..
core: Fix typo in audit log message
In AuditLogMessages.properties the massage
VLAN_ID_MISMATCH_FOR_MANAGEMENT_NETWORK_C
Roy Golan has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
..
Patch Set 3:
Uwe please hit "Verify" if you where able to do a login with a domain user run
a search: go to "Users" -
Oved Ourfali has posted comments on this change.
Change subject: core: add repo_file_id to repo_file_meta_data
..
Patch Set 2: Looks good to me, approved
If you think someone else should review then go ahead and don't submit.
Roy Golan has posted comments on this change.
Change subject: core: Remove get image info call before images commands
..
Patch Set 1: (1 inline comment)
File
backend/manager
Oved Ourfali has posted comments on this change.
Change subject: core: unify GetImagesList using ImageFileType.All
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13867
Oved Ourfali has posted comments on this change.
Change subject: core: remove redundant image listing by pool
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13866
To unsubscribe, visit http
Oved Ourfali has posted comments on this change.
Change subject: findbugs: Classes that implements Comparator need to implement
Serializable
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: always update console from local storage
..
userportal: always update console from local storage
The details view of the basic view shows th
Tomas Jelinek has posted comments on this change.
Change subject: userportal: always update console from local storage
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13948
To unsu
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: pass smartcard option also to ActiveX
..
userportal,webadmin: pass smartcard option also to ActiveX
Since the SPICE ActiveX plugin
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: pass smartcard option also to ActiveX
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13969
T
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3855/
Build Number: 3855
Build Status: Unstable
Triggered By: Started by an SCM change
-
Changes Since Last Success:
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: PoolModelBehavior fix disk availability
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14016
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: pass smartcard option also to ActiveX
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13969
To unsubscrib
Daniel Erez has posted comments on this change.
Change subject: userportal: always update console from local storage
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13948
To unsubscribe, vis
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: PoolModelBehavior fix disk availability
..
webadmin: PoolModelBehavior fix disk availability
* Removed a redundant call to setIsDisksAvailable,
'setIsD
Yair Zaslavsky has posted comments on this change.
Change subject: core: removing org.apache.commons.lang dependency (5/15)
..
Patch Set 4: (1 inline comment)
File
backend/m
Roy Golan has submitted this change and it was merged.
Change subject: core: DLS in OvfLogEventHandler.addValueForAlias
..
core: DLS in OvfLogEventHandler.addValueForAlias
Removed the DLs regarding the OvfExportOnlyField annota
Roy Golan has posted comments on this change.
Change subject: core: DLS in OvfLogEventHandler.addValueForAlias
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13650
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: core: DLS in OvfLogEventHandler.addValueForAlias
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13650
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: core: initial module commit (4/15)
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Please remove white spaces.
.
Yair Zaslavsky has posted comments on this change.
Change subject: core: removing canRunVm helper compat method
..
Patch Set 3: (1 inline comment)
File
backend/manager/modul
Yair Zaslavsky has posted comments on this change.
Change subject: core: runVmCommandParams: remove get/setInternalExecution
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: core: runVmCommand.canDoAction clean up (13)
..
Patch Set 5: (1 inline comment)
File
backend/manager/modul
Vered Volansky has posted comments on this change.
Change subject: wip: core: RemoveImage as sync operation
..
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
..
Vered Volansky has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13849
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: core: runVmCommand.canDoAction clean-up (12)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13406
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (11)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13405
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (10)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13404
To
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (9)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13403
To u
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (8)
..
Patch Set 4: (1 inline comment)
File
backend/manager/module
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (7)
..
Patch Set 4: (1 inline comment)
File
backend/manager/module
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (6)
..
Patch Set 5: (1 inline comment)
File
backend/manager/module
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (5)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13401
To u
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (4)
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13400
To u
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (3)
..
Patch Set 5: (3 inline comments)
File
backend/manager/module
Allon Mureinik has posted comments on this change.
Change subject: core: unify and move Disk Comparators
..
Patch Set 4: Verified
As per Daniel's review, removed the frontend part of this patch.
It now organizes only the compe
Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules
Yair Zaslavsky has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
..
Patch Set 5: (2 inline comments)
File
ba
Justin Hammond has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1: No score
Yep, Let me know if that license is ok for oVirt, and if so, I
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Integrate Atlassian Crowd Client as a new
Authentication Domain
..
Patch Set 1:
There are news about the license of the client -
Please read here -
ht
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/846/
Build Number: 846
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Japanese - truncated text in snapshots sub-tab
..
webadmin: Japanese - truncated text in snapshots sub-tab
VMs - snapshots sub-tab:
- fix column
Daniel Erez has posted comments on this change.
Change subject: webadmin: Japanese - truncated text in snapshots sub-tab
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13888
To un
Alon Bar-Lev has posted comments on this change.
Change subject: userportal, webadmin: branding support[WIP].
..
Patch Set 6: (3 inline comments)
File
frontend/webadmin/modu
Alexander Wels has posted comments on this change.
Change subject: userportal, webadmin: branding support[WIP].
..
Patch Set 6: Verified
Once http://gerrit.ovirt.org/#/c/12695/ is merged, I will finish up the server
side local
Alexander Wels has posted comments on this change.
Change subject: userportal, webadmin: branding support[WIP].
..
Patch Set 5: (1 inline comment)
File
frontend/webadmin/mod
Ravi Nori has posted comments on this change.
Change subject: restapi : 'list' command does not work as expected(#947482)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13950
To unsubscribe, visit http://ger
Ravi Nori has posted comments on this change.
Change subject: cli: 'list' command does not work as expected
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14009
To unsubscribe, visit http://gerrit.ovirt.org/
Ravi Nori has uploaded a new change for review.
Change subject: cli: 'list' command does not work as expected
..
cli: 'list' command does not work as expected
List command with extra arguments does not show error
example: list c
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Japanese - truncated text in disk dialog
..
webadmin: Japanese - truncated text in disk dialog
Attach Disk dialog: fix columns' width.
Change-I
Daniel Erez has posted comments on this change.
Change subject: webadmin: Japanese - truncated text in disk dialog
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13887
To unsubscr
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: French - truncated text in luns list
..
webadmin: French - truncated text in luns list
Storage Domain dialog:
fix '#path' and 'Vendor Id' width.
Daniel Erez has posted comments on this change.
Change subject: webadmin: French - truncated text in luns list
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13890
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Japanese - truncated text in login button
..
webadmin: Japanese - truncated text in login button
Storage Domain dialog - target list:
fix 'Login
Daniel Erez has posted comments on this change.
Change subject: webadmin: Japanese - truncated text in login button
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13892
To unsubsc
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Japanese - truncated text in target list
..
webadmin: Japanese - truncated text in target list
Storage Domain dialog - target list:
fix 'Dev.Siz
Daniel Erez has posted comments on this change.
Change subject: webadmin: Japanese - truncated text in target list
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13891
To unsubscr
Daniel Erez has posted comments on this change.
Change subject: webadmin: Japanese - truncated text in login button
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13892
To unsubscribe, visit http://gerrit.ov
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Remove deprecated CopyTemplate logic
..
webadmin: Remove deprecated CopyTemplate logic
CopyTemplate is deprecated since MSD (multiple storage do
Daniel Erez has posted comments on this change.
Change subject: webadmin: Remove deprecated CopyTemplate logic
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13907
To unsubscribe,
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Remove deprecated MoveVm logic
..
webadmin: Remove deprecated MoveVm logic
MoveVm is deprecated since MSD (multiple storage domains),
hence its
Daniel Erez has posted comments on this change.
Change subject: webadmin: Remove deprecated MoveVm logic
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/13906
To unsubscri
Daniel Erez has posted comments on this change.
Change subject: webadmin: Network->Cluster subtab has trunacted columns.
..
Patch Set 2: Looks good to me, approved
Just note that for resizable columns in sub-tabs we will need t
Daniel Erez has posted comments on this change.
Change subject: webadmin: Template->network interface subtab has truncatred
columns
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
...
Daniel Erez has submitted this change and it was merged.
Change subject: core: VmInfoBuilder - use VdsProperties.IDE
..
core: VmInfoBuilder - use VdsProperties.IDE
VmInfoBuilder - use VdsProperties.IDE constant
instead of hard-
Daniel Erez has posted comments on this change.
Change subject: core: VmInfoBuilder - use VdsProperties.IDE
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/13877
To unsubs
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Perform string sanitization on messages
..
agent: Perform string sanitization on messages
Messages sent via VirtIO are now checked for being prese
Barak Azulay has posted comments on this change.
Change subject: agent: Perform string sanitization on messages
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13608
To unsubscribe, visit ht
Vinzenz Feenstra has posted comments on this change.
Change subject: agent: Perform string sanitization on messages
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Introduction of Poller, CommandEntity and Ehcache
..
Patch Set 3:
Rebased against master -
commit hash -a2f255d5f56a6f2eec53d0a74073d713020b3459
--
To
Daniel Erez has submitted this change and it was merged.
Change subject: core: DiskInterface enum - remove deprecated SCSI
..
core: DiskInterface enum - remove deprecated SCSI
SCSI DiskInterface is not supported, hence removing
Daniel Erez has posted comments on this change.
Change subject: core: DiskInterface enum - remove deprecated SCSI
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13885
To unsubscri
Daniel Erez has submitted this change and it was merged.
Change subject: core: VdsProperties - rename NETWORK_INTERFACE
..
core: VdsProperties - rename NETWORK_INTERFACE
VdsProperties -> NETWORK_INTERFACE constant is used both
Daniel Erez has posted comments on this change.
Change subject: core: VdsProperties - rename NETWORK_INTERFACE
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13875
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: core: use local TX in AddVm flow
..
Patch Set 4: (1 inline comment)
Generally looks good, see minor comment inside
..
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3849/
Build Number: 3849
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Ravi Nori has posted comments on this change.
Change subject: sdk: Implement Session-TTL header support #928313
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13979
To
Ravi Nori has posted comments on this change.
Change subject: sdk: refactor invocation flow #949189, #949187
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13894
To uns
Martin Beták has posted comments on this change.
Change subject: engine: Ability to assign multiple VMs from a pool to single
user
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14005
To unsubscribe, visit
Martin Beták has posted comments on this change.
Change subject: restapi: Added VmPool.max_assigned_vms_per_user
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14006
To unsubscribe, visit http://gerrit.ovirt
Martin Beták has posted comments on this change.
Change subject: webadmin: GUI support for setting the new
VmPool.maxAssignedVmsPerUser property
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/14007
To unsub
Ravi Nori has posted comments on this change.
Change subject: core: remove redundant image listing by pool
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13866
To unsub
Martin Beták has uploaded a new change for review.
Change subject: restapi: Added VmPool.max_assigned_vms_per_user
..
restapi: Added VmPool.max_assigned_vms_per_user
Added max_assigned_vms_per_user to vmpool
Change-Id: I9bbe202
Martin Beták has uploaded a new change for review.
Change subject: engine: Ability to assign multiple VMs from a pool to single
user
..
engine: Ability to assign multiple VMs from a pool to single user
Added a new field VmPool.
Martin Beták has uploaded a new change for review.
Change subject: webadmin: GUI support for setting the new
VmPool.maxAssignedVmsPerUser property
..
webadmin: GUI support for setting the new VmPool.maxAssignedVmsPerUser propert
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix the enable-dao-tests
..
core: Fix the enable-dao-tests
Change Ia736419e added a database test to DbConfigUtilsTest, which was
not a database
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix the enable-dao-tests
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14004
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: Fix the enable-dao-tests
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/14004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix the enable-dao-tests
..
core: Fix the enable-dao-tests
Change Ia736419e added a database test to DbConfigUtilsTest, which was
not a database test ori
Gilad Chaplik has posted comments on this change.
Change subject: core: Remove get image info call before images commands
..
Patch Set 1: (1 inline comment)
File
backend/man
Allon Mureinik has posted comments on this change.
Change subject: findbugs: Classes that implements Comparator need to implement
Serializable
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit h
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3848/
Build Number: 3848
Build Status: Still Unstable
Triggered By: Started by an SCM change
-
Changes Since Last Success:
--
Omer Frenkel has posted comments on this change.
Change subject: engine: VmTemplate cleanup (2/3)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13433
To unsubscribe, visit http://gerrit.ov
Ravi Nori has posted comments on this change.
Change subject: engine : ovirt-node enter installing status when the install
fails
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13997
To unsubscribe, visit ht
Ravi Nori has uploaded a new change for review.
Change subject: engine : ovirt-node enter installing status when the install
fails
..
engine : ovirt-node enter installing status when the install fails
When ovirt-node installati
Laszlo Hornyak has posted comments on this change.
Change subject: engine: unit test for isCpuPinningValid
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bl
1 - 100 of 354 matches
Mail list logo
