Laszlo Hornyak has posted comments on this change.
Change subject: engine: unit test for isCpuPinningValid
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
Line 27: vmStatic.setNumOfSockets(6);
Line 28: vmStatic.setCpuPerSocket(2);
Line 29: vmStatic.setDedicatedVmForVds(null);
Line 30: Assert.assertFalse(test.isCpuPinningValid("0#0", vmStatic));
Line 31:
Assert.assertFalse(test.getReturnValue().getCanDoActionMessages().isEmpty());
ah yes that's true
Line 32: Assert.assertFalse(test.getReturnValue()
Line 33: .getCanDoActionMessages()
Line 34:
.contains(VdcBllMessages.ACTION_TYPE_FAILED_VM_CANNOT_BE_PINNED_TO_CPU_WITH_UNDEFINED_HOST));
Line 35: }
--
To view, visit http://gerrit.ovirt.org/13991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd736d87851d2250358a13c78a64f1a05d23db72
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
