Vered Volansky has posted comments on this change. Change subject: wip: core: RemoveImage as sync operation ......................................................................
Patch Set 6: Looks good to me, but someone else must approve (2 inline comments) .................................................... Commit Message Line 8: Line 9: * When performing RemoveImage command, the engine can treat the vds Line 10: command DeleteImageGroup as synchronous operation instead of asynchronous Line 11: (as it does before this patch). The call might be treated as synchronous Line 12: because as the call returns the image is considered to be non exist on the s/as/when ? As is not that clear here. comma after returns. s/non exist/non-existent Line 13: storage side and we shouldn't wait for the deletion to end before Line 14: proceeding with the related db updates. Line 15: Line 16: *When receiving an ImageDoesNotExist error from vdsm during remove image - Line 9: * When performing RemoveImage command, the engine can treat the vds Line 10: command DeleteImageGroup as synchronous operation instead of asynchronous Line 11: (as it does before this patch). The call might be treated as synchronous Line 12: because as the call returns the image is considered to be non exist on the Line 13: storage side and we shouldn't wait for the deletion to end before comma after side Line 14: proceeding with the related db updates. Line 15: Line 16: *When receiving an ImageDoesNotExist error from vdsm during remove image - Line 17: proceed with removing the image as it doesn't exist. -- To view, visit http://gerrit.ovirt.org/13611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
