Juan Hernandez has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13829
To u
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standards.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://ge
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standards.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://ge
Gilad Chaplik has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
..
Patch Set 5: (1 inline comment)
File
back
Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: implement VM builder
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13915
To unsubscribe, visit http://gerrit.ovirt.org/
Gilad Chaplik has posted comments on this change.
Change subject: engine: AssignQuota button under disks refresh bug
..
Patch Set 4: (5 inline comments)
Commit Message
Line 3
Tomas Jelinek has posted comments on this change.
Change subject: frontend: Switching spice invoker implementation in console
dialog
..
Patch Set 1: (2 inline comments)
File
Roy Golan has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
..
Patch Set 2: (3 inline comments)
File
backend/manager/modules/bl
Alon Bar-Lev has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
..
Patch Set 2:
> OpenLdap is a step forward for local-authentication for oVirt. it has a
> backend that works with /
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standards.
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/13952
To unsubscribe, visit
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standards.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13951
To unsubscribe, visit
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standards.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13949
To unsubscribe, visit
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
..
Patch Set 4: Looks good to me, approved
(1 inline comment)
very minor comment in-line.
.
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: I06df2152c0302ea2dd494f940b
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: spec: add newline after each changelog entry
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13962
To un
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13949
To unsubscribe, visit
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13952
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: spec: add newline after each changelog entry
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13963
To un
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: Ib5a5a3b421f69b6a94bb1dae69
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: spec: add newline after each changelog entry
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13962
To un
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: I3b1e51246b8826bfa646642680
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: spec: add newline after each changelog entry
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13961
To un
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: I933027c541bbd0f1514ab72688
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: spec: add newline after each changelog entry
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13960
To un
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13951
To unsubscribe, visit
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: Ib5a5a3b421f69b6a94bb1dae6958c15e09
Allon Mureinik has posted comments on this change.
Change subject: core: Mount options not sent when adding POSIX domain
..
Patch Set 1: I would prefer that you didn't submit this
No, wait, sorry.
POSIX and GLUSTER don't exist
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: I06df2152c0302ea2dd494f940b4bc44826
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: I3b1e51246b8826bfa6466426805b7f20bc
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
...
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: spec: add newline after each changelog entry
..
packaging: spec: add newline after each changelog entry
Change-Id: I933027c541bbd0f1514ab726886d1962db
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: (1 inline comment)
Com
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
...
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://ge
Oved Ourfali has posted comments on this change.
Change subject: core: unify GetImagesList using ImageFileType.All
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
1. minor comment that you ca
Roy Golan has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
..
Patch Set 2:
Thanks a lot for the work.
OpenLdap is a step forward for local-authentication for oVirt. it has a backen
Oved Ourfali has posted comments on this change.
Change subject: core: remove redundant image listing by pool
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13866
To un
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Disable Gluster hooks
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13574
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Allon Mureinik has posted comments on this change.
Change subject: core: Mount options not sent when adding POSIX domain
..
Patch Set 1: Looks good to me, but someone else must approve
@Tal - now I get it, thanks
--
To view, v
Allon Mureinik has posted comments on this change.
Change subject: core, webadmin: unify and move Disk Comparators
..
Patch Set 3: (1 inline comment)
Daniel - what do you suggest.
I really hate this code duplication
..
Daniel Erez has posted comments on this change.
Change subject: engine: AssingQuota button under disks refresh bug
..
Patch Set 4: (4 inline comments)
Commit Message
Line 3:
Laszlo Hornyak has abandoned this change.
Change subject: engine: send nic parameter in vmUpdateDevice [wip]
..
Patch Set 1: Abandoned
that's even better for me. guys, you can handle this bug
--
To view, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove unused VmLockCommad
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13864
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Removed MigrateIrsSnapshotsToVdcCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13954
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: notifier startup script startup directory
..
tools: notifier startup script startup directory
The notification daemon startup script attempts to
Yair Zaslavsky has posted comments on this change.
Change subject: tools: notifier startup script startup directory
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13959
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: tools: notifier startup script startup directory
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13959
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: core, webadmin: unify and move Disk Comparators
..
Patch Set 3: I would prefer that you didn't submit this
I actually prefer not to use it in the UI until finding
Daniel Erez has posted comments on this change.
Change subject: core, webadmin: unify and move Disk Comparators
..
Patch Set 3: (1 inline comment)
I find it bothering as well. We're trying to decouple common from the client as
Tal Nisan has posted comments on this change.
Change subject: core, webadmin: unify and move Disk Comparators
..
Patch Set 3: Looks good to me, approved
I can't say that it doesn't bother me a bit that a comparator class reside
Tal Nisan has posted comments on this change.
Change subject: core: Remove validateStorageServerConnection
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13957
To unsubscribe, visit http://
Tal Nisan has posted comments on this change.
Change subject: core: Mount options not sent when adding POSIX domain
..
Patch Set 1:
Yes but why do you have to check the compatibility of advanced NFS options in
the pool in case
Dan Kenigsberg has posted comments on this change.
Change subject: engine: send nic parameter in vmUpdateDevice [wip]
..
Patch Set 1: I would prefer that you didn't submit this
I do not see why this argument is needed (or what
Ravi Nori has posted comments on this change.
Change subject: core: unify GetImagesList using ImageFileType.All
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13867
To
Greg Padgett has uploaded a new change for review.
Change subject: tools: notifier startup script startup directory
..
tools: notifier startup script startup directory
The notification daemon startup script attempts to change to
Federico Simoncelli has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http:/
Federico Simoncelli has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http:/
Federico Simoncelli has uploaded a new change for review.
Change subject: core: add repo_file_id to repo_file_meta_data
..
core: add repo_file_id to repo_file_meta_data
In order to support image repositories that define an id an
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13952
To unsubscribe, visit
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13951
To unsubscribe, visit
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13949
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused ExportCandaidateVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13956
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Remove validateStorageServerConnection
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13957
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Removed AddSelfPermissionCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13955
To unsubscribe, visit http://gerrit.ovirt.org/se
Allon Mureinik has posted comments on this change.
Change subject: core: Removed MigrateIrsSnapshotsToVdcCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13954
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Remove unused VmLockCommad
..
Patch Set 2: Verified
Rebased to keep current, no code changes.
--
To view, visit http://gerrit.ovirt.org/13864
To unsubscr
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove validateStorageServerConnection
..
core: Remove validateStorageServerConnection
After change I7b3bc2491943a6daa21228e37169c83f32865984 removed all
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed AddSelfPermissionCommand
..
core: Removed AddSelfPermissionCommand
This command is unused, and it does not seem to have any meaningful
content, a
Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove unused ExportCandaidateVDSCommand
..
core: Remove unused ExportCandaidateVDSCommand
ExportCandidateVDSCommand was not used anywhere in the code, a
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed MigrateIrsSnapshotsToVdcCommand
..
core: Removed MigrateIrsSnapshotsToVdcCommand
This command is unused (and all its content is commented out any
Allon Mureinik has posted comments on this change.
Change subject: engine: remove ObjectStreamSerializer default constructor
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: engine: remve command serialVersionUid fields
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13946
To
Allon Mureinik has posted comments on this change.
Change subject: engine: TimeoutBase does not have to be serialized
..
Patch Set 1: Looks good to me, but someone else must approve
I couldn't find anywhere it should be seriali
Frank Kobzik has posted comments on this change.
Change subject: engine: Integrate noVNC support
..
Patch Set 2: No score
Removing +1 from verified as this patch has to be enhanced by integrating
customized websockets script i
Frank Kobzik has uploaded a new change for review.
Change subject: frontend: Switching spice invoker implementation in console
dialog
..
frontend: Switching spice invoker implementation in console dialog
This patch allows switc
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: test for AddVdsCommand
..
engine: test for AddVdsCommand
Adds test for canDoAction.
Change-Id: Iaa8b31e3bb4f96e34d7ea7e97ec8c4c5b1f19984
Signe
Laszlo Hornyak has posted comments on this change.
Change subject: engine: test for AddVdsCommand
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12193
To unsubscribe, visit http:/
Kiril Nesenko has posted comments on this change.
Change subject: sos - refactored engine sos plugin
..
Patch Set 2: (1 inline comment)
File src/__main__.py
Line 1413:
Line
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13952
To unsubscribe, visit
Kiril Nesenko has uploaded a new change for review.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
packaging: Change spec file according to the packaging standarts.
Change-Id: Ib4b85bffcadf
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13951
To unsubscribe, visit
Kiril Nesenko has uploaded a new change for review.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
packaging: Change spec file according to the packaging standarts.
Change-Id: Ice0a3eaf3c31
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13949
To unsubscribe, visit
Ravi Nori has uploaded a new change for review.
Change subject: restapi : 'list' command does not work as expected(#947482)
..
restapi : 'list' command does not work as expected(#947482)
List command with --max does not throw er
Kiril Nesenko has uploaded a new change for review.
Change subject: packaging: Change spec file according to the packaging
standarts.
..
packaging: Change spec file according to the packaging standarts.
Change-Id: I76932778002b
Sahina Bose has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Sahina Bose has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/bll/src/m
Frank Kobzik has posted comments on this change.
Change subject: userportal: always update console from local storage
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/139
Tomas Jelinek has posted comments on this change.
Change subject: userportal: always update console from local storage
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13948
To unsubscribe, visit http://gerrit
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: always update console from local storage
..
userportal: always update console from local storage
The details view of the basic view shows the SPICE
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refactoring GlusterManager
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src
Kanagaraj M has posted comments on this change.
Change subject: engine: filtering search based on Application Mode
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13704
To unsubscribe, visit http://gerrit.ovi
Vinzenz Feenstra has posted comments on this change.
Change subject: core: fix single sign on for all guests
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13667
To unsubscribe, visit http://gerrit.ovirt.org
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 2: (1 inline comment)
File packaging/fedora/spec/ovi
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: refactored firewalld support
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, visit http://gerrit.ovirt.org
Kanagaraj M has posted comments on this change.
Change subject: engine: VDS command - gluster hooks list
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/vdsb
Kanagaraj M has posted comments on this change.
Change subject: engine: VDS command to get gluster host UUID
..
Patch Set 3:
Thanks Sahina, Re-used OneUuidReturnForXmlRpc
--
To view, visit http://gerrit.ovirt.org/13941
To unsu
Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: remove ObjectStreamSerializer default constructor
..
engine: remove ObjectStreamSerializer default constructor
Removed the single default constructor a
Laszlo Hornyak has posted comments on this change.
Change subject: engine: remve command serialVersionUid fields
..
Patch Set 1: I would prefer that you didn't submit this
wip - I did not have time yet to fully test, just shari
1 - 100 of 126 matches
Mail list logo
