Allon Mureinik has uploaded a new change for review.

Change subject: core: Remove validateStorageServerConnection
......................................................................

core: Remove validateStorageServerConnection

After change I7b3bc2491943a6daa21228e37169c83f32865984 removed all
usages of the validateStorageServerConnection method from the engine's
code, this patch removes the method itself.

Change-Id: I2d87168e52e3b9df15418cbf3a6693ae00214de4
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
3 files changed, 0 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/13957/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
index 775e8f4..d65aa4a 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
@@ -92,10 +92,6 @@
 
     ServerConnectionStatusReturnForXmlRpc connectStorageServer(int serverType, 
String spUUID, Map<String, String>[] args);
 
-    @Deprecated
-    ServerConnectionStatusReturnForXmlRpc validateStorageServerConnection(int 
serverType, String spUUID,
-            Map<String, String>[] args);
-
     ServerConnectionStatusReturnForXmlRpc disconnectStorageServer(int 
serverType, String spUUID,
             Map<String, String>[] args);
 
diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
index cbc1a68..adfa09e 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
@@ -80,8 +80,6 @@
 
     public Map<String, Object> connectStorageServer(int serverType, String 
spUUID, Map<String, String>[] args);
 
-    public Map<String, Object> validateStorageServerConnection(int serverType, 
String spUUID, Map<String, String>[] args);
-
     public Map<String, Object> disconnectStorageServer(int serverType, String 
spUUID, Map<String, String>[] args);
 
     public Map<String, Object> getStorageConnectionsList(String spUUID);
diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
index e1e9ad3..8cdc3a3 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
@@ -445,20 +445,6 @@
     }
 
     @Override
-    public ServerConnectionStatusReturnForXmlRpc 
validateStorageServerConnection(int serverType, String spUUID,
-            Map<String, String>[] args) {
-        try {
-            Map<String, Object> xmlRpcReturnValue = 
vdsServer.validateStorageServerConnection(serverType, spUUID, args);
-            ServerConnectionStatusReturnForXmlRpc wrapper =
-                    new 
ServerConnectionStatusReturnForXmlRpc(xmlRpcReturnValue);
-            return wrapper;
-        } catch (UndeclaredThrowableException ute) {
-            throw new XmlRpcRunTimeException(ute);
-        }
-
-    }
-
-    @Override
     public ServerConnectionStatusReturnForXmlRpc disconnectStorageServer(int 
serverType, String spUUID,
             Map<String, String>[] args) {
         try {


--
To view, visit http://gerrit.ovirt.org/13957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d87168e52e3b9df15418cbf3a6693ae00214de4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to