Allon Mureinik has posted comments on this change. Change subject: core, webadmin: unify and move Disk Comparators ......................................................................
Patch Set 3: (1 inline comment) Daniel - what do you suggest. I really hate this code duplication .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java Line 181 Line 182 Line 183 Line 184 Line 185 There is no patch that produces Disks with null aliases. If there were, there's a bigger bug than not being able to sort them in the UI - you won't be able to run a VM with them. -- To view, visit http://gerrit.ovirt.org/13849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide5808ba4404d141f43911945e19f170e9694da4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
