Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed MigrateIrsSnapshotsToVdcCommand
......................................................................
core: Removed MigrateIrsSnapshotsToVdcCommand
This command is unused (and all its content is commented out anyway),
and thus can (and should be removed).
This patch removes the following:
1. The MigrateIrsSnapshotsRoVdcCommand class
2. The corresponding constant in VdcActionType
Change-Id: I6584a79c777c8b44c23159850d133c7c514b5c87
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
D
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateIrsSnapshotsToVdcCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
2 files changed, 1 insertion(+), 30 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/13954/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateIrsSnapshotsToVdcCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateIrsSnapshotsToVdcCommand.java
deleted file mode 100644
index 58212ad..0000000
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateIrsSnapshotsToVdcCommand.java
+++ /dev/null
@@ -1,26 +0,0 @@
-package org.ovirt.engine.core.bll;
-
-import java.util.Collections;
-import java.util.List;
-
-import org.ovirt.engine.core.bll.utils.PermissionSubject;
-import org.ovirt.engine.core.common.action.VdcActionParametersBase;
-
-@InternalCommandAttribute
-public class MigrateIrsSnapshotsToVdcCommand<T extends
VdcActionParametersBase> extends CommandBase<T> {
- public MigrateIrsSnapshotsToVdcCommand(T parameters) {
- super(parameters);
- }
-
- @Override
- protected void executeCommand() {
- // IrsSnapshotsToVdcMigrator.Migrate();
- }
-
- // TODO this command should be removed - AI Ofrenkel
- @Override
- public List<PermissionSubject> getPermissionCheckSubjects() {
- // Not needed for admin operations.
- return Collections.emptyList();
- }
-}
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
index 8be16c3..b0758c8 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
@@ -163,10 +163,7 @@
// AttachNetworkToVdsGroup is taking over this functionality
UpdateDisplayToVdsGroup(710, ActionGroup.EDIT_CLUSTER_CONFIGURATION,
false, QuotaDependency.NONE),
UpdateNetworkOnCluster(711, ActionGroup.CONFIGURE_CLUSTER_NETWORK, false,
QuotaDependency.NONE),
- /**
- * 4.0
- */
- MigrateIrsSnapshotsToVdc(707, QuotaDependency.NONE),
+
/**
* MultiLevelAdministration
*/
--
To view, visit http://gerrit.ovirt.org/13954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6584a79c777c8b44c23159850d133c7c514b5c87
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
